Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: CVE-2023-39325 & CVE-2023-44487 #37

Merged
merged 4 commits into from
Oct 27, 2023

Conversation

svghadi
Copy link
Member

@svghadi svghadi commented Oct 27, 2023

What type of PR is this?
/kind bug

What does this PR do / why we need it:
Fixes CVE-2023-39325 & CVE-2023-44487.
Changes:

  • Update golang to 1.20
  • Update golang.org/x/net to v0.17.0
  • Disable HTTP/2 by default on the server

How to test changes / Special notes to the reviewer:
Logs from local test to validate
HTTP/2 enabled

root@test-jxlfz:/# curl --insecure --head --http2 https://server-service:8080
HTTP/2 403 
content-type: text/plain; charset=utf-8
x-content-type-options: nosniff
content-length: 24
date: Fri, 27 Oct 2023 06:39:05 GMT

root@test-jxlfz:/# curl --insecure --head --http1.1 https://server-service:8080
HTTP/1.1 403 Forbidden
Content-Type: text/plain; charset=utf-8
X-Content-Type-Options: nosniff
Date: Fri, 27 Oct 2023 06:39:35 GMT
Content-Length: 24

HTTP/2 Disabled

root@test-jxlfz:/# curl --insecure --head --http2 https://server-service:8080
HTTP/1.1 403 Forbidden
Content-Type: text/plain; charset=utf-8
X-Content-Type-Options: nosniff
Date: Fri, 27 Oct 2023 07:05:41 GMT
Content-Length: 24

root@test-jxlfz:/# curl --insecure --head --http1.1 https://server-service:8080
HTTP/1.1 403 Forbidden
Content-Type: text/plain; charset=utf-8
X-Content-Type-Options: nosniff
Date: Fri, 27 Oct 2023 07:05:44 GMT
Content-Length: 24

Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com>
@openshift-ci
Copy link

openshift-ci bot commented Oct 27, 2023

@svghadi: The label(s) kind/bug cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?
/kind bug

What does this PR do / why we need it:

Have you updated the necessary documentation?

  • Documentation update is required by this PR.
  • Documentation has been updated.

Which issue(s) this PR fixes:

Fixes #?

How to test changes / Special notes to the reviewer:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com>
Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com>
Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com>
@svghadi svghadi mentioned this pull request Oct 27, 2023
2 tasks
Copy link

@iam-veeramalla iam-veeramalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@iam-veeramalla
Copy link

/approve

Copy link
Member

@chetan-rns chetan-rns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci
Copy link

openshift-ci bot commented Oct 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chetan-rns, iam-veeramalla

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot merged commit 23505de into redhat-developer:master Oct 27, 2023
11 checks passed
@svghadi svghadi deleted the cve-fix branch October 27, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants