Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pull argoproj-labs/argocd-operator#555 (RH-SSO enhancements) #291

Merged
merged 1 commit into from
Mar 23, 2022
Merged

feat: pull argoproj-labs/argocd-operator#555 (RH-SSO enhancements) #291

merged 1 commit into from
Mar 23, 2022

Conversation

iam-veeramalla
Copy link
Collaborator

What type of PR is this?

/kind enhancement

What does this PR do / why we need it:

pulls argoproj-labs/argocd-operator#555

This PR adds the below enhancements.

More technical details

  • Removed hardcoded OIDC client secrets and replaced them by generated random strings. These client secrets do not need to be stored.
  • Added KeycloakIdentityProviderMapper to workaround Add support for identityProviderMappers in KeycloakRealm CR keycloak/keycloak-operator#471. Without the workaround, tokens can't be translated to credentials that contain the group identity.
  • Propagated proxy environment variables from operator to Keycloak containers so that outbound calls can go through cluster proxy if cluste proxy is configured.
  • Delete OAuth client using foreground propagation policy to ensure that the garbage collector removes all instantiated objects before the TemplateInstance itself disappears.
  • Add extra Delete OAuth client calls to workaround OAuthClient does not get deleted intermittently. openshift/client-go#209
  • Add retries to handle RHSSO image upgrade

For more information please refer
argoproj-labs/argocd-operator#555

@iam-veeramalla iam-veeramalla changed the title feat: pull latest from argocd-operator feat: pull argoproj-labs/argocd-operator#555 (RH-SSO enhancements) Mar 23, 2022
Copy link
Member

@chetan-rns chetan-rns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci
Copy link

openshift-ci bot commented Mar 23, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chetan-rns

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@iam-veeramalla iam-veeramalla merged commit 525a663 into redhat-developer:v1.5 Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants