Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update doc to reflect extended support for sso deprecated fields #503

Merged
merged 2 commits into from May 19, 2023

Conversation

svghadi
Copy link
Member

@svghadi svghadi commented May 11, 2023

What type of PR is this?
/kind documentation

What does this PR do / why we need it:
Follow up PR for argoproj-labs/argocd-operator#911 to update doc to reflect extended support for sso deprecated fields.

Have you updated the necessary documentation?

  • Documentation update is required by this PR.
  • Documentation has been updated.

Which issue(s) this PR fixes:

Fixes GITOPS-2904

@openshift-ci openshift-ci bot added the kind/documentation Improvements or additions to documentation label May 11, 2023
@openshift-ci openshift-ci bot requested review from sbose78 and wtam2018 May 11, 2023 09:33
@openshift-ci
Copy link

openshift-ci bot commented May 11, 2023

Hi @svghadi. Thanks for your PR.

I'm waiting for a redhat-developer member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@varshab1210
Copy link
Collaborator

/ok-to-test

@svghadi
Copy link
Member Author

svghadi commented May 16, 2023

/test v4.12-kuttl-sequential

@svghadi
Copy link
Member Author

svghadi commented May 16, 2023

/test v4.10-kuttl-sequential

@svghadi
Copy link
Member Author

svghadi commented May 17, 2023

/retest

@openshift-ci
Copy link

openshift-ci bot commented May 17, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign chetan-rns for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com>
Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com>
@svghadi
Copy link
Member Author

svghadi commented May 17, 2023

/retest

@svghadi
Copy link
Member Author

svghadi commented May 17, 2023

/test v4.11-kuttl-sequential

1 similar comment
@svghadi
Copy link
Member Author

svghadi commented May 18, 2023

/test v4.11-kuttl-sequential

@varshab1210
Copy link
Collaborator

/retest

1 similar comment
@varshab1210
Copy link
Collaborator

/retest

@openshift-ci
Copy link

openshift-ci bot commented May 18, 2023

@svghadi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v4.10-kuttl-sequential 671ab32 link true /test v4.10-kuttl-sequential
ci/prow/v4.11-kuttl-sequential 671ab32 link true /test v4.11-kuttl-sequential

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@iam-veeramalla iam-veeramalla merged commit 224d9be into redhat-developer:master May 19, 2023
13 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation Improvements or additions to documentation ok-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants