Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for IntelliJ 2022.1 #109

Merged
merged 5 commits into from
Jun 24, 2022
Merged

Add support for IntelliJ 2022.1 #109

merged 5 commits into from
Jun 24, 2022

Conversation

zcervink
Copy link
Contributor

Fixes #108

Signed-off-by: Zbynek Cervinka zcervink@redhat.com

@zcervink zcervink added the enhancement New feature or request label Apr 20, 2022
@zcervink zcervink self-assigned this Apr 20, 2022
@redhat-developer redhat-developer deleted a comment from sonarcloud bot Apr 29, 2022
@zcervink zcervink force-pushed the 108 branch 10 times, most recently from 5d1c8f0 to f2c2e97 Compare May 13, 2022 05:19
@redhat-developer redhat-developer deleted a comment from sonarcloud bot Jun 15, 2022
@zcervink
Add support for IntelliJ 2022.1
4e1237b 
Fixes redhat-developer#108

Signed-off-by: Zbynek Cervinka <zcervink@redhat.com>
@zcervink zcervink requested a review from odockal June 21, 2022 19:32
@zcervink zcervink marked this pull request as ready for review June 21, 2022 19:32
@zcervink
Copy link
Contributor Author

@odockal Please review

odockal
odockal requested changes Jun 23, 2022
View reviewed changes
Copy link
Collaborator

@odockal odockal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enum can be in its own file. no need to wrapping it into java class

@zcervink
Several fixes and reworks:
beb3b36 
- exctraction of the enumeration with supported IntelliJs to start
- rewrite some tests to use conditional test execution
- fix linux failing test
- change the 10 second timeout to 2 seconds

Signed-off-by: Zbynek Cervinka <zcervink@redhat.com>
odockal
odockal reviewed Jun 23, 2022
View reviewed changes
.../redhat/devtools/intellij/commonuitest/fixtures/mainidewindow/idestatusbar/IdeStatusBar.java Outdated
* Wait until all the background tasks finish
*/
public void waitUntilAllBgTasksFinish(int timeout) {
waitFor(Duration.ofSeconds(timeout), Duration.ofSeconds(10), "The background tasks did not finish in 10 minutes.", this::didAllBgTasksFinish);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error message should change to timeout seconds, right? It is not 10 minutes anymore.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, I have overlooked that. But anyway - I have decided to delete the entire method after all, the test failing due to the timeout is back green. There must be some minor updates from JetBrains to the version 2022.1 that made the test failing and also made it green again.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update: it looks like the issue with timeout is back again. I tried to increase timeout to 400 (only in the one place, so the parametrized method will be handy - with fixed error message)

@odockal odockal self-requested a review June 23, 2022 14:34
@zcervink
Move the enumeration from inside a class to toplevel.
afb7e5b 
Signed-off-by: Zbynek Cervinka <zcervink@redhat.com>
odockal
odockal requested changes Jun 23, 2022
View reviewed changes
Copy link
Collaborator

@odockal odockal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You do not need to wrap the enum into java class. you can create enum file with enum directly.

@zcervink
Copy link
Contributor Author

Enum can be in its own file. no need to wrapping it into java class

Fixed

@zcervink
Copy link
Contributor Author

You do not need to wrap the enum into java class. you can create enum file with enum directly.

Fixed

@zcervink
Timeout 400
297ac70 
Signed-off-by: Zbynek Cervinka <zcervink@redhat.com>
@zcervink
Timeout 500
4e80e9d 
Signed-off-by: Zbynek Cervinka <zcervink@redhat.com>
@odockal odockal merged commit f922e45 into redhat-developer:main Jun 24, 2022
@zcervink zcervink deleted the 108 branch June 24, 2022 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odockal odockal odockal approved these changes

Assignees

@zcervink zcervink

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for IntelliJ 2022.1
2 participants
@zcervink @odockal