New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Introducing UI tests #387
Conversation
Kudos, SonarCloud Quality Gate passed! |
@sbouchet This is new PR as I could not updated referenced one for introducing UI tests. |
d637a3b
to
58612a3
Compare
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -75,6 +90,10 @@ dependencies { | |||
testCompile 'org.awaitility:awaitility:4.1.0' | |||
testCompile 'org.mock-server:mockserver-client-java:5.13.2' | |||
testCompile 'org.mock-server:mockserver-netty:5.13.2' | |||
testImplementation 'com.redhat.devtools.intellij:intellij-common-ui-test-library:0.2.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please use same layout as above for new dependencies listed below.
build.gradle
Outdated
systemProperties['com.redhat.devtools.intellij.telemetry.mode'] = 'debug' | ||
systemProperty "idea.trust.all.projects", "true" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please re-order new properties below existing and use same layout, without the parenthesis.
Signed-off-by: Ondrej Dockal <odockal@redhat.com>
Kudos, SonarCloud Quality Gate passed! |
Signed-off-by: Ondrej Dockal odockal@redhat.com
What is the purpose of this change? What does it change?
Was the change discussed in an issue?
fixes #???
How to test changes?