Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Introducing UI tests #387

Merged
merged 1 commit into from Nov 2, 2022
Merged

Conversation

odockal
Copy link
Contributor

@odockal odockal commented Mar 7, 2022

Signed-off-by: Ondrej Dockal odockal@redhat.com

What is the purpose of this change? What does it change?

Was the change discussed in an issue?

fixes #???

How to test changes?

@sonarcloud
Copy link

sonarcloud bot commented Mar 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@odockal odockal changed the title Introducing UI tests feat: Introducing UI tests Mar 16, 2022
@odockal
Copy link
Contributor Author

odockal commented Mar 28, 2022

@sbouchet This is new PR as I could not updated referenced one for introducing UI tests.

@odockal odockal force-pushed the ui-refactor branch 2 times, most recently from d637a3b to 58612a3 Compare July 15, 2022 07:16
@sonarcloud
Copy link

sonarcloud bot commented Jul 15, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link

@olkornii olkornii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -75,6 +90,10 @@ dependencies {
testCompile 'org.awaitility:awaitility:4.1.0'
testCompile 'org.mock-server:mockserver-client-java:5.13.2'
testCompile 'org.mock-server:mockserver-netty:5.13.2'
testImplementation 'com.redhat.devtools.intellij:intellij-common-ui-test-library:0.2.0'
Copy link
Collaborator

@sbouchet sbouchet Nov 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use same layout as above for new dependencies listed below.

build.gradle Outdated
systemProperties['com.redhat.devtools.intellij.telemetry.mode'] = 'debug'
systemProperty "idea.trust.all.projects", "true"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please re-order new properties below existing and use same layout, without the parenthesis.

Signed-off-by: Ondrej Dockal <odockal@redhat.com>
@sonarcloud
Copy link

sonarcloud bot commented Nov 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@odockal odockal merged commit 7f8ccb4 into redhat-developer:main Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants