This repository has been archived by the owner on Mar 12, 2021. It is now read-only.
Ensure cached images are refreshed periodically #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of just checking daemonset health every CACHING_INTERVAL, instead recreate the deamonset to ensure each image is re-pulled. This is required for caching mutable image tags, such as latest or nightly. Signed-off-by: Angel Misevski <amisevsk@redhat.com>
ibuziuk
approved these changes
Aug 23, 2019
ibuziuk
pushed a commit
to ibuziuk/kubernetes-image-puller
that referenced
this pull request
Aug 11, 2020
correct docker push command
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Instead of just checking daemonset health every CACHING_INTERVAL, instead recreate the deamonset to ensure each image is re-pulled. This is required for caching mutable image tags, such as latest or nightly.
Also changes "wait" operations to report if the channel is closed prematurely.
What issue does this PR resolve?
redhat-developer/rh-che#1549