Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated Nodejs images #64

Closed
wants to merge 2 commits into from
Closed

Remove deprecated Nodejs images #64

wants to merge 2 commits into from

Conversation

amitkrout
Copy link
Contributor

@kadel
Copy link
Member

kadel commented Jul 1, 2020

There needs to be a matching PR on odo cli https://github.com/openshift/odo/blob/9a470629475bf6339dec637ee5ea8e326188a7fd/pkg/catalog/catalog.go#L460

@kadel
Copy link
Member

kadel commented Jul 14, 2020

ping @amitkrout

@amitkrout amitkrout mentioned this pull request Jul 16, 2020
Merged
3 tasks
@amitkrout amitkrout force-pushed the RemoveDeprecateNodejsImages branch from 9d7b8e9 to 3bbece7 Compare July 27, 2020 05:38
@amitkrout
Copy link
Contributor Author

There needs to be a matching PR on odo cli https://github.com/openshift/odo/blob/9a470629475bf6339dec637ee5ea8e326188a7fd/pkg/catalog/catalog.go#L460

Fixed via redhat-developer/odo#3587

@amitkrout amitkrout force-pushed the RemoveDeprecateNodejsImages branch 2 times, most recently from 831c05b to 9b782fd Compare July 27, 2020 08:33
@girishramnani
Copy link
Contributor

Usually we push to a personal docker repo and use that in odo to confirm that tests pass. I hope u do that @amitkrout
/approve

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: girishramnani

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 29, 2020
@amitkrout
Copy link
Contributor Author

Usually we push to a personal docker repo and use that in odo to confirm that tests pass. I hope u do that @amitkrout
/approve

Travis script is handling this through https://github.com/openshift/odo-init-image/blob/master/scripts/build-push-image.sh

@amitkrout
Copy link
Contributor Author

Usually we push to a personal docker repo and use that in odo to confirm that tests pass. I hope u do that @amitkrout
/approve

Travis script is handling this through https://github.com/openshift/odo-init-image/blob/master/scripts/build-push-image.sh

Ahh.. its commented https://github.com/openshift/odo-init-image/blob/master/.travis.yml#L19
/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 29, 2020
@amitkrout amitkrout force-pushed the RemoveDeprecateNodejsImages branch from 9b782fd to 3ee0f5d Compare July 29, 2020 10:37
@amitkrout amitkrout force-pushed the RemoveDeprecateNodejsImages branch from 3ee0f5d to 33c77ba Compare July 31, 2020 06:14
@amitkrout amitkrout mentioned this pull request Oct 2, 2020
Merged
@amitkrout
Copy link
Contributor Author

#72 (comment)
/close

@openshift-ci-robot
Copy link

@amitkrout: Closed this PR.

In response to this:

#72 (comment)
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@girishramnani girishramnani Awaiting requested review from girishramnani

@prietyc123 prietyc123 Awaiting requested review from prietyc123

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@amitkrout @kadel @girishramnani @openshift-ci-robot