Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor application command to follow complete-validate-run pattern #1188

Closed
kadel opened this issue Jan 13, 2019 · 0 comments · Fixed by #1265
Closed

Refactor application command to follow complete-validate-run pattern #1188

kadel opened this issue Jan 13, 2019 · 0 comments · Fixed by #1265
Assignees
@metacosm @syamgk
Labels
estimated-size/M (10-20) Rough sizing for Epics. About 1 sprint of work for one person priority/Medium Nice to have issue. Getting it done before priority changes would be great.
Projects
Sprint 161

Comments

@kadel
Copy link
Member

kadel commented Jan 13, 2019

more info in #1142
@kadel kadel mentioned this issue Jan 13, 2019
Closed
10 tasks
@kadel kadel added this to To do in Sprint 161 Jan 13, 2019
@cdrage cdrage added the priority/Medium Nice to have issue. Getting it done before priority changes would be great. label Jan 14, 2019
@metacosm metacosm self-assigned this Jan 31, 2019
@metacosm metacosm mentioned this issue Jan 31, 2019
Merged
@metacosm metacosm moved this from To do to Needs review in Sprint 161 Feb 1, 2019
Sprint 161 automation moved this from Needs review to Done Feb 5, 2019
metacosm added a commit that referenced this issue Feb 5, 2019
@metacosm
Fix #1188: refactor application to follow Complete/Validate/Run patte…
cf85b1b 
…rn. (#1265)

* Split application into separate files for each command.

* Refactor application commands to use Complete/Validate/Run pattern.

* Rename validateApp to ensureAppExists.

* Update to work with machine-readable format.

* Do not use json as default value.

* Attempt to debug test issue.
@rm3l rm3l added the estimated-size/M (10-20) Rough sizing for Epics. About 1 sprint of work for one person label Jun 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@metacosm metacosm

@syamgk syamgk

Labels
estimated-size/M (10-20) Rough sizing for Epics. About 1 sprint of work for one person priority/Medium Nice to have issue. Getting it done before priority changes would be great.
Projects
odo Project
Archived in project
Sprint 161
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #1188: refactor application to follow Complete/Validate/Run pattern. metacosm/odo
6 participants
@kadel @metacosm @rm3l @syamgk @cdrage @girishramnani