Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add debug commands to odo devfile registry #3377

Closed
8 of 10 tasks
kadel opened this issue Jun 18, 2020 · 10 comments · Fixed by #4179
Closed
8 of 10 tasks

add debug commands to odo devfile registry #3377

kadel opened this issue Jun 18, 2020 · 10 comments · Fixed by #4179
Assignees
@rnapoles-rh
Labels
kind/user-story An issue of user-story kind priority/Medium Nice to have issue. Getting it done before priority changes would be great.
Projects
Sprint 192

Comments

@kadel
Copy link
Member

kadel commented Jun 18, 2020 •
edited by rnapoles-rh

/kind user-story

User Story

As an odo user, I want to be able to use the debugger to debug the application running in the cluster.

Acceptance Criteria

  • Every devfile that is in odo devfile registry should have "debug" group defined
  • These are devfiles that need debug command -
    • java-maven
    • java-openliberty
    • java-sprintboot
    • java-quarkus
  • Tests for e2e scenerios
    • java-maven
    • java-openliberty
    • java-sprintboot
    • java-quarkus

/kind user-story
/priority medium
/area debug
@openshift-ci-robot openshift-ci-robot added kind/user-story An issue of user-story kind priority/Medium Nice to have issue. Getting it done before priority changes would be great. labels Jun 18, 2020
@girishramnani girishramnani added this to For consideration in Sprint 187 via automation Jul 13, 2020
@devang-gaur devang-gaur moved this from For consideration to To do in Sprint 187 Jul 16, 2020
@girishramnani girishramnani removed this from To do in Sprint 187 Aug 4, 2020
@girishramnani girishramnani added this to For consideration in Sprint 188 via automation Aug 4, 2020
@girishramnani girishramnani moved this from For consideration to To do in Sprint 188 Aug 4, 2020
@devang-gaur devang-gaur moved this from To do to In progress in Sprint 188 Aug 4, 2020
@devang-gaur
Copy link
Contributor

Tentative Debug commands for all the 4 Java variants

  1. for quarkus, mvn quarkus:dev

  2. for openLiberty, mvn liberty:dev

  3. for generic java-maven type and 4. spring-boot type

Something like this command should work.

java -Xdebug -Xrunjdwp:server=y,transport=dt_socket,address=8000,suspend=n \
       -jar target/myapplication-0.0.1-SNAPSHOT.jar

This was referenced Aug 11, 2020
Merged
Merged
@devang-gaur
Copy link
Contributor

Blocked on #3740

This was referenced Aug 24, 2020
Closed
Closed
@devang-gaur devang-gaur added this to In progress in Sprint 189 Aug 24, 2020
@girishramnani girishramnani removed this from In progress in Sprint 188 Aug 24, 2020
@devang-gaur devang-gaur mentioned this issue Aug 25, 2020
Merged
@girishramnani girishramnani moved this from In progress to For review in Sprint 189 Aug 27, 2020
@devang-gaur devang-gaur mentioned this issue Sep 8, 2020
Merged
@girishramnani girishramnani removed this from For review in Sprint 189 Sep 14, 2020
@girishramnani girishramnani added this to For consideration in Sprint 190 via automation Sep 14, 2020
@girishramnani girishramnani moved this from For consideration to For review in Sprint 190 Sep 14, 2020
@kadel
Copy link
Member Author

kadel commented Sep 16, 2020

Blocked on #3740

this was resolved, it is not blocked anymore

@devang-gaur
Copy link
Contributor

All the devfiles have been amended with debug command. E2E scenarios remain.

@prietyc123
Copy link
Contributor

Removing required-for-v2 label as v2.0.0 has been released.

@devang-gaur
Copy link
Contributor

@prietyc123 can you co-assign this to Rodolfo as well?

@prietyc123
Copy link
Contributor

@rnapoles-rh assigned for part of this issue Tests for e2e scenerios

@prietyc123 prietyc123 added this to For consideration in Sprint 191 via automation Oct 6, 2020
@prietyc123 prietyc123 removed this from For review in Sprint 190 Oct 6, 2020
@prietyc123 prietyc123 moved this from For consideration to To do in Sprint 191 Oct 6, 2020
@rnapoles-rh rnapoles-rh moved this from To do to In progress in Sprint 191 Oct 22, 2020
@rnapoles-rh rnapoles-rh mentioned this issue Oct 22, 2020
Closed
@rnapoles-rh
Copy link
Contributor

E2E scenarios tested manually. All functionality works as expected.
Automation in progress
Dependency for java-maven automated scenario blocked by devfile/api#115

@prietyc123 prietyc123 added this to For consideration in Sprint 192 via automation Oct 26, 2020
@prietyc123 prietyc123 removed this from In progress in Sprint 191 Oct 26, 2020
@prietyc123 prietyc123 moved this from For consideration to In progress in Sprint 192 Oct 26, 2020
@rnapoles-rh rnapoles-rh mentioned this issue Oct 27, 2020
Closed
4 tasks
@rnapoles-rh rnapoles-rh added this to For consideration in Sprint 191 via automation Oct 27, 2020
@rnapoles-rh rnapoles-rh removed this from In progress in Sprint 192 Oct 27, 2020
@rnapoles-rh rnapoles-rh moved this from For consideration to For review in Sprint 191 Oct 27, 2020
@rnapoles-rh rnapoles-rh linked a pull request Oct 27, 2020 that will close this issue
Adding e2e scenarios for devfile #4157
Closed
4 tasks
@rnapoles-rh
Copy link
Contributor

e2e test for java maven pending due to dependency with devfile/api#115

This was referenced Oct 27, 2020
Closed
Merged
@rnapoles-rh rnapoles-rh removed this from For review in Sprint 191 Nov 12, 2020
@rnapoles-rh rnapoles-rh added this to For consideration in Sprint 192 via automation Nov 12, 2020
@rnapoles-rh rnapoles-rh moved this from For consideration to For review in Sprint 192 Nov 12, 2020
@prietyc123
Copy link
Contributor

Adding e2e tests for java-maven will be handled as part of #4162 . @rnapoles-rh please update this issue according if I missed something.

Sprint 192 automation moved this from For review to Done Nov 20, 2020
openshift-merge-robot pushed a commit that referenced this issue Nov 20, 2020
@rnapoles-rh
#3377 adding odo devfile support test (#4179)
9200a7f 
* #3377 adding odo devfile support test

* #3377 replaced spaces with a Tab

* #3377 updated focus value

* #3377 addressed all Priti's comments in PR

* #3377 addressed additional comments from Priti's comments in PR

* #3377 adding make test-e2e-devfile
openshift-merge-robot pushed a commit that referenced this issue Dec 21, 2020
@rnapoles-rh
3823 refactor json (#4296)
14c98ec 
* 3377 adding odo devfile support test

* #3377 replaced spaces with a Tab

* #3377 updated focus value

* #3823 new func to match JSON path values and updated test scripts to use it

* added . to import

* updated Makefile to aff gjson

* modified Makefile for gjson

* adding go.mo, go.sum and vendor for new gjson dependency

* removed unnecessary changes

* Removed unused import

* Removing if block

* Fixed expected strings for JSON matcher

* Fixed json paths and values to be compared

* Fixed JSON paths and expected values

* fixed required flags for expected failure

* Removed comment in failing code

* Fixed expected output line 164

* removed commented code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rnapoles-rh rnapoles-rh

Labels
kind/user-story An issue of user-story kind priority/Medium Nice to have issue. Getting it done before priority changes would be great.
Projects
No open projects
Sprint 192
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#3377 adding odo devfile support test
Adding e2e scenarios for devfile
6 participants
@kadel @girishramnani @devang-gaur @openshift-ci-robot @prietyc123 @rnapoles-rh