Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to use the parser from devfile/parser in odo repo #4117

Closed
yangcao77 opened this issue Oct 15, 2020 · 1 comment · Fixed by #4188
Closed

Switch to use the parser from devfile/parser in odo repo #4117

yangcao77 opened this issue Oct 15, 2020 · 1 comment · Fixed by #4188
Assignees
Labels
area/devfile-spec Issues or PRs related to the Devfile specification and how odo handles and interprets it. area/refactoring Issues or PRs related to code refactoring
Projects
Milestone

Comments

@yangcao77
Copy link
Contributor

yangcao77 commented Oct 15, 2020

After devfile/api#183 is completed, we want to switch to use the parser from devfile/parser repo, and remove the parser defined in Odo.

Since the parser library is using devfile go struct defined in devfile/api, this requires some code changes to Odo code base to integrate with the new devfile go struct. product code and test code changes are expected.

**Note: the validate package will temporarily be left in odo, the validator will be implemented in devfile/api repo.
For any call to the following parser functions in odo, need to call validate.ValidateDevfileData after, separately:
ParseAndValidate, ParseFromURLAndValidate, ParseFromDataAndValidate,

@elsony elsony added area/devfile-spec Issues or PRs related to the Devfile specification and how odo handles and interprets it. kind/code-refactoring labels Oct 15, 2020
@girishramnani girishramnani added this to the Post v2.0 milestone Oct 20, 2020
@yangcao77
Copy link
Contributor Author

/assign

@maysunfaisal maysunfaisal added this to For consideration in Sprint 190 via automation Oct 28, 2020
@maysunfaisal maysunfaisal moved this from For consideration to In progress in Sprint 190 Oct 28, 2020
Sprint 190 automation moved this from In progress to Done Nov 21, 2020
@rm3l rm3l added the area/refactoring Issues or PRs related to code refactoring label Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devfile-spec Issues or PRs related to the Devfile specification and how odo handles and interprets it. area/refactoring Issues or PRs related to code refactoring
Projects
Archived in project
Sprint 190
  
Done
Development

Successfully merging a pull request may close this issue.

4 participants