-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copy files to running container without requiring oc binary #443
Labels
estimated-size/L (20-40)
Rough sizing for Epics. About 2 sprints of work for a person.
priority/Medium
Nice to have issue. Getting it done before priority changes would be great.
Projects
Comments
kadel
added
kind/task
priority/Medium
Nice to have issue. Getting it done before priority changes would be great.
labels
May 10, 2018
surajnarwade
added a commit
to surajnarwade/ocdev
that referenced
this issue
Jun 4, 2018
Resolves redhat-developer#443 This PR will remove dependency of oc binary for `copyfiles` function which copies file to component while `odo push`
surajnarwade
added a commit
to surajnarwade/ocdev
that referenced
this issue
Jun 6, 2018
Resolves redhat-developer#443 This PR will remove dependency of oc binary for `copyfiles` function which copies file to component while `odo push`
surajnarwade
added a commit
to surajnarwade/ocdev
that referenced
this issue
Jun 7, 2018
Resolves redhat-developer#443 This PR will remove dependency of oc binary for `copyfiles` function which copies file to component while `odo push`
surajnarwade
added a commit
to surajnarwade/ocdev
that referenced
this issue
Jun 7, 2018
Resolves redhat-developer#443 This PR will remove dependency of oc binary for `copyfiles` function which copies file to component while `odo push`
surajnarwade
added a commit
to surajnarwade/ocdev
that referenced
this issue
Jun 7, 2018
Resolves redhat-developer#443 This PR will remove dependency of oc binary for `copyfiles` function which copies file to component while `odo push`
surajnarwade
added a commit
to surajnarwade/ocdev
that referenced
this issue
Jun 8, 2018
Resolves redhat-developer#443 This PR will remove dependency of oc binary for `copyfiles` function which copies file to component while `odo push`
surajnarwade
added a commit
to surajnarwade/ocdev
that referenced
this issue
Jun 8, 2018
Resolves redhat-developer#443 This PR will remove dependency of oc binary for `copyfiles` function which copies file to component while `odo push`
surajnarwade
added a commit
to surajnarwade/ocdev
that referenced
this issue
Jun 11, 2018
Resolves redhat-developer#443 This PR will remove dependency of oc binary for `copyfiles` function which copies file to component while `odo push`
surajnarwade
added a commit
to surajnarwade/ocdev
that referenced
this issue
Jun 13, 2018
Resolves redhat-developer#443 This PR will remove dependency of oc binary for `copyfiles` function which copies file to component while `odo push`
surajnarwade
added a commit
to surajnarwade/ocdev
that referenced
this issue
Jun 13, 2018
Resolves redhat-developer#443 This PR will remove dependency of oc binary for `copyfiles` function which copies file to component while `odo push`
surajnarwade
added a commit
to surajnarwade/ocdev
that referenced
this issue
Jun 14, 2018
Resolves redhat-developer#443 This PR will remove dependency of oc binary for `copyfiles` function which copies file to component while `odo push`
surajnarwade
added a commit
to surajnarwade/ocdev
that referenced
this issue
Jun 19, 2018
Resolves redhat-developer#443 This PR will remove dependency of oc binary for `copyfiles` function which copies file to component while `odo push`
surajnarwade
added a commit
to surajnarwade/ocdev
that referenced
this issue
Jun 20, 2018
Resolves redhat-developer#443 This PR will remove dependency of oc binary for `copyfiles` function which copies file to component while `odo push`
surajnarwade
added a commit
to surajnarwade/ocdev
that referenced
this issue
Jun 20, 2018
Resolves redhat-developer#443 This PR will remove dependency of oc binary for `copyfiles` function which copies file to component while `odo push`
surajnarwade
added a commit
to surajnarwade/ocdev
that referenced
this issue
Jun 22, 2018
Resolves redhat-developer#443 This PR will remove dependency of oc binary for `copyfiles` function which copies file to component while `odo push`
surajnarwade
added a commit
to surajnarwade/ocdev
that referenced
this issue
Jun 22, 2018
Resolves redhat-developer#443 This PR will remove dependency of oc binary for `copyfiles` function which copies file to component while `odo push`
surajnarwade
added a commit
to surajnarwade/ocdev
that referenced
this issue
Jun 29, 2018
Resolves redhat-developer#443 This PR will remove dependency of oc binary for `copyfiles` function which copies file to component while `odo push`
surajnarwade
added a commit
to surajnarwade/ocdev
that referenced
this issue
Jun 29, 2018
Resolves redhat-developer#443 This PR will remove dependency of oc binary for `copyfiles` function which copies file to component while `odo push`
surajnarwade
added a commit
to surajnarwade/ocdev
that referenced
this issue
Jul 4, 2018
Resolves redhat-developer#443 This PR will remove dependency of oc binary for `copyfiles` function which copies file to component while `odo push`
surajnarwade
added a commit
to surajnarwade/ocdev
that referenced
this issue
Jul 11, 2018
Resolves redhat-developer#443 This PR will remove dependency of oc binary for `copyfiles` function which copies file to component while `odo push`
surajnarwade
added a commit
to surajnarwade/ocdev
that referenced
this issue
Jul 17, 2018
Resolves redhat-developer#443 This PR will remove dependency of oc binary for `copyfiles` function which copies file to component while `odo push`
surajnarwade
added a commit
to surajnarwade/ocdev
that referenced
this issue
Jul 17, 2018
Resolves redhat-developer#443 This PR will remove dependency of oc binary for `copyfiles` function which copies file to component while `odo push`
surajnarwade
added a commit
to surajnarwade/ocdev
that referenced
this issue
Jul 17, 2018
Resolves redhat-developer#443 This PR will remove dependency of oc binary for `copyfiles` function which copies file to component while `odo push`
surajnarwade
added a commit
to surajnarwade/ocdev
that referenced
this issue
Jul 17, 2018
Resolves redhat-developer#443 This PR will remove dependency of oc binary for `copyfiles` function which copies file to component while `odo push`
surajnarwade
added a commit
to surajnarwade/ocdev
that referenced
this issue
Jul 23, 2018
Resolves redhat-developer#443 This PR will remove dependency of oc binary for `copyfiles` function which copies file to component while `odo push`
rm3l
added
the
estimated-size/L (20-40)
Rough sizing for Epics. About 2 sprints of work for a person.
label
Jun 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
estimated-size/L (20-40)
Rough sizing for Epics. About 2 sprints of work for a person.
priority/Medium
Nice to have issue. Getting it done before priority changes would be great.
Functions that are copying files to the container (
occlient.RsyncPath
andocclient.CopyFile
) are still callingoc
binary.We should figure out a way how to do it do it without
oc
binary just with pureclient-go
.Let's start with
CopyFile
copying one file might be fairly easy, as we can check how it is implemented in kubectl cpWhen we have that we might not even need
RsyncPath
. We are already detecting file changes in watch command, so we can just copy modified files one-by-one usingCopyFiles
(don't forget about deleted files). This will also remove dependency onrsync
that is a complication, especially for windows users.parent: #257
The text was updated successfully, but these errors were encountered: