Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy files to running container without requiring oc binary #443

Closed
kadel opened this issue May 10, 2018 · 0 comments
Closed

Copy files to running container without requiring oc binary #443

kadel opened this issue May 10, 2018 · 0 comments
Assignees
Labels
estimated-size/L (20-40) Rough sizing for Epics. About 2 sprints of work for a person. priority/Medium Nice to have issue. Getting it done before priority changes would be great.

Comments

@kadel
Copy link
Member

kadel commented May 10, 2018

Functions that are copying files to the container (occlient.RsyncPath and occlient.CopyFile) are still calling oc binary.
We should figure out a way how to do it do it without oc binary just with pure client-go.

Let's start with CopyFile copying one file might be fairly easy, as we can check how it is implemented in kubectl cp

When we have that we might not even need RsyncPath. We are already detecting file changes in watch command, so we can just copy modified files one-by-one using CopyFiles (don't forget about deleted files). This will also remove dependency on rsync that is a complication, especially for windows users.

parent: #257

@kadel kadel added kind/task priority/Medium Nice to have issue. Getting it done before priority changes would be great. labels May 10, 2018
@kadel kadel added the size/L label May 10, 2018
@kadel kadel added this to To do in Sprint 150 (2018-05-30) via automation May 29, 2018
surajnarwade added a commit to surajnarwade/ocdev that referenced this issue Jun 4, 2018
Resolves redhat-developer#443

This PR will remove dependency of oc binary for `copyfiles` function which copies file to component while `odo push`
surajnarwade added a commit to surajnarwade/ocdev that referenced this issue Jun 6, 2018
Resolves redhat-developer#443

This PR will remove dependency of oc binary for `copyfiles` function which copies file to component while `odo push`
surajnarwade added a commit to surajnarwade/ocdev that referenced this issue Jun 7, 2018
Resolves redhat-developer#443

This PR will remove dependency of oc binary for `copyfiles` function which copies file to component while `odo push`
surajnarwade added a commit to surajnarwade/ocdev that referenced this issue Jun 7, 2018
Resolves redhat-developer#443

This PR will remove dependency of oc binary for `copyfiles` function which copies file to component while `odo push`
surajnarwade added a commit to surajnarwade/ocdev that referenced this issue Jun 7, 2018
Resolves redhat-developer#443

This PR will remove dependency of oc binary for `copyfiles` function which copies file to component while `odo push`
surajnarwade added a commit to surajnarwade/ocdev that referenced this issue Jun 8, 2018
Resolves redhat-developer#443

This PR will remove dependency of oc binary for `copyfiles` function which copies file to component while `odo push`
surajnarwade added a commit to surajnarwade/ocdev that referenced this issue Jun 8, 2018
Resolves redhat-developer#443

This PR will remove dependency of oc binary for `copyfiles` function which copies file to component while `odo push`
@surajnarwade surajnarwade moved this from To do to In progress in Sprint 150 (2018-05-30) Jun 8, 2018
surajnarwade added a commit to surajnarwade/ocdev that referenced this issue Jun 11, 2018
Resolves redhat-developer#443

This PR will remove dependency of oc binary for `copyfiles` function which copies file to component while `odo push`
@kadel kadel added the backlog label Jun 12, 2018
surajnarwade added a commit to surajnarwade/ocdev that referenced this issue Jun 13, 2018
Resolves redhat-developer#443

This PR will remove dependency of oc binary for `copyfiles` function which copies file to component while `odo push`
surajnarwade added a commit to surajnarwade/ocdev that referenced this issue Jun 13, 2018
Resolves redhat-developer#443

This PR will remove dependency of oc binary for `copyfiles` function which copies file to component while `odo push`
surajnarwade added a commit to surajnarwade/ocdev that referenced this issue Jun 14, 2018
Resolves redhat-developer#443

This PR will remove dependency of oc binary for `copyfiles` function which copies file to component while `odo push`
surajnarwade added a commit to surajnarwade/ocdev that referenced this issue Jun 19, 2018
Resolves redhat-developer#443

This PR will remove dependency of oc binary for `copyfiles` function which copies file to component while `odo push`
surajnarwade added a commit to surajnarwade/ocdev that referenced this issue Jun 20, 2018
Resolves redhat-developer#443

This PR will remove dependency of oc binary for `copyfiles` function which copies file to component while `odo push`
surajnarwade added a commit to surajnarwade/ocdev that referenced this issue Jun 20, 2018
Resolves redhat-developer#443

This PR will remove dependency of oc binary for `copyfiles` function which copies file to component while `odo push`
@kadel kadel removed this from In progress in Sprint 150 (2018-05-30) Jun 20, 2018
@kadel kadel added this to To do in Sprint 151 (2018-06-20) via automation Jun 20, 2018
@kadel kadel moved this from To do to In progress in Sprint 151 (2018-06-20) Jun 20, 2018
surajnarwade added a commit to surajnarwade/ocdev that referenced this issue Jun 22, 2018
Resolves redhat-developer#443

This PR will remove dependency of oc binary for `copyfiles` function which copies file to component while `odo push`
surajnarwade added a commit to surajnarwade/ocdev that referenced this issue Jun 22, 2018
Resolves redhat-developer#443

This PR will remove dependency of oc binary for `copyfiles` function which copies file to component while `odo push`
surajnarwade added a commit to surajnarwade/ocdev that referenced this issue Jun 29, 2018
Resolves redhat-developer#443

This PR will remove dependency of oc binary for `copyfiles` function which copies file to component while `odo push`
surajnarwade added a commit to surajnarwade/ocdev that referenced this issue Jun 29, 2018
Resolves redhat-developer#443

This PR will remove dependency of oc binary for `copyfiles` function which copies file to component while `odo push`
surajnarwade added a commit to surajnarwade/ocdev that referenced this issue Jul 4, 2018
Resolves redhat-developer#443

This PR will remove dependency of oc binary for `copyfiles` function which copies file to component while `odo push`
surajnarwade added a commit to surajnarwade/ocdev that referenced this issue Jul 11, 2018
Resolves redhat-developer#443

This PR will remove dependency of oc binary for `copyfiles` function which copies file to component while `odo push`
@kadel kadel removed this from In progress in Sprint 151 (2018-06-20) Jul 11, 2018
@kadel kadel added this to To do in Sprint 152 (2018-07-10) via automation Jul 11, 2018
@kadel kadel moved this from To do to In progress in Sprint 152 (2018-07-10) Jul 11, 2018
surajnarwade added a commit to surajnarwade/ocdev that referenced this issue Jul 17, 2018
Resolves redhat-developer#443

This PR will remove dependency of oc binary for `copyfiles` function which copies file to component while `odo push`
surajnarwade added a commit to surajnarwade/ocdev that referenced this issue Jul 17, 2018
Resolves redhat-developer#443

This PR will remove dependency of oc binary for `copyfiles` function which copies file to component while `odo push`
surajnarwade added a commit to surajnarwade/ocdev that referenced this issue Jul 17, 2018
Resolves redhat-developer#443

This PR will remove dependency of oc binary for `copyfiles` function which copies file to component while `odo push`
surajnarwade added a commit to surajnarwade/ocdev that referenced this issue Jul 17, 2018
Resolves redhat-developer#443

This PR will remove dependency of oc binary for `copyfiles` function which copies file to component while `odo push`
surajnarwade added a commit to surajnarwade/ocdev that referenced this issue Jul 23, 2018
Resolves redhat-developer#443

This PR will remove dependency of oc binary for `copyfiles` function which copies file to component while `odo push`
Sprint 152 (2018-07-10) automation moved this from In progress to Done Jul 24, 2018
@rm3l rm3l added the estimated-size/L (20-40) Rough sizing for Epics. About 2 sprints of work for a person. label Jun 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
estimated-size/L (20-40) Rough sizing for Epics. About 2 sprints of work for a person. priority/Medium Nice to have issue. Getting it done before priority changes would be great.
Projects
Archived in project
Development

No branches or pull requests

3 participants