Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

odo list #5405

Closed
8 of 9 tasks
Tracked by #5312
kadel opened this issue Jan 31, 2022 · 5 comments · Fixed by #5552
Closed
8 of 9 tasks
Tracked by #5312

odo list #5405

kadel opened this issue Jan 31, 2022 · 5 comments · Fixed by #5552
Assignees
Labels
kind/user-story An issue of user-story kind
Milestone

Comments

@kadel
Copy link
Member

kadel commented Jan 31, 2022

odo list

/kind user-story

User Story

  • As an odo user
  • I want to be able to list all components (created by odo and other tools as well) that are running on the cluster
  • So that
    • I know what I have running on the cluster

Acceptance Criteria

  • odo list should list every component running in the currently active namespace (as set in KUBECONFIG
  • users should be able to list components from a different namespace using --namespace flag
  • The list of the component should be formatted as a table
  • List of the component should mark which component from the list is the component in the current directory (if the command is executed in the directory with devfile.yaml)
  • The output should have MANGAED BY column that indicates what tool is "responsible" for the component. app.kubernetes.io/managed-by label should be used to determine the tool.
  • The output should have NAME column that shows the name of the component \
  • The output should have RUNNING IN column that indicates in what modes the component is running. Dev means the component is running in development mode (odo dev). Deploy indicates that the component is running in deploy mode (odo deploy), None means that the component is currently not running on cluster. Unknown indicates that odo can't detect in what mode is component running. Unknown will also be used for components that are running on the cluster but are not managed by odo.
  • The output should have TYPE column that corresponds to the language field in devfile.yaml tools, this should also correspond to odo.dev/project-type label.
  • The listing logic, should not make any assumption about the Kubernetes Kinds for the components. The implementation should be generic enough that it doesn't really on any particular Kind. odo v2 listing has problems that it assumes that there will always be Deployment which is not correct. This is especially true for odo deploy

example

$ odo list
Components in the "mynamspace" namespace:

  NAME              TYPE         MANAGED BY       RUNNING IN
* frontend          nodejs       odo              Dev,Deploy
  backend           springboot   odo              Deploy
  created-by-odc    python       Unknown          Unknown
@kadel kadel added the v3 label Jan 31, 2022
@kadel kadel added this to the 3.0 (planning) milestone Jan 31, 2022
@kadel kadel changed the title odo list odo list Feb 2, 2022
@cdrage cdrage self-assigned this Feb 7, 2022
@cdrage
Copy link
Member

cdrage commented Feb 7, 2022

@kadel When you describe:

PATH column is displayed only if the command was executed with --path flag. It shows the path in which the component "lives". This is relative path to a given --path.

Are you talking about this scenario?

$ odo list --path
Components in the "mynamspace" namespace:

  NAME              TYPE         MANAGED BY       RUNNING IN       PATH 
* frontend          nodejs       odo              Dev,Deploy      ~/frontend
  backend           springboot   odo              Deploy          ~/backend
  created-by-odc    python       Unknown          Unknown

Like.. is --path a boolean asking to show where everything is? Or --path more of odo list --path ~/dev/mydevfileproject/ ? So it'll list all devfile components on the cluster as well as whatever is in that folder?

@dharmit
Copy link
Member

dharmit commented Feb 8, 2022

@kadel

NAMESPACE indicates in what namespace the component is. This is mainly intended for when user

But there's no column for namespace in the example odo list you originally created. Since odo list lists stuff based on namespace, should we have a column for it?

@cdrage

Like.. is --path a boolean asking to show where everything is? Or --path more of odo list --path ~/dev/mydevfileproject/ ? So it'll list all devfile components on the cluster as well as whatever is in that folder?

I'm pretty sure it's the latter - odo list --path ~/dev/mydevfileproject/.

@cdrage
Copy link
Member

cdrage commented Feb 11, 2022

@kadel What do you suggest for keeping track if a deployment is in "Dev" or "Deploy" mode, perhaps a label when you deploy?

@kadel
Copy link
Member Author

kadel commented Feb 11, 2022

Originally this command had a lot more flags like --path, but as @dharmit requested I removed most of them, but I forgot to remove it from the flag description :-/, now the description should be in a better shape

@kadel kadel added the kind/epic An issue categorized as a high-level Epic. Needs to be scoped and broken down in 1+ stories/tasks label Feb 16, 2022
cdrage added a commit to cdrage/odo that referenced this issue Feb 17, 2022
<!--
Thank you for opening a PR! Here are some things you need to know before submitting:

1. Please read our developer guideline: https://github.com/redhat-developer/odo/wiki/Developer-Guidelines
2. Label this PR accordingly with the '/kind' line
3. Ensure you have written and ran the appropriate tests: https://github.com/redhat-developer/odo/wiki/Writing-and-running-tests
4. Read how we approve and LGTM each PR: https://github.com/redhat-developer/odo/wiki/PR-Review

Documentation:

If you are pushing a change to documentation, please read: https://github.com/redhat-developer/odo/wiki/Contributing-to-Docs
-->

**What type of PR is this:**

<!--
Add one of the following kinds:
/kind bug
/kind cleanup
/kind tests
/kind documentation

Feel free to use other [labels](https://github.com/redhat-developer/odo/labels) as needed. However one of the above labels must be present or the PR will not be reviewed. This instruction is for reviewers as well.
-->

/kind feature

**What does this PR do / why we need it:**

This redesigns the `odo list` functionality like so:

```sh
~/nodejs
▶ odo list
NAME                    TYPE       MODE          MANAGED   URLS                        PORTS               STATUS      AGE
* nodejs-prj1-api-abhz  nodejs     devfile.yaml  odo                                                       Not Pushed
foo                     nodejs     Dev           odo       http://foobar.k8s.land      3000                Running     2m15s
digitalocean-dyndns     <unknown>  <unknown>     Helm                                                      Running     17d
duplicati               <unknown>  <unknown>     Helm      https://duplicati.k8s.land  8200                Running     37d
hass                    <unknown>  <unknown>     Helm      https://hass.k8s.land       8123                Running     17d
hostpath-provisioner    <unknown>  <unknown>     Helm                                                      Running     37d
syncthing               <unknown>  <unknown>     Helm      https://syncthing.k8s.land  21027, 22000, 8384  Running     39d
```

Changes:
- Refactors components in component/component.go files
- Implement changes so we rely less on the local environment files and
  more from retrieving from the cluster

**Which issue(s) this PR fixes:**
<!--
Specifying the issue will automatically close it when this PR is merged
-->

Fixes redhat-developer#5405

**PR acceptance criteria:**

- [ ] Unit test

- [ ] Integration test

- [ ] Documentation

**How to test changes / Special notes to the reviewer:**

```sh
git clone https://github.com/odo-devfiles/nodejs-ex
cd nodejs-ex
odo create nodejs test
odo push
odo list
```
@kadel kadel mentioned this issue Feb 21, 2022
13 tasks
@kadel kadel added kind/user-story An issue of user-story kind and removed kind/epic An issue categorized as a high-level Epic. Needs to be scoped and broken down in 1+ stories/tasks labels Feb 21, 2022
@cdrage
Copy link
Member

cdrage commented Feb 22, 2022

It has been implemented like so:

▶ odo list
NAME                  TYPE       MODE       MANAGED   URLS                        PORTS               STATUS   AGE  
digitalocean-dyndns   <unknown>  <unknown>  Helm                                                      Running  22d
duplicati             <unknown>  <unknown>  Helm      https://duplicati.k8s.land  8200                Running  42d
hass                  <unknown>  <unknown>  Helm      https://hass.k8s.land       8123                Running  22d
hostpath-provisioner  <unknown>  <unknown>  Helm                                                      Running  42d
syncthing             <unknown>  <unknown>  Helm      https://syncthing.k8s.land  21027, 22000, 8384  Running  44d

Currently I am working my way through tests to make sure that it works correctly 👍

cdrage added a commit to cdrage/odo that referenced this issue Feb 22, 2022
<!--
Thank you for opening a PR! Here are some things you need to know before submitting:

1. Please read our developer guideline: https://github.com/redhat-developer/odo/wiki/Developer-Guidelines
2. Label this PR accordingly with the '/kind' line
3. Ensure you have written and ran the appropriate tests: https://github.com/redhat-developer/odo/wiki/Writing-and-running-tests
4. Read how we approve and LGTM each PR: https://github.com/redhat-developer/odo/wiki/PR-Review

Documentation:

If you are pushing a change to documentation, please read: https://github.com/redhat-developer/odo/wiki/Contributing-to-Docs
-->

**What type of PR is this:**

<!--
Add one of the following kinds:
/kind bug
/kind cleanup
/kind tests
/kind documentation

Feel free to use other [labels](https://github.com/redhat-developer/odo/labels) as needed. However one of the above labels must be present or the PR will not be reviewed. This instruction is for reviewers as well.
-->

/kind feature

**What does this PR do / why we need it:**

This redesigns the `odo list` functionality like so:

```sh
~/nodejs
▶ odo list
NAME                    TYPE       MODE          MANAGED   URLS                        PORTS               STATUS      AGE
* nodejs-prj1-api-abhz  nodejs     devfile.yaml  odo                                                       Not Pushed
foo                     nodejs     Dev           odo       http://foobar.k8s.land      3000                Running     2m15s
digitalocean-dyndns     <unknown>  <unknown>     Helm                                                      Running     17d
duplicati               <unknown>  <unknown>     Helm      https://duplicati.k8s.land  8200                Running     37d
hass                    <unknown>  <unknown>     Helm      https://hass.k8s.land       8123                Running     17d
hostpath-provisioner    <unknown>  <unknown>     Helm                                                      Running     37d
syncthing               <unknown>  <unknown>     Helm      https://syncthing.k8s.land  21027, 22000, 8384  Running     39d
```

Changes:
- Refactors components in component/component.go files
- Implement changes so we rely less on the local environment files and
  more from retrieving from the cluster

**Which issue(s) this PR fixes:**
<!--
Specifying the issue will automatically close it when this PR is merged
-->

Fixes redhat-developer#5405

**PR acceptance criteria:**

- [ ] Unit test

- [ ] Integration test

- [ ] Documentation

**How to test changes / Special notes to the reviewer:**

```sh
git clone https://github.com/odo-devfiles/nodejs-ex
cd nodejs-ex
odo create nodejs test
odo push
odo list
```
cdrage added a commit to cdrage/odo that referenced this issue Feb 23, 2022
<!--
Thank you for opening a PR! Here are some things you need to know before submitting:

1. Please read our developer guideline: https://github.com/redhat-developer/odo/wiki/Developer-Guidelines
2. Label this PR accordingly with the '/kind' line
3. Ensure you have written and ran the appropriate tests: https://github.com/redhat-developer/odo/wiki/Writing-and-running-tests
4. Read how we approve and LGTM each PR: https://github.com/redhat-developer/odo/wiki/PR-Review

Documentation:

If you are pushing a change to documentation, please read: https://github.com/redhat-developer/odo/wiki/Contributing-to-Docs
-->

**What type of PR is this:**

<!--
Add one of the following kinds:
/kind bug
/kind cleanup
/kind tests
/kind documentation

Feel free to use other [labels](https://github.com/redhat-developer/odo/labels) as needed. However one of the above labels must be present or the PR will not be reviewed. This instruction is for reviewers as well.
-->

/kind feature

**What does this PR do / why we need it:**

This redesigns the `odo list` functionality like so:

```sh
~/nodejs
▶ odo list
NAME                    TYPE       MODE          MANAGED   URLS                        PORTS               STATUS      AGE
* nodejs-prj1-api-abhz  nodejs     devfile.yaml  odo                                                       Not Pushed
foo                     nodejs     Dev           odo       http://foobar.k8s.land      3000                Running     2m15s
digitalocean-dyndns     <unknown>  <unknown>     Helm                                                      Running     17d
duplicati               <unknown>  <unknown>     Helm      https://duplicati.k8s.land  8200                Running     37d
hass                    <unknown>  <unknown>     Helm      https://hass.k8s.land       8123                Running     17d
hostpath-provisioner    <unknown>  <unknown>     Helm                                                      Running     37d
syncthing               <unknown>  <unknown>     Helm      https://syncthing.k8s.land  21027, 22000, 8384  Running     39d
```

Changes:
- Refactors components in component/component.go files
- Implement changes so we rely less on the local environment files and
  more from retrieving from the cluster

**Which issue(s) this PR fixes:**
<!--
Specifying the issue will automatically close it when this PR is merged
-->

Fixes redhat-developer#5405

**PR acceptance criteria:**

- [ ] Unit test

- [ ] Integration test

- [ ] Documentation

**How to test changes / Special notes to the reviewer:**

```sh
git clone https://github.com/odo-devfiles/nodejs-ex
cd nodejs-ex
odo create nodejs test
odo push
odo list
```
cdrage added a commit to cdrage/odo that referenced this issue Feb 24, 2022
<!--
Thank you for opening a PR! Here are some things you need to know before submitting:

1. Please read our developer guideline: https://github.com/redhat-developer/odo/wiki/Developer-Guidelines
2. Label this PR accordingly with the '/kind' line
3. Ensure you have written and ran the appropriate tests: https://github.com/redhat-developer/odo/wiki/Writing-and-running-tests
4. Read how we approve and LGTM each PR: https://github.com/redhat-developer/odo/wiki/PR-Review

Documentation:

If you are pushing a change to documentation, please read: https://github.com/redhat-developer/odo/wiki/Contributing-to-Docs
-->

**What type of PR is this:**

<!--
Add one of the following kinds:
/kind bug
/kind cleanup
/kind tests
/kind documentation

Feel free to use other [labels](https://github.com/redhat-developer/odo/labels) as needed. However one of the above labels must be present or the PR will not be reviewed. This instruction is for reviewers as well.
-->

/kind feature

**What does this PR do / why we need it:**

This redesigns the `odo list` functionality like so:

```sh
~/nodejs
▶ odo list
NAME                    TYPE       MODE          MANAGED   URLS                        PORTS               STATUS      AGE
* nodejs-prj1-api-abhz  nodejs     devfile.yaml  odo                                                       Not Pushed
foo                     nodejs     Dev           odo       http://foobar.k8s.land      3000                Running     2m15s
digitalocean-dyndns     <unknown>  <unknown>     Helm                                                      Running     17d
duplicati               <unknown>  <unknown>     Helm      https://duplicati.k8s.land  8200                Running     37d
hass                    <unknown>  <unknown>     Helm      https://hass.k8s.land       8123                Running     17d
hostpath-provisioner    <unknown>  <unknown>     Helm                                                      Running     37d
syncthing               <unknown>  <unknown>     Helm      https://syncthing.k8s.land  21027, 22000, 8384  Running     39d
```

Changes:
- Refactors components in component/component.go files
- Implement changes so we rely less on the local environment files and
  more from retrieving from the cluster

**Which issue(s) this PR fixes:**
<!--
Specifying the issue will automatically close it when this PR is merged
-->

Fixes redhat-developer#5405

**PR acceptance criteria:**

- [ ] Unit test

- [ ] Integration test

- [ ] Documentation

**How to test changes / Special notes to the reviewer:**

```sh
git clone https://github.com/odo-devfiles/nodejs-ex
cd nodejs-ex
odo create nodejs test
odo push
odo list
```
cdrage added a commit to cdrage/odo that referenced this issue Feb 24, 2022
<!--
Thank you for opening a PR! Here are some things you need to know before submitting:

1. Please read our developer guideline: https://github.com/redhat-developer/odo/wiki/Developer-Guidelines
2. Label this PR accordingly with the '/kind' line
3. Ensure you have written and ran the appropriate tests: https://github.com/redhat-developer/odo/wiki/Writing-and-running-tests
4. Read how we approve and LGTM each PR: https://github.com/redhat-developer/odo/wiki/PR-Review

Documentation:

If you are pushing a change to documentation, please read: https://github.com/redhat-developer/odo/wiki/Contributing-to-Docs
-->

**What type of PR is this:**

<!--
Add one of the following kinds:
/kind bug
/kind cleanup
/kind tests
/kind documentation

Feel free to use other [labels](https://github.com/redhat-developer/odo/labels) as needed. However one of the above labels must be present or the PR will not be reviewed. This instruction is for reviewers as well.
-->

/kind feature

**What does this PR do / why we need it:**

This redesigns the `odo list` functionality like so:

```sh
~/nodejs
▶ odo list
NAME                    TYPE       MODE          MANAGED   URLS                        PORTS               STATUS      AGE
* nodejs-prj1-api-abhz  nodejs     devfile.yaml  odo                                                       Not Pushed
foo                     nodejs     Dev           odo       http://foobar.k8s.land      3000                Running     2m15s
digitalocean-dyndns     <unknown>  <unknown>     Helm                                                      Running     17d
duplicati               <unknown>  <unknown>     Helm      https://duplicati.k8s.land  8200                Running     37d
hass                    <unknown>  <unknown>     Helm      https://hass.k8s.land       8123                Running     17d
hostpath-provisioner    <unknown>  <unknown>     Helm                                                      Running     37d
syncthing               <unknown>  <unknown>     Helm      https://syncthing.k8s.land  21027, 22000, 8384  Running     39d
```

Changes:
- Refactors components in component/component.go files
- Implement changes so we rely less on the local environment files and
  more from retrieving from the cluster

**Which issue(s) this PR fixes:**
<!--
Specifying the issue will automatically close it when this PR is merged
-->

Fixes redhat-developer#5405

**PR acceptance criteria:**

- [ ] Unit test

- [ ] Integration test

- [ ] Documentation

**How to test changes / Special notes to the reviewer:**

```sh
git clone https://github.com/odo-devfiles/nodejs-ex
cd nodejs-ex
odo create nodejs test
odo push
odo list
```
cdrage added a commit to cdrage/odo that referenced this issue Feb 25, 2022
<!--
Thank you for opening a PR! Here are some things you need to know before submitting:

1. Please read our developer guideline: https://github.com/redhat-developer/odo/wiki/Developer-Guidelines
2. Label this PR accordingly with the '/kind' line
3. Ensure you have written and ran the appropriate tests: https://github.com/redhat-developer/odo/wiki/Writing-and-running-tests
4. Read how we approve and LGTM each PR: https://github.com/redhat-developer/odo/wiki/PR-Review

Documentation:

If you are pushing a change to documentation, please read: https://github.com/redhat-developer/odo/wiki/Contributing-to-Docs
-->

**What type of PR is this:**

<!--
Add one of the following kinds:
/kind bug
/kind cleanup
/kind tests
/kind documentation

Feel free to use other [labels](https://github.com/redhat-developer/odo/labels) as needed. However one of the above labels must be present or the PR will not be reviewed. This instruction is for reviewers as well.
-->

/kind feature

**What does this PR do / why we need it:**

This redesigns the `odo list` functionality like so:

```sh
~/nodejs
▶ odo list
NAME                    TYPE       MODE          MANAGED   URLS                        PORTS               STATUS      AGE
* nodejs-prj1-api-abhz  nodejs     devfile.yaml  odo                                                       Not Pushed
foo                     nodejs     Dev           odo       http://foobar.k8s.land      3000                Running     2m15s
digitalocean-dyndns     <unknown>  <unknown>     Helm                                                      Running     17d
duplicati               <unknown>  <unknown>     Helm      https://duplicati.k8s.land  8200                Running     37d
hass                    <unknown>  <unknown>     Helm      https://hass.k8s.land       8123                Running     17d
hostpath-provisioner    <unknown>  <unknown>     Helm                                                      Running     37d
syncthing               <unknown>  <unknown>     Helm      https://syncthing.k8s.land  21027, 22000, 8384  Running     39d
```

Changes:
- Refactors components in component/component.go files
- Implement changes so we rely less on the local environment files and
  more from retrieving from the cluster

**Which issue(s) this PR fixes:**
<!--
Specifying the issue will automatically close it when this PR is merged
-->

Fixes redhat-developer#5405

**PR acceptance criteria:**

- [ ] Unit test

- [ ] Integration test

- [ ] Documentation

**How to test changes / Special notes to the reviewer:**

```sh
git clone https://github.com/odo-devfiles/nodejs-ex
cd nodejs-ex
odo create nodejs test
odo push
odo list
```
cdrage added a commit to cdrage/odo that referenced this issue Feb 25, 2022
<!--
Thank you for opening a PR! Here are some things you need to know before submitting:

1. Please read our developer guideline: https://github.com/redhat-developer/odo/wiki/Developer-Guidelines
2. Label this PR accordingly with the '/kind' line
3. Ensure you have written and ran the appropriate tests: https://github.com/redhat-developer/odo/wiki/Writing-and-running-tests
4. Read how we approve and LGTM each PR: https://github.com/redhat-developer/odo/wiki/PR-Review

Documentation:

If you are pushing a change to documentation, please read: https://github.com/redhat-developer/odo/wiki/Contributing-to-Docs
-->

**What type of PR is this:**

<!--
Add one of the following kinds:
/kind bug
/kind cleanup
/kind tests
/kind documentation

Feel free to use other [labels](https://github.com/redhat-developer/odo/labels) as needed. However one of the above labels must be present or the PR will not be reviewed. This instruction is for reviewers as well.
-->

/kind feature

**What does this PR do / why we need it:**

This redesigns the `odo list` functionality like so:

```sh
~/nodejs
▶ odo list
NAME                    TYPE       MODE          MANAGED   URLS                        PORTS               STATUS      AGE
* nodejs-prj1-api-abhz  nodejs     devfile.yaml  odo                                                       Not Pushed
foo                     nodejs     Dev           odo       http://foobar.k8s.land      3000                Running     2m15s
digitalocean-dyndns     <unknown>  <unknown>     Helm                                                      Running     17d
duplicati               <unknown>  <unknown>     Helm      https://duplicati.k8s.land  8200                Running     37d
hass                    <unknown>  <unknown>     Helm      https://hass.k8s.land       8123                Running     17d
hostpath-provisioner    <unknown>  <unknown>     Helm                                                      Running     37d
syncthing               <unknown>  <unknown>     Helm      https://syncthing.k8s.land  21027, 22000, 8384  Running     39d
```

Changes:
- Refactors components in component/component.go files
- Implement changes so we rely less on the local environment files and
  more from retrieving from the cluster

**Which issue(s) this PR fixes:**
<!--
Specifying the issue will automatically close it when this PR is merged
-->

Fixes redhat-developer#5405

**PR acceptance criteria:**

- [ ] Unit test

- [ ] Integration test

- [ ] Documentation

**How to test changes / Special notes to the reviewer:**

```sh
git clone https://github.com/odo-devfiles/nodejs-ex
cd nodejs-ex
odo create nodejs test
odo push
odo list
```
cdrage added a commit to cdrage/odo that referenced this issue Mar 1, 2022
<!--
Thank you for opening a PR! Here are some things you need to know before submitting:

1. Please read our developer guideline: https://github.com/redhat-developer/odo/wiki/Developer-Guidelines
2. Label this PR accordingly with the '/kind' line
3. Ensure you have written and ran the appropriate tests: https://github.com/redhat-developer/odo/wiki/Writing-and-running-tests
4. Read how we approve and LGTM each PR: https://github.com/redhat-developer/odo/wiki/PR-Review

Documentation:

If you are pushing a change to documentation, please read: https://github.com/redhat-developer/odo/wiki/Contributing-to-Docs
-->

**What type of PR is this:**

<!--
Add one of the following kinds:
/kind bug
/kind cleanup
/kind tests
/kind documentation

Feel free to use other [labels](https://github.com/redhat-developer/odo/labels) as needed. However one of the above labels must be present or the PR will not be reviewed. This instruction is for reviewers as well.
-->

/kind feature

**What does this PR do / why we need it:**

This redesigns the `odo list` functionality like so:

```sh
~/nodejs
▶ odo list
NAME                    TYPE       MODE          MANAGED   URLS                        PORTS               STATUS      AGE
* nodejs-prj1-api-abhz  nodejs     devfile.yaml  odo                                                       Not Pushed
foo                     nodejs     Dev           odo       http://foobar.k8s.land      3000                Running     2m15s
digitalocean-dyndns     <unknown>  <unknown>     Helm                                                      Running     17d
duplicati               <unknown>  <unknown>     Helm      https://duplicati.k8s.land  8200                Running     37d
hass                    <unknown>  <unknown>     Helm      https://hass.k8s.land       8123                Running     17d
hostpath-provisioner    <unknown>  <unknown>     Helm                                                      Running     37d
syncthing               <unknown>  <unknown>     Helm      https://syncthing.k8s.land  21027, 22000, 8384  Running     39d
```

Changes:
- Refactors components in component/component.go files
- Implement changes so we rely less on the local environment files and
  more from retrieving from the cluster

**Which issue(s) this PR fixes:**
<!--
Specifying the issue will automatically close it when this PR is merged
-->

Fixes redhat-developer#5405

**PR acceptance criteria:**

- [ ] Unit test

- [ ] Integration test

- [ ] Documentation

**How to test changes / Special notes to the reviewer:**

```sh
git clone https://github.com/odo-devfiles/nodejs-ex
cd nodejs-ex
odo create nodejs test
odo push
odo list
```
cdrage added a commit to cdrage/odo that referenced this issue Mar 1, 2022
<!--
Thank you for opening a PR! Here are some things you need to know before submitting:

1. Please read our developer guideline: https://github.com/redhat-developer/odo/wiki/Developer-Guidelines
2. Label this PR accordingly with the '/kind' line
3. Ensure you have written and ran the appropriate tests: https://github.com/redhat-developer/odo/wiki/Writing-and-running-tests
4. Read how we approve and LGTM each PR: https://github.com/redhat-developer/odo/wiki/PR-Review

Documentation:

If you are pushing a change to documentation, please read: https://github.com/redhat-developer/odo/wiki/Contributing-to-Docs
-->

**What type of PR is this:**

<!--
Add one of the following kinds:
/kind bug
/kind cleanup
/kind tests
/kind documentation

Feel free to use other [labels](https://github.com/redhat-developer/odo/labels) as needed. However one of the above labels must be present or the PR will not be reviewed. This instruction is for reviewers as well.
-->

/kind feature

**What does this PR do / why we need it:**

This redesigns the `odo list` functionality like so:

```sh
~/nodejs
▶ odo list
NAME                    TYPE       MODE          MANAGED   URLS                        PORTS               STATUS      AGE
* nodejs-prj1-api-abhz  nodejs     devfile.yaml  odo                                                       Not Pushed
foo                     nodejs     Dev           odo       http://foobar.k8s.land      3000                Running     2m15s
digitalocean-dyndns     <unknown>  <unknown>     Helm                                                      Running     17d
duplicati               <unknown>  <unknown>     Helm      https://duplicati.k8s.land  8200                Running     37d
hass                    <unknown>  <unknown>     Helm      https://hass.k8s.land       8123                Running     17d
hostpath-provisioner    <unknown>  <unknown>     Helm                                                      Running     37d
syncthing               <unknown>  <unknown>     Helm      https://syncthing.k8s.land  21027, 22000, 8384  Running     39d
```

Changes:
- Refactors components in component/component.go files
- Implement changes so we rely less on the local environment files and
  more from retrieving from the cluster

**Which issue(s) this PR fixes:**
<!--
Specifying the issue will automatically close it when this PR is merged
-->

Fixes redhat-developer#5405

**PR acceptance criteria:**

- [ ] Unit test

- [ ] Integration test

- [ ] Documentation

**How to test changes / Special notes to the reviewer:**

```sh
git clone https://github.com/odo-devfiles/nodejs-ex
cd nodejs-ex
odo create nodejs test
odo push
odo list
```
cdrage added a commit to cdrage/odo that referenced this issue Mar 2, 2022
<!--
Thank you for opening a PR! Here are some things you need to know before submitting:

1. Please read our developer guideline: https://github.com/redhat-developer/odo/wiki/Developer-Guidelines
2. Label this PR accordingly with the '/kind' line
3. Ensure you have written and ran the appropriate tests: https://github.com/redhat-developer/odo/wiki/Writing-and-running-tests
4. Read how we approve and LGTM each PR: https://github.com/redhat-developer/odo/wiki/PR-Review

Documentation:

If you are pushing a change to documentation, please read: https://github.com/redhat-developer/odo/wiki/Contributing-to-Docs
-->

**What type of PR is this:**

<!--
Add one of the following kinds:
/kind bug
/kind cleanup
/kind tests
/kind documentation

Feel free to use other [labels](https://github.com/redhat-developer/odo/labels) as needed. However one of the above labels must be present or the PR will not be reviewed. This instruction is for reviewers as well.
-->

/kind feature

**What does this PR do / why we need it:**

This redesigns the `odo list` functionality like so:

```sh
~/nodejs
▶ odo list
NAME                    TYPE       MODE          MANAGED   URLS                        PORTS               STATUS      AGE
* nodejs-prj1-api-abhz  nodejs     devfile.yaml  odo                                                       Not Pushed
foo                     nodejs     Dev           odo       http://foobar.k8s.land      3000                Running     2m15s
digitalocean-dyndns     <unknown>  <unknown>     Helm                                                      Running     17d
duplicati               <unknown>  <unknown>     Helm      https://duplicati.k8s.land  8200                Running     37d
hass                    <unknown>  <unknown>     Helm      https://hass.k8s.land       8123                Running     17d
hostpath-provisioner    <unknown>  <unknown>     Helm                                                      Running     37d
syncthing               <unknown>  <unknown>     Helm      https://syncthing.k8s.land  21027, 22000, 8384  Running     39d
```

Changes:
- Refactors components in component/component.go files
- Implement changes so we rely less on the local environment files and
  more from retrieving from the cluster

**Which issue(s) this PR fixes:**
<!--
Specifying the issue will automatically close it when this PR is merged
-->

Fixes redhat-developer#5405

**PR acceptance criteria:**

- [ ] Unit test

- [ ] Integration test

- [ ] Documentation

**How to test changes / Special notes to the reviewer:**

```sh
git clone https://github.com/odo-devfiles/nodejs-ex
cd nodejs-ex
odo create nodejs test
odo push
odo list
```
cdrage added a commit to cdrage/odo that referenced this issue Mar 14, 2022
<!--
Thank you for opening a PR! Here are some things you need to know before submitting:

1. Please read our developer guideline: https://github.com/redhat-developer/odo/wiki/Dev:-odo-Dev-Guidelines
2. Label this PR accordingly with the '/kind' line
3. Ensure you have written and ran the appropriate tests: https://github.com/redhat-developer/odo/wiki/Dev:-Writing-and-running-tests
4. Read how we approve and LGTM each PR: https://github.com/redhat-developer/odo/wiki/Pull-Requests:-Review-guideline

Documentation:

If you are pushing a change to documentation, please read: https://github.com/redhat-developer/odo/wiki/Documentation:-Contributing
-->

**What type of PR is this:**

<!--
Add one of the following kinds:
/kind bug
/kind tests
/kind documentation

Feel free to use other [labels](https://github.com/redhat-developer/odo/labels) as needed. However one of the above labels must be present or the PR will not be reviewed. This instruction is for reviewers as well.
-->
/kind feature
/kind cleanup

**What does this PR do / why we need it:**

In this PR we:
  * Correctly name all the labels in a more concise manner (ex. Project Type
    is an annotation)
  * Add Dev and Deploy mode labels to both `odo dev` and `odo deploy`
    commands so that we can intuitively retrieve what components are in
    deploy or dev mode
  * Somewhat refactors how we do labeling

**Which issue(s) this PR fixes:**
<!--
Specifying the issue will automatically close it when this PR is merged
-->

1/2 of PR's for redhat-developer#5405

**PR acceptance criteria:**

- [X] Unit test

- [X] Integration test

- [X] Documentation

**How to test changes / Special notes to the reviewer:**

N/A

Signed-off-by: Charlie Drage <charlie@charliedrage.com>
cdrage added a commit to cdrage/odo that referenced this issue Mar 14, 2022
<!--
Thank you for opening a PR! Here are some things you need to know before submitting:

1. Please read our developer guideline: https://github.com/redhat-developer/odo/wiki/Dev:-odo-Dev-Guidelines
2. Label this PR accordingly with the '/kind' line
3. Ensure you have written and ran the appropriate tests: https://github.com/redhat-developer/odo/wiki/Dev:-Writing-and-running-tests
4. Read how we approve and LGTM each PR: https://github.com/redhat-developer/odo/wiki/Pull-Requests:-Review-guideline

Documentation:

If you are pushing a change to documentation, please read: https://github.com/redhat-developer/odo/wiki/Documentation:-Contributing
-->

**What type of PR is this:**

<!--
Add one of the following kinds:
/kind bug
/kind tests
/kind documentation

Feel free to use other [labels](https://github.com/redhat-developer/odo/labels) as needed. However one of the above labels must be present or the PR will not be reviewed. This instruction is for reviewers as well.
-->
/kind feature
/kind cleanup

**What does this PR do / why we need it:**

In this PR we:
  * Correctly name all the labels in a more concise manner (ex. Project Type
    is an annotation)
  * Add Dev and Deploy mode labels to both `odo dev` and `odo deploy`
    commands so that we can intuitively retrieve what components are in
    deploy or dev mode
  * Somewhat refactors how we do labeling

**Which issue(s) this PR fixes:**
<!--
Specifying the issue will automatically close it when this PR is merged
-->

1/2 of PR's for redhat-developer#5405

**PR acceptance criteria:**

- [X] Unit test

- [X] Integration test

- [X] Documentation

**How to test changes / Special notes to the reviewer:**

N/A

Signed-off-by: Charlie Drage <charlie@charliedrage.com>
cdrage added a commit to cdrage/odo that referenced this issue Mar 14, 2022
<!--
Thank you for opening a PR! Here are some things you need to know before submitting:

1. Please read our developer guideline: https://github.com/redhat-developer/odo/wiki/Dev:-odo-Dev-Guidelines
2. Label this PR accordingly with the '/kind' line
3. Ensure you have written and ran the appropriate tests: https://github.com/redhat-developer/odo/wiki/Dev:-Writing-and-running-tests
4. Read how we approve and LGTM each PR: https://github.com/redhat-developer/odo/wiki/Pull-Requests:-Review-guideline

Documentation:

If you are pushing a change to documentation, please read: https://github.com/redhat-developer/odo/wiki/Documentation:-Contributing
-->

**What type of PR is this:**

<!--
Add one of the following kinds:
/kind bug
/kind tests
/kind documentation

Feel free to use other [labels](https://github.com/redhat-developer/odo/labels) as needed. However one of the above labels must be present or the PR will not be reviewed. This instruction is for reviewers as well.
-->
/kind feature
/kind cleanup

**What does this PR do / why we need it:**

In this PR we:
  * Correctly name all the labels in a more concise manner (ex. Project Type
    is an annotation)
  * Add Dev and Deploy mode labels to both `odo dev` and `odo deploy`
    commands so that we can intuitively retrieve what components are in
    deploy or dev mode
  * Somewhat refactors how we do labeling

**Which issue(s) this PR fixes:**
<!--
Specifying the issue will automatically close it when this PR is merged
-->

1/2 of PR's for redhat-developer#5405

**PR acceptance criteria:**

- [X] Unit test

- [X] Integration test

- [X] Documentation

**How to test changes / Special notes to the reviewer:**

N/A

Signed-off-by: Charlie Drage <charlie@charliedrage.com>
cdrage added a commit to cdrage/odo that referenced this issue Mar 14, 2022
<!--
Thank you for opening a PR! Here are some things you need to know before submitting:

1. Please read our developer guideline: https://github.com/redhat-developer/odo/wiki/Developer-Guidelines
2. Label this PR accordingly with the '/kind' line
3. Ensure you have written and ran the appropriate tests: https://github.com/redhat-developer/odo/wiki/Writing-and-running-tests
4. Read how we approve and LGTM each PR: https://github.com/redhat-developer/odo/wiki/PR-Review

Documentation:

If you are pushing a change to documentation, please read: https://github.com/redhat-developer/odo/wiki/Contributing-to-Docs
-->

**What type of PR is this:**

<!--
Add one of the following kinds:
/kind bug
/kind cleanup
/kind tests
/kind documentation

Feel free to use other [labels](https://github.com/redhat-developer/odo/labels) as needed. However one of the above labels must be present or the PR will not be reviewed. This instruction is for reviewers as well.
-->

/kind feature

**What does this PR do / why we need it:**

This redesigns the `odo list` functionality like so:

```sh
 NAME                             PROJECT TYPE  RUNNING IN     MANAGED
 deploy-test-app-2                nodejs        Deploy         odo
 deploy-test-app                  nodejs        Deploy, Dev    odo
 syncthing                        <unknown>     <unknown>      Helm
```

Changes:
- Refactors components in component/component.go files
- Implement changes so we rely less on the local environment files and
  more from retrieving from the cluster
- Retrieves from the Kubernetes cluster *all* resources, then outputs all the ones that have the `instance` label, regardless if it is a `odo` component or not.

**Which issue(s) this PR fixes:**
<!--
Specifying the issue will automatically close it when this PR is merged
-->

Fixes redhat-developer#5405

**PR acceptance criteria:**

- [X] Unit test

- [X] Integration test

- [X] Documentation

**How to test changes / Special notes to the reviewer:**

```sh
git clone https://github.com/kadel/devfile-nodejs-deploy devfile
cd devfile
git checkout knative
odo deploy
odo list
```
openshift-merge-robot pushed a commit that referenced this issue Mar 17, 2022
…5551)

* Add Dev and Project labeling / refactoring labeling and annotations

<!--
Thank you for opening a PR! Here are some things you need to know before submitting:

1. Please read our developer guideline: https://github.com/redhat-developer/odo/wiki/Dev:-odo-Dev-Guidelines
2. Label this PR accordingly with the '/kind' line
3. Ensure you have written and ran the appropriate tests: https://github.com/redhat-developer/odo/wiki/Dev:-Writing-and-running-tests
4. Read how we approve and LGTM each PR: https://github.com/redhat-developer/odo/wiki/Pull-Requests:-Review-guideline

Documentation:

If you are pushing a change to documentation, please read: https://github.com/redhat-developer/odo/wiki/Documentation:-Contributing
-->

**What type of PR is this:**

<!--
Add one of the following kinds:
/kind bug
/kind tests
/kind documentation

Feel free to use other [labels](https://github.com/redhat-developer/odo/labels) as needed. However one of the above labels must be present or the PR will not be reviewed. This instruction is for reviewers as well.
-->
/kind feature
/kind cleanup

**What does this PR do / why we need it:**

In this PR we:
  * Correctly name all the labels in a more concise manner (ex. Project Type
    is an annotation)
  * Add Dev and Deploy mode labels to both `odo dev` and `odo deploy`
    commands so that we can intuitively retrieve what components are in
    deploy or dev mode
  * Somewhat refactors how we do labeling

**Which issue(s) this PR fixes:**
<!--
Specifying the issue will automatically close it when this PR is merged
-->

1/2 of PR's for #5405

**PR acceptance criteria:**

- [X] Unit test

- [X] Integration test

- [X] Documentation

**How to test changes / Special notes to the reviewer:**

N/A

Signed-off-by: Charlie Drage <charlie@charliedrage.com>

* Review update / renaming

Signed-off-by: Charlie Drage <charlie@charliedrage.com>

* Review changes. Adds tests for generateDeploymentObjectMeta. Changes labels

Signed-off-by: Charlie Drage <charlie@charliedrage.com>
cdrage added a commit to cdrage/odo that referenced this issue Mar 21, 2022
<!--
Thank you for opening a PR! Here are some things you need to know before submitting:

1. Please read our developer guideline: https://github.com/redhat-developer/odo/wiki/Developer-Guidelines
2. Label this PR accordingly with the '/kind' line
3. Ensure you have written and ran the appropriate tests: https://github.com/redhat-developer/odo/wiki/Writing-and-running-tests
4. Read how we approve and LGTM each PR: https://github.com/redhat-developer/odo/wiki/PR-Review

Documentation:

If you are pushing a change to documentation, please read: https://github.com/redhat-developer/odo/wiki/Contributing-to-Docs
-->

**What type of PR is this:**

<!--
Add one of the following kinds:
/kind bug
/kind cleanup
/kind tests
/kind documentation

Feel free to use other [labels](https://github.com/redhat-developer/odo/labels) as needed. However one of the above labels must be present or the PR will not be reviewed. This instruction is for reviewers as well.
-->

/kind feature

**What does this PR do / why we need it:**

This redesigns the `odo list` functionality like so:

```sh
 NAME                             PROJECT TYPE  RUNNING IN     MANAGED
 deploy-test-app-2                nodejs        Deploy         odo
 deploy-test-app                  nodejs        Deploy, Dev    odo
 syncthing                        <unknown>     <unknown>      Helm
```

Changes:
- Refactors components in component/component.go files
- Implement changes so we rely less on the local environment files and
  more from retrieving from the cluster
- Retrieves from the Kubernetes cluster *all* resources, then outputs all the ones that have the `instance` label, regardless if it is a `odo` component or not.

**Which issue(s) this PR fixes:**
<!--
Specifying the issue will automatically close it when this PR is merged
-->

Fixes redhat-developer#5405

**PR acceptance criteria:**

- [X] Unit test

- [X] Integration test

- [X] Documentation

**How to test changes / Special notes to the reviewer:**

```sh
git clone https://github.com/kadel/devfile-nodejs-deploy devfile
cd devfile
git checkout knative
odo deploy
odo list
```
cdrage added a commit to cdrage/odo that referenced this issue Mar 21, 2022
<!--
Thank you for opening a PR! Here are some things you need to know before submitting:

1. Please read our developer guideline: https://github.com/redhat-developer/odo/wiki/Developer-Guidelines
2. Label this PR accordingly with the '/kind' line
3. Ensure you have written and ran the appropriate tests: https://github.com/redhat-developer/odo/wiki/Writing-and-running-tests
4. Read how we approve and LGTM each PR: https://github.com/redhat-developer/odo/wiki/PR-Review

Documentation:

If you are pushing a change to documentation, please read: https://github.com/redhat-developer/odo/wiki/Contributing-to-Docs
-->

**What type of PR is this:**

<!--
Add one of the following kinds:
/kind bug
/kind cleanup
/kind tests
/kind documentation

Feel free to use other [labels](https://github.com/redhat-developer/odo/labels) as needed. However one of the above labels must be present or the PR will not be reviewed. This instruction is for reviewers as well.
-->

/kind feature

**What does this PR do / why we need it:**

This redesigns the `odo list` functionality like so:

```sh
 NAME                             PROJECT TYPE  RUNNING IN     MANAGED
 deploy-test-app-2                nodejs        Deploy         odo
 deploy-test-app                  nodejs        Deploy, Dev    odo
 syncthing                        <unknown>     <unknown>      Helm
```

Changes:
- Refactors components in component/component.go files
- Implement changes so we rely less on the local environment files and
  more from retrieving from the cluster
- Retrieves from the Kubernetes cluster *all* resources, then outputs all the ones that have the `instance` label, regardless if it is a `odo` component or not.

**Which issue(s) this PR fixes:**
<!--
Specifying the issue will automatically close it when this PR is merged
-->

Fixes redhat-developer#5405

**PR acceptance criteria:**

- [X] Unit test

- [X] Integration test

- [X] Documentation

**How to test changes / Special notes to the reviewer:**

```sh
git clone https://github.com/kadel/devfile-nodejs-deploy devfile
cd devfile
git checkout knative
odo deploy
odo list
```
cdrage added a commit to cdrage/odo that referenced this issue Mar 22, 2022
<!--
Thank you for opening a PR! Here are some things you need to know before submitting:

1. Please read our developer guideline: https://github.com/redhat-developer/odo/wiki/Developer-Guidelines
2. Label this PR accordingly with the '/kind' line
3. Ensure you have written and ran the appropriate tests: https://github.com/redhat-developer/odo/wiki/Writing-and-running-tests
4. Read how we approve and LGTM each PR: https://github.com/redhat-developer/odo/wiki/PR-Review

Documentation:

If you are pushing a change to documentation, please read: https://github.com/redhat-developer/odo/wiki/Contributing-to-Docs
-->

**What type of PR is this:**

<!--
Add one of the following kinds:
/kind bug
/kind cleanup
/kind tests
/kind documentation

Feel free to use other [labels](https://github.com/redhat-developer/odo/labels) as needed. However one of the above labels must be present or the PR will not be reviewed. This instruction is for reviewers as well.
-->

/kind feature

**What does this PR do / why we need it:**

This redesigns the `odo list` functionality like so:

```sh
 NAME                             PROJECT TYPE  RUNNING IN     MANAGED
 deploy-test-app-2                nodejs        Deploy         odo
 deploy-test-app                  nodejs        Deploy, Dev    odo
 syncthing                        <unknown>     <unknown>      Helm
```

Changes:
- Refactors components in component/component.go files
- Implement changes so we rely less on the local environment files and
  more from retrieving from the cluster
- Retrieves from the Kubernetes cluster *all* resources, then outputs all the ones that have the `instance` label, regardless if it is a `odo` component or not.

**Which issue(s) this PR fixes:**
<!--
Specifying the issue will automatically close it when this PR is merged
-->

Fixes redhat-developer#5405

**PR acceptance criteria:**

- [X] Unit test

- [X] Integration test

- [X] Documentation

**How to test changes / Special notes to the reviewer:**

```sh
git clone https://github.com/kadel/devfile-nodejs-deploy devfile
cd devfile
git checkout knative
odo deploy
odo list
```
cdrage added a commit to cdrage/odo that referenced this issue Mar 22, 2022
<!--
Thank you for opening a PR! Here are some things you need to know before submitting:

1. Please read our developer guideline: https://github.com/redhat-developer/odo/wiki/Developer-Guidelines
2. Label this PR accordingly with the '/kind' line
3. Ensure you have written and ran the appropriate tests: https://github.com/redhat-developer/odo/wiki/Writing-and-running-tests
4. Read how we approve and LGTM each PR: https://github.com/redhat-developer/odo/wiki/PR-Review

Documentation:

If you are pushing a change to documentation, please read: https://github.com/redhat-developer/odo/wiki/Contributing-to-Docs
-->

**What type of PR is this:**

<!--
Add one of the following kinds:
/kind bug
/kind cleanup
/kind tests
/kind documentation

Feel free to use other [labels](https://github.com/redhat-developer/odo/labels) as needed. However one of the above labels must be present or the PR will not be reviewed. This instruction is for reviewers as well.
-->

/kind feature

**What does this PR do / why we need it:**

This redesigns the `odo list` functionality like so:

```sh
 NAME                             PROJECT TYPE  RUNNING IN     MANAGED
 deploy-test-app-2                nodejs        Deploy         odo
 deploy-test-app                  nodejs        Deploy, Dev    odo
 syncthing                        <unknown>     <unknown>      Helm
```

Changes:
- Refactors components in component/component.go files
- Implement changes so we rely less on the local environment files and
  more from retrieving from the cluster
- Retrieves from the Kubernetes cluster *all* resources, then outputs all the ones that have the `instance` label, regardless if it is a `odo` component or not.

**Which issue(s) this PR fixes:**
<!--
Specifying the issue will automatically close it when this PR is merged
-->

Fixes redhat-developer#5405

**PR acceptance criteria:**

- [X] Unit test

- [X] Integration test

- [X] Documentation

**How to test changes / Special notes to the reviewer:**

```sh
git clone https://github.com/kadel/devfile-nodejs-deploy devfile
cd devfile
git checkout knative
odo deploy
odo list
```
cdrage added a commit to cdrage/odo that referenced this issue Mar 23, 2022
<!--
Thank you for opening a PR! Here are some things you need to know before submitting:

1. Please read our developer guideline: https://github.com/redhat-developer/odo/wiki/Developer-Guidelines
2. Label this PR accordingly with the '/kind' line
3. Ensure you have written and ran the appropriate tests: https://github.com/redhat-developer/odo/wiki/Writing-and-running-tests
4. Read how we approve and LGTM each PR: https://github.com/redhat-developer/odo/wiki/PR-Review

Documentation:

If you are pushing a change to documentation, please read: https://github.com/redhat-developer/odo/wiki/Contributing-to-Docs
-->

**What type of PR is this:**

<!--
Add one of the following kinds:
/kind bug
/kind cleanup
/kind tests
/kind documentation

Feel free to use other [labels](https://github.com/redhat-developer/odo/labels) as needed. However one of the above labels must be present or the PR will not be reviewed. This instruction is for reviewers as well.
-->

/kind feature

**What does this PR do / why we need it:**

This redesigns the `odo list` functionality like so:

```sh
 NAME                             PROJECT TYPE  RUNNING IN     MANAGED
 deploy-test-app-2                nodejs        Deploy         odo
 deploy-test-app                  nodejs        Deploy, Dev    odo
 syncthing                        <unknown>     <unknown>      Helm
```

Changes:
- Refactors components in component/component.go files
- Implement changes so we rely less on the local environment files and
  more from retrieving from the cluster
- Retrieves from the Kubernetes cluster *all* resources, then outputs all the ones that have the `instance` label, regardless if it is a `odo` component or not.

**Which issue(s) this PR fixes:**
<!--
Specifying the issue will automatically close it when this PR is merged
-->

Fixes redhat-developer#5405

**PR acceptance criteria:**

- [X] Unit test

- [X] Integration test

- [X] Documentation

**How to test changes / Special notes to the reviewer:**

```sh
git clone https://github.com/kadel/devfile-nodejs-deploy devfile
cd devfile
git checkout knative
odo deploy
odo list
```
@kadel kadel removed the v3 label Mar 24, 2022
cdrage added a commit to cdrage/odo that referenced this issue Aug 31, 2022
…edhat-developer#5551)

* Add Dev and Project labeling / refactoring labeling and annotations

<!--
Thank you for opening a PR! Here are some things you need to know before submitting:

1. Please read our developer guideline: https://github.com/redhat-developer/odo/wiki/Dev:-odo-Dev-Guidelines
2. Label this PR accordingly with the '/kind' line
3. Ensure you have written and ran the appropriate tests: https://github.com/redhat-developer/odo/wiki/Dev:-Writing-and-running-tests
4. Read how we approve and LGTM each PR: https://github.com/redhat-developer/odo/wiki/Pull-Requests:-Review-guideline

Documentation:

If you are pushing a change to documentation, please read: https://github.com/redhat-developer/odo/wiki/Documentation:-Contributing
-->

**What type of PR is this:**

<!--
Add one of the following kinds:
/kind bug
/kind tests
/kind documentation

Feel free to use other [labels](https://github.com/redhat-developer/odo/labels) as needed. However one of the above labels must be present or the PR will not be reviewed. This instruction is for reviewers as well.
-->
/kind feature
/kind cleanup

**What does this PR do / why we need it:**

In this PR we:
  * Correctly name all the labels in a more concise manner (ex. Project Type
    is an annotation)
  * Add Dev and Deploy mode labels to both `odo dev` and `odo deploy`
    commands so that we can intuitively retrieve what components are in
    deploy or dev mode
  * Somewhat refactors how we do labeling

**Which issue(s) this PR fixes:**
<!--
Specifying the issue will automatically close it when this PR is merged
-->

1/2 of PR's for redhat-developer#5405

**PR acceptance criteria:**

- [X] Unit test

- [X] Integration test

- [X] Documentation

**How to test changes / Special notes to the reviewer:**

N/A

Signed-off-by: Charlie Drage <charlie@charliedrage.com>

* Review update / renaming

Signed-off-by: Charlie Drage <charlie@charliedrage.com>

* Review changes. Adds tests for generateDeploymentObjectMeta. Changes labels

Signed-off-by: Charlie Drage <charlie@charliedrage.com>
@rm3l rm3l added the v3 label Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/user-story An issue of user-story kind
Projects
No open projects
Status: Done
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants