Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restart pod on Podman when related information is changed in Devfile #6458

Closed
2 tasks
Tracked by #6578
rm3l opened this issue Jan 4, 2023 · 5 comments · Fixed by #6802 or #6810
Closed
2 tasks
Tracked by #6578

Restart pod on Podman when related information is changed in Devfile #6458

rm3l opened this issue Jan 4, 2023 · 5 comments · Fixed by #6802 or #6810
Assignees
Labels
area/dev Issues or PRs related to `odo dev` area/odo-on-podman Issues or PRs related to running odo against Podman kind/user-story An issue of user-story kind priority/High Important issue; should be worked on before any other issues (except priority/Critical issue(s)). sprint demo Indicates an issue for which a demo should be recorded and presented at the end of the sprint.
Milestone

Comments

@rm3l
Copy link
Member

rm3l commented Jan 4, 2023

/kind user-story

User Story

As a user running odo against Podman, I want changes to my Devfile to be detected and applied, So that I can continuously iterate on my project without having to restart odo dev manually.

Restarting odo dev manually every time I edit something in the Devfile can be annoying and time-consuming.

Currently, it detects any changes to the Devfile and warns users that odo dev needs to be restarted (see #6336). Even changes that would not affect the running Pod (like changes to the build or run commands) are ignored.

Acceptance Criteria

  • [ ] It should recreate the Pod on Podman if there are changes in the Devfile that would modify the Pod spec (e.g., changes in the container component, ...)
  • [ ] It should not recreate the Pod on Podman if there are changes in the Devfile that would not modify the Pod spec (e.g., changes to the run command only)
  • [ ] Similarly to how odo dev works against a cluster, it should notify users of the current Pod state
  • [ ] Similarly to how odo dev works against a cluster, external factors that might affect the running Pod should also be handled by recreating the Pod if needed (but that can be a separate issue)
  • For now, it should just recreate the Pod on Podman if there any changes in the Devfile
  • Update documentation: remove this point from the "Podman Support limitations" page

Links

/kind user-story

@github-actions github-actions bot added the needs-triage Indicates an issue or PR lacks a `triage/*` and requires one. label Jan 4, 2023
@rm3l rm3l added kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation area/odo-on-podman Issues or PRs related to running odo against Podman labels Jan 4, 2023
@kadel kadel added the priority/High Important issue; should be worked on before any other issues (except priority/Critical issue(s)). label Mar 10, 2023
@rm3l rm3l added kind/user-story An issue of user-story kind and removed kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation labels Mar 22, 2023
@rm3l rm3l added the area/dev Issues or PRs related to `odo dev` label Mar 30, 2023
@rm3l rm3l changed the title Restart pod when related information is changed in Devfile Restart pod on Podman when related information is changed in Devfile Mar 30, 2023
@valaparthvi valaparthvi added the triage/needs-information Indicates an issue needs more information in order to work on it. label Apr 13, 2023
@valaparthvi
Copy link
Member

@rm3l To add more information on this.

@valaparthvi valaparthvi added the sprint demo Indicates an issue for which a demo should be recorded and presented at the end of the sprint. label Apr 18, 2023
@rm3l
Copy link
Member Author

rm3l commented Apr 20, 2023

/unassign
/remove-triage needs-information

Description and acceptance criteria updated. We can discuss and review this in the grooming call.

@openshift-ci openshift-ci bot unassigned rm3l Apr 20, 2023
@openshift-ci openshift-ci bot removed the triage/needs-information Indicates an issue needs more information in order to work on it. label Apr 20, 2023
@rm3l rm3l removed the needs-triage Indicates an issue or PR lacks a `triage/*` and requires one. label Apr 20, 2023
@rm3l
Copy link
Member Author

rm3l commented Apr 20, 2023

@valaparthvi I'm also removing this from the current Sprint (236) as it is not pointed yet, and so that it shows up in the Grooming view in the Project.

@valaparthvi valaparthvi added the needs-triage Indicates an issue or PR lacks a `triage/*` and requires one. label Apr 20, 2023
@valaparthvi
Copy link
Member

Grooming Call [April 20 '23]:
Current scope of the issue:

  1. For now, delete and recreate the pod no matter where the change occurs.
  2. Volumes can be used to maintain persistent data.
  3. Port forwarding needs to be restarted.

Look into other ACs after we decide on a new design to separate resources and commands.

@valaparthvi valaparthvi removed the needs-triage Indicates an issue or PR lacks a `triage/*` and requires one. label Apr 20, 2023
@valaparthvi
Copy link
Member

Should be fixed by refactoring done in #6771.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dev Issues or PRs related to `odo dev` area/odo-on-podman Issues or PRs related to running odo against Podman kind/user-story An issue of user-story kind priority/High Important issue; should be worked on before any other issues (except priority/Critical issue(s)). sprint demo Indicates an issue for which a demo should be recorded and presented at the end of the sprint.
Projects
Archived in project
4 participants