Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumps version to v1.0.0-beta4 #1987

Conversation

mohammedzee1000
Copy link
Contributor

@mohammedzee1000 mohammedzee1000 commented Aug 6, 2019

This PR bumps the odo version to v1.0.0-beta4

Release Notes Draft

Breaking Changes

Enhancements

Testing

Internal

Documentation

Signed-off-by: Mohammed Zeeshan Ahmed mohammed.zee1000@gmail.com

Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>
@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. size/L labels Aug 6, 2019
@mohammedzee1000
Copy link
Contributor Author

/retest

@mohammedzee1000
Copy link
Contributor Author

/cc @boczkowska

@@ -1,4 +1,4 @@
= Overview of the odo (OpenShift Do) CLI Structure
= Overview of the Odo (OpenShift Do) CLI Structure
Copy link
Member

@kadel kadel Aug 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The typography standard that we agreed on is that odo will be written with lowercase o

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, this comes from the template, right? Then it should be updated.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added back


[NOTE]
====
By default the path to the global preference file is `~/.odo/preferece.yaml`, it is stored in in the environment variable `GLOBALODOCONFIG`. You can set up a custom path by setting the value of the environment variable to a new preference path, for example `GLOBALODOCONFIG="new_path/preference.yaml"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was done by the script, I can add it back, but it also means script needs to be updated

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added back, but er should probably fix the scripts/template accordingly

Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>
@kadel
Copy link
Member

kadel commented Aug 6, 2019

Breaking Changes

I think that there is one more breaking change regarding ports - #1910

@kadel
Copy link
Member

kadel commented Aug 6, 2019

/approve
is this still WIP?

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kadel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Aug 6, 2019
@mohammedzee1000 mohammedzee1000 changed the title WIP Bumps version to v1.0.0-beta4 Bumps version to v1.0.0-beta4 Aug 6, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Aug 6, 2019
@@ -10,12 +10,12 @@ ___________________
git clone https://github.com/openshift/nodejs-ex && cd nodejs-ex
odo create nodejs
odo push

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary extra space. Remove the same in other places too

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is generated

@yhontyk
Copy link

yhontyk commented Aug 7, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Aug 7, 2019
@mohammedzee1000
Copy link
Contributor Author

/refresh

@openshift-merge-robot openshift-merge-robot merged commit d11517f into redhat-developer:master Aug 7, 2019
@mohammedzee1000
Copy link
Contributor Author

Windows side looking good, although a little hard to setup without cygwin

@rm3l rm3l added the estimated-size/L (20-40) Rough sizing for Epics. About 2 sprints of work for a person. label Jun 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. estimated-size/L (20-40) Rough sizing for Epics. About 2 sprints of work for a person. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants