New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bumps version to v1.0.0-beta4 #1987
Bumps version to v1.0.0-beta4 #1987
Conversation
Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>
/retest |
/cc @boczkowska |
docs/cli-reference.adoc
Outdated
@@ -1,4 +1,4 @@ | |||
= Overview of the odo (OpenShift Do) CLI Structure | |||
= Overview of the Odo (OpenShift Do) CLI Structure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The typography standard that we agreed on is that odo will be written with lowercase o
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, this comes from the template, right? Then it should be updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added back
docs/cli-reference.adoc
Outdated
|
||
[NOTE] | ||
==== | ||
By default the path to the global preference file is `~/.odo/preferece.yaml`, it is stored in in the environment variable `GLOBALODOCONFIG`. You can set up a custom path by setting the value of the environment variable to a new preference path, for example `GLOBALODOCONFIG="new_path/preference.yaml"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was this removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was done by the script, I can add it back, but it also means script needs to be updated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added back, but er should probably fix the scripts/template accordingly
Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>
b6e6d4a
to
5c3a302
Compare
I think that there is one more breaking change regarding ports - #1910 |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kadel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@@ -10,12 +10,12 @@ ___________________ | |||
git clone https://github.com/openshift/nodejs-ex && cd nodejs-ex | |||
odo create nodejs | |||
odo push | |||
|
|||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unnecessary extra space. Remove the same in other places too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is generated
/lgtm |
/refresh |
Windows side looking good, although a little hard to setup without cygwin |
This PR bumps the odo version to v1.0.0-beta4
Release Notes Draft
Breaking Changes
Enhancements
exist
call and removes the spinner around it Removes an extra exist call and removes the spinner around it #1965odo config set
no longer creates local config, instead reporting error check if the config file exists for odo config #1900--output
flag as it is now global Make --output a global parameter, disable logging, fix bug #1898--all
flag forodo list
Testing
oc describe dc
test flakes Fixing oc describe dc test falke #1963CmdShouldFail
Fix CmdShouldFail false positive #1902Internal
SourceLocation
of binary when--context
flag is used is now saved relative to component context used relative path to SourceLocation for binary #1921component.Exists
optimize component.exists function #1905Documentation
ODO_BOOTSTRAPPER_IMAGE
environment variable--path
flag inodo list
Fixes help message for path flag in odo list #1973odo app --help
Add newline spacing to odo app --help #1966GLOBALODOCONFIG
environment variable I1773 globalodoconfig docs #1939Signed-off-by: Mohammed Zeeshan Ahmed mohammed.zee1000@gmail.com