change the release extension from .gz to .tar.gz #2009

girishramnani · 2019-08-12T18:36:46Z

What is the purpose of this change? What does it change?

see $SUBJECT.

Was the change discussed in an issue?

fixes #1994

How to test changes?

make prepare-release should create

kadel · 2019-08-14T10:17:05Z

/approve

kadel · 2019-08-19T14:41:42Z

/assign @amitkrout @mohammedzee1000

amitkrout

$ make prepare-release
gox -osarch="darwin/amd64 linux/amd64 windows/amd64" -output="dist/bin/{{.OS}}-{{.Arch}}/odo" -ldflags="-w -X github.com/openshift/odo/pkg/odo/cli/version.GITCOMMIT=e017230d" ./cmd/odo/
Number of parallel builds: 7

-->     linux/amd64: github.com/openshift/odo/cmd/odo
-->    darwin/amd64: github.com/openshift/odo/cmd/odo
-->   windows/amd64: github.com/openshift/odo/cmd/odo
./scripts/prepare-release.sh
gzipping binary ./dist/bin/darwin-amd64/odo as ./dist/release/odo-darwin-amd64
a odo
copying binary ./dist/bin/darwin-amd64/odo to release directory
gzipping binary ./dist/bin/linux-amd64/odo as ./dist/release/odo-linux-amd64
a odo
copying binary ./dist/bin/linux-amd64/odo to release directory
gzipping binary ./dist/bin/windows-amd64/odo.exe as ./dist/release/odo-windows-amd64.exe
a odo.exe
copying binary ./dist/bin/windows-amd64/odo.exe to release directory
generating SHA256_SUM for release packages
find: -printf: unknown primary or operator
The SHA256 SUM for the release packages are:
Amits-MacBook-Pro:odo amit$

@girishramnani I have tested it on my macOS and found here are no SHA256 SUM for the release packages. Can you please have a look

And we can merge it even now, right ? if yes, then remove the phrase Open [Merge immediately before release]: from the title of the pr.

girishramnani · 2019-08-21T05:31:27Z

@amitkrout no we cannot merge it right now because the documentation would say odo.tar.gz which will only happen until next release. So from the time we merge this to the next release, the docs would be inconsistent

kadel · 2019-08-21T14:27:23Z

can we split this into two PRs? On that updates scripts, we can merge it now. And the other that will update just docs, that we can merge after the release?

amitkrout · 2019-08-22T05:41:14Z

It should not effect the released version doc of for example beta4 because the patching is done against master branch until the next release.

Can you point out which doc and the references reflect the changes

Please address this too

girishramnani · 2019-08-22T06:44:37Z

README.adoc

@@ -69,7 +69,7 @@ For more installation options please refer the link:docs/installation.adoc[insta
 In order to correctly use `odo` you must download it and add it
 to your `PATH` environment variable:

-. Download the `odo-windows-amd64.exe.gz` file from the
+. Download the `odo-windows-amd64.exe.tar.gz` file from the


@amitkrout this change

Ok, then it will comes to effect only when the very next release happen or somebody wants to run release locally on master. Correct me if i am wrong.

Doc changes on master won't effect doc of any old release, right ?

docs merged in would directly show up on github, and I think isn't that the place where people go to for docs? I dont think we release docs on a separate website. so if I merge this now people will see this as the current docs.

girishramnani · 2019-08-22T06:44:46Z

docs/installation.adoc

@@ -63,7 +63,7 @@ $ brew install kadel/odo/odo
 ==== Tarball installation

 ----
-# sh -c 'curl -L https://github.com/openshift/odo/releases/latest/download/odo-darwin-amd64.gz | gzip -d > /usr/local/bin/odo; chmod +x /usr/local/bin/odo'
+# sh -c 'curl -L https://github.com/openshift/odo/releases/latest/download/odo-darwin-amd64.tar.gz | tar -xvzf odo-darwin-amd64.tar.gz -C /usr/local/bin; chmod +x /usr/local/bin/odo'


@amitkrout this change

#2009 (comment)

girishramnani · 2019-08-22T06:44:57Z

docs/installation.adoc

@@ -109,7 +109,7 @@ $ echo "deb https://dl.bintray.com/odo/odo-deb-releases stretch main" | sudo tee
 ==== Tarball installation

 ----
-# sh -c 'curl -L https://github.com/openshift/odo/releases/latest/download/odo-linux-amd64.gz | gzip -d > /usr/local/bin/odo; chmod +x /usr/local/bin/odo'
+# sh -c 'curl -L https://github.com/openshift/odo/releases/latest/download/odo-linux-amd64.tar.gz | tar -xvzf odo-linux-amd64.tar.gz -C /usr/local/bin; chmod +x /usr/local/bin/odo'


@amitkrout this change

#2009 (comment)

girishramnani · 2019-08-22T06:45:10Z

docs/installation.adoc

@@ -179,7 +179,7 @@ $ dnf install odo
 ==== Tarball installation

 ----
-# sh -c 'curl -L https://github.com/openshift/odo/releases/latest/download/odo-linux-amd64.gz | gzip -d > /usr/local/bin/odo; chmod +x /usr/local/bin/odo'
+# sh -c 'curl -L https://github.com/openshift/odo/releases/latest/download/odo-linux-amd64.tar.gz | tar -xvzf odo-linux-amd64.tar.gz -C /usr/local/bin; chmod +x /usr/local/bin/odo'


@amitkrout this change

#2009 (comment)

girishramnani · 2019-08-22T06:46:57Z

@amitkrout I don't have a macOS machine to reproduce this. Can you help me get more information on this?

girishramnani · 2019-08-22T06:47:53Z

Makes sense, doing that now @kadel

amitkrout · 2019-08-22T11:32:03Z

On fedora no such issue occurred. The error is coming from line https://github.com/openshift/odo/pull/2009/files#diff-2ae5224a8073d5cd24ce33fe39d5bfa8R45 on mac host

generating SHA256_SUM for release packages
find: -printf: unknown primary or operator

girishramnani · 2019-08-23T10:00:29Z

@amitkrout can you check that was this working before?
https://unix.stackexchange.com/questions/272491/bash-error-find-printf-unknown-primary-or-operator

openshift-ci-robot · 2019-08-23T10:06:29Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kadel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~scripts/OWNERS~~ [kadel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

amitkrout · 2019-08-26T05:41:06Z

Thanks for sharing the link.
-printf is not supported in OSX (macOS) causing the issue. cc_ @kadel

girishramnani · 2019-08-26T06:02:26Z

Which means this wasn't working since a long time, we can resolve that later and open an issue for it for now. Thoughts?

amitkrout · 2019-08-26T07:46:30Z

If the fix is a complex one then i will in the favor of later fix (After GA), otherwise fix it before GA. @kadel WDYT ?

kadel · 2019-08-26T10:53:15Z

@amitkrout It is ok if this script doesn't work on Mac. It is meant to be run on Linux only. It is just for CI. BTW, if you want to run this on Mac, you still can just install GNU find brew install findutils --with-default-names

amitkrout · 2019-08-27T07:40:16Z

/lgtm

- Lists all URLs even if they are undeployed or not (redhat-developer#2034) - Added json output for `odo project delete -o json` (redhat-developer#2037) - Fixed service integration test that was previously failing (redhat-developer#2022) - `odo push` will now only push changed files (redhat-developer#2030) - We now use relative paths within the file indexer (redhat-developer#2003) - You can now create list and edit services using --app and --project (redhat-developer#2001) - Deleted files will now propagate to the OpenShift container (redhat-developer#1999) - Added `odo service create --context` functionality (redhat-developer#1997) - Making cross-compile independant of gox vendor package (redhat-developer#2047) - `odo-supervisord-image` has been renamed to `odo-init-image` (redhat-developer#2027) - Releases now use .tar.gz (redhat-developer#2009) - If there is an error creating a service, it will fail quicker (redhat-developer#2008) - We now have a Google Group! (redhat-developer#2007) - Added documentation on how to manage environment variables(redhat-developer#2026) - Badges added to the README (redhat-developer#2060) - Updated documentation on uninstallation (redhat-developer#2053) - Added documentation for default parameters (redhat-developer#2038) - Minor update to help output (redhat-developer#2006) - Updated documentation regarding bootstrapper image (redhat-developer#1991)

- Lists all URLs even if they are undeployed or not (#2034) - Added json output for `odo project delete -o json` (#2037) - Fixed service integration test that was previously failing (#2022) - `odo push` will now only push changed files (#2030) - We now use relative paths within the file indexer (#2003) - You can now create list and edit services using --app and --project (#2001) - Deleted files will now propagate to the OpenShift container (#1999) - Added `odo service create --context` functionality (#1997) - Making cross-compile independant of gox vendor package (#2047) - `odo-supervisord-image` has been renamed to `odo-init-image` (#2027) - Releases now use .tar.gz (#2009) - If there is an error creating a service, it will fail quicker (#2008) - We now have a Google Group! (#2007) - Added documentation on how to manage environment variables(#2026) - Badges added to the README (#2060) - Updated documentation on uninstallation (#2053) - Added documentation for default parameters (#2038) - Minor update to help output (#2006) - Updated documentation regarding bootstrapper image (#1991)

* change .gz to .tar.gz in docs * resolved the command

openshift-ci-robot added the size/S label Aug 12, 2019

openshift-ci-robot requested review from amitkrout and mohammedzee1000 August 12, 2019 18:37

girishramnani requested a review from kadel August 12, 2019 18:38

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Aug 14, 2019

openshift-ci-robot assigned amitkrout and mohammedzee1000 Aug 19, 2019

amitkrout suggested changes Aug 20, 2019

View reviewed changes

girishramnani commented Aug 22, 2019

View reviewed changes

girishramnani changed the title ~~[Merge immediately before release]: changed the release extension from .gz to .tar.gz~~ changed the release extension from .gz to .tar.gz Aug 23, 2019

girishramnani changed the title ~~changed the release extension from .gz to .tar.gz~~ change the release extension from .gz to .tar.gz Aug 23, 2019

change the release extension from .gz to .tar.gz

7c6c319

girishramnani force-pushed the enhancement/1994 branch from e017230 to 7c6c319 Compare August 23, 2019 10:06

girishramnani mentioned this pull request Aug 23, 2019

[merge after https://github.com/openshift/odo/pull/2009] change .gz to .tar.gz in docs #2039

Merged

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Aug 27, 2019

openshift-merge-robot merged commit c23e542 into redhat-developer:master Aug 27, 2019

cdrage mentioned this pull request Sep 3, 2019

Release 1.0.0-beta5 #2075

Merged

openshift-merge-robot pushed a commit that referenced this pull request Sep 13, 2019

[merge after #2009] change .gz to .tar.gz in docs (#2039)

6b631ba

* change .gz to .tar.gz in docs * resolved the command

mik-dass mentioned this pull request Nov 5, 2019

Commenting project command test flake spec #2356

Closed

rm3l added the estimated-size/S (5-10) Rough sizing for Epics. Less then one sprint of work for one person label Jun 18, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

change the release extension from .gz to .tar.gz #2009

change the release extension from .gz to .tar.gz #2009

girishramnani commented Aug 12, 2019 •

edited

kadel commented Aug 14, 2019

kadel commented Aug 19, 2019

amitkrout left a comment •

edited

girishramnani commented Aug 21, 2019

kadel commented Aug 21, 2019

amitkrout commented Aug 22, 2019 •

edited

girishramnani Aug 22, 2019

amitkrout Aug 22, 2019 •

edited

girishramnani Aug 23, 2019

girishramnani Aug 22, 2019

amitkrout Aug 22, 2019

girishramnani Aug 22, 2019

amitkrout Aug 22, 2019

girishramnani Aug 22, 2019

amitkrout Aug 22, 2019

girishramnani commented Aug 22, 2019

girishramnani commented Aug 22, 2019

amitkrout commented Aug 22, 2019

girishramnani commented Aug 23, 2019

openshift-ci-robot commented Aug 23, 2019

amitkrout commented Aug 26, 2019

girishramnani commented Aug 26, 2019

amitkrout commented Aug 26, 2019

kadel commented Aug 26, 2019

amitkrout commented Aug 27, 2019 •

edited

change the release extension from .gz to .tar.gz #2009

change the release extension from .gz to .tar.gz #2009

Conversation

girishramnani commented Aug 12, 2019 • edited

What is the purpose of this change? What does it change?

Was the change discussed in an issue?

How to test changes?

kadel commented Aug 14, 2019

kadel commented Aug 19, 2019

amitkrout left a comment • edited

Choose a reason for hiding this comment

girishramnani commented Aug 21, 2019

kadel commented Aug 21, 2019

amitkrout commented Aug 22, 2019 • edited

Choose a reason for hiding this comment

amitkrout Aug 22, 2019 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

girishramnani commented Aug 22, 2019

girishramnani commented Aug 22, 2019

amitkrout commented Aug 22, 2019

girishramnani commented Aug 23, 2019

openshift-ci-robot commented Aug 23, 2019

amitkrout commented Aug 26, 2019

girishramnani commented Aug 26, 2019

amitkrout commented Aug 26, 2019

kadel commented Aug 26, 2019

amitkrout commented Aug 27, 2019 • edited

girishramnani commented Aug 12, 2019 •

edited

amitkrout left a comment •

edited

amitkrout commented Aug 22, 2019 •

edited

amitkrout Aug 22, 2019 •

edited

amitkrout commented Aug 27, 2019 •

edited