Updates environment variable output

[cdrage]

Bolds the info message for outputting the environment variables as well
as changes the grammar.

[dharmit]

You'll need to make changes at: https://github.com/openshift/odo/blob/92ff85440599b15e89f21c109cf8dafe2277cbb7/tests/integration/servicecatalog/cmd_link_unlink_test.go#L202 and: https://github.com/openshift/odo/blob/92ff85440599b15e89f21c109cf8dafe2277cbb7/tests/integration/servicecatalog/cmd_link_unlink_test.go#L208

[cdrage]

Thanks @dharmit :) fixed!

[cdrage]

/test v4.2-integration

[dharmit]

/approve

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dharmit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/odo/OWNERS [dharmit]
• tests/OWNERS [dharmit]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[cdrage]

Changed the output a bit, let me know what you think @kadel @girishramnani

~/nodejs-ex  master ✗                                                                                                                                                                                                                                                                                                                                              351d ◒  ⍉
▶ odo unlink dh-mysql-apb                                       
 ✓  Service dh-mysql-apb has been successfully unlinked from the component frontend

The below secret environment variables were removed from the 'frontend' component:

· DB_USER
· DB_HOST
· DB_NAME
· DB_PASSWORD
· DB_PORT
· DB_TYPE

~/nodejs-ex  master ✗                                                                                                                                                                                                                                                                                                                                               351d ◒  
▶ odo link dh-mysql-apb  
 ✓  Service dh-mysql-apb has been successfully linked from the component frontend

The below secret environment variables were added to the 'frontend' component:

· DB_PASSWORD
· DB_PORT
· DB_TYPE
· DB_USER
· DB_HOST
· DB_NAME

You can now access the environment variables from within the component pod, for example:
$DB_NAME is now available within component dh-mysql-apb

[dharmit]

You can now access the environment variables from within the component pod, for example:
oc rsc <pod-name>
echo $DB_NAME

IMHO, this will be confusing to the users who're not familiar with OpenShift terminology. I think we're trying to abstract most things about OpenShift/oc via odo. A user who's not aware of what a pod means, would wonder what's going on, no? For a user using odo via VS Code adapters, we will have to choose different message (in json output, I guess) because they're likely not aware of what odo or oc is.

Besides that, oc rsc <pod-name> is a command that one has to execute from the development system, right? The statement You can now access the environment variables from within the component pod, for example made me think that it's a command that could be executed from inside the pod. But it could be just me.

[cdrage]

@dharmit Yeah, I thought the same thing too, but wasn't too sure. I'll remove that output.

When we merge in #2233 we can simply say use odo describe to see what environment variables are available.

[cdrage]

It will now look like this:

You can now access the environment variables from within the component pod, for example:
$DB_NAME is now available within component dh-mysql-apb

[kadel]

▶ odo link dh-mysql-apb  
 ✓  Service dh-mysql-apb has been successfully linked from the component frontend

The below secret environment variables were added to the 'frontend' component:

· DB_PASSWORD
· DB_PORT
· DB_TYPE
· DB_USER
· DB_HOST
· DB_NAME

You can now access the environment variables from within the component pod, for example:
$DB_NAME is now available within component dh-mysql-apb

The last statement is not true. $DB_NAME is now available within component dh-mysql-apb it should be $DB_NAME is now available within component nodejs-something.
You are linking nodejs component with mysql. So the environment variables are added to the nodejs component not mysql

/hold

[girishramnani]

▶ odo link dh-mysql-apb  
 ✓  Service dh-mysql-apb has been successfully linked from the component frontend

The below secret environment variables were added to the 'frontend' component:

· DB_PASSWORD
· DB_PORT
· DB_TYPE
· DB_USER
· DB_HOST
· DB_NAME

You can now access the environment variables from within the component pod, for example:
$DB_NAME is now available within component dh-mysql-apb

The last statement is not true. $DB_NAME is now available within component dh-mysql-apb it should be $DB_NAME is now available within component nodejs-something.
You are linking nodejs component with mysql. So the environment variables are added to the nodejs component not mysql

/hold

@cdrage the issue mentioned by tomas seems to be happening because the first argument is taken as component name so you might have to get the component name from the localConfigInfo or a better option might be to make o.Component() populate with the correct value.

[cdrage]

@kadel @girishramnani

The output was actually incorrect.. some copy-and-paste foo must of messed it up, but here is the correct output:

▶ odo link mongodb-persistent                                      
 ✓  Service mongodb-persistent has been successfully linked from the component nodejs-nodejs-ex-eapl

The below secret environment variables were added to the 'nodejs-nodejs-ex-eapl' component:

· admin_password
· database_name
· password
· uri
· username

You can now access the environment variables from within the component pod, for example:
$username is now available as a variable within component nodejs-nodejs-ex-eapl

[girishramnani]

From the code, it seemed that component name was populated from the first arg, I could be wrong

[girishramnani]

/hold cancel

[girishramnani]

/lgtm

[cdrage]

@girishramnani See line: https://github.com/openshift/odo/blob/083bf1852627793927304f24a61cf21b3011f6ca/pkg/odo/cli/component/common_link.go#L118 previously used in the code for o.Component().

Was simply a bad copy and paste from me. The code is correct :)

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.