change "from" to "to" for odo link

[danielhelfand]

What kind of PR is this?
/kind cleanup

What does does this PR do / why we need it:

Changes successful odo link message from

Component backend has been successfully linked from the component frontend

to

Component backend has been successfully linked to the component frontend

This reads a lot more clearly since information is being shared from the first component as part of odo link. The current implementation makes it sound as if information is coming from the component specified via the --component flag or via the context being worked in.

Looking for advice on whatever operationName options are available that could potentially not work with this message. Link was the only option considered here.

Which issue(s) this PR fixes:

None

[openshift-ci-robot]

Hi @danielhelfand. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[amitkrout]

/ok-to-test

[kadel]

Looking for advice on whatever operationName options are available that could potentially not work with this message. Link was the only option considered here.

operationName can have two possible values link or unlink based on the command that is called odo link or odo unlink.

It was probably done like this to to safe some coding, but now this is just complicating the messaging :-(

Component backend has been successfully unlinked to the component frontend

Now this doesn't look right to me. But the original message in odo link was not good either.

We might have to split the messages into two independent messages.
Maybe something like this?

switch operationName {
  case "link":
    log.Successf("%s %s has been successfully linked to the component %s\n", linkType, o.suppliedName, o.Component())
  case "unlink":
    log.Successf("%s %s has been successfully unlinked from the component %s\n", linkType, o.suppliedName, o.Component())
  default:
    return fmt.Errorf("unknwon operation %s", operationName)
}

[kadel]

/approve

@danielhelfand thank you for helping us making odo much more understandable.

[cdrage]

LGTM!

Thanks for the change @danielhelfand

/approve

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cdrage, kadel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/odo/OWNERS [cdrage,kadel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[cdrage]

/lgtm