Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable odo log -f tests #3808

Merged
merged 1 commit into from
Aug 21, 2020
Merged

Disable odo log -f tests #3808

merged 1 commit into from
Aug 21, 2020

Conversation

adisky
Copy link
Contributor

@adisky adisky commented Aug 21, 2020

What type of PR is this?

/kind failing-test

What does does this PR do / why we need it:
disable odo log -f tests, they are flaky, need some time to resolve them.

Which issue(s) this PR fixes:

PR acceptance criteria:

How to test changes / Special notes to the reviewer:

@amitkrout
Copy link
Contributor

@adisky In the third try i hit the same issue

$ make test-cmd-devfile-log
ginkgo  -randomizeAllSpecs -slowSpecThreshold=120 -timeout 7200s -debug -nodes=2 -focus="odo devfile log command tests" tests/integration/devfile/
Running Suite: Devfile Suite
============================
Random Seed: 1598002649 - Will randomize all specs
Will run 169 specs

Running in parallel across 2 nodes

SSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSS•SSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSS•SSSSSS•SSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSS
         -------------------------------------------------------------------
        |                                                                   |
        |  Ginkgo timed out waiting for all parallel nodes to report back!  |
        |                                                                   |
         -------------------------------------------------------------------

 devfile timed out. path: ./tests/integration/devfile

Ginkgo ran 1 suite in 1m22.461089588s
Test Suite Failed
make: *** [test-cmd-devfile-log] Error 1

@girishramnani
Copy link
Contributor

unit test failed?

@amitkrout
Copy link
Contributor

unit test failed?

test platform failure

2020/08/21 09:45:30 ci-operator version v20200821-bd4fbe1
2020/08/21 09:45:30 Loading configuration from https://config.ci.openshift.org for openshift/odo@master
2020/08/21 09:45:30 Resolved source https://github.com/openshift/odo to master@b410db9e, merging: #3808 b19a6634 @adisky
2020/08/21 09:45:30 Using namespace https://console-openshift-console.apps.build01.ci.devcluster.openshift.com/k8s/cluster/projects/ci-op-4w75cghq
2020/08/21 09:45:30 Running root, src, unit
2020/08/21 09:45:30 Creating namespace ci-op-4w75cghq
2020/08/21 09:45:30 Creating rolebinding for user adisky in namespace ci-op-4w75cghq
2020/08/21 09:45:30 Setting up pipeline imagestream for the test
2020/08/21 09:45:30 Created PDB for pods with openshift.io/build.name label
2020/08/21 09:45:30 Created PDB for pods with created-by-ci label
2020/08/21 09:45:30 Building root

/test unit

@amitkrout
Copy link
Contributor

amitkrout commented Aug 21, 2020

New commit. Did not work

Verified locally

@adisky adisky changed the title [DNM] [TEST] fix timeout issue Disable odo log -f tests Aug 21, 2020
@adisky
Copy link
Contributor Author

adisky commented Aug 21, 2020

@arout not working failing locally in 4-5 try, commented odo log -f tests for now,

Expect(err).To(BeNil())
Expect(match).To(BeTrue())
/*
Flaky Test odo log -f
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create an issue and paste it here for reference. We will fix that after v2

@amitkrout
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Aug 21, 2020
@girishramnani
Copy link
Contributor

Unit test failed

@girishramnani
Copy link
Contributor

/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: girishramnani

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Aug 21, 2020
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Aug 21, 2020
@cdrage
Copy link
Member

cdrage commented Aug 21, 2020

/lgtm

lets get this merged as other tests are failing because of this.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Aug 21, 2020
@cdrage cdrage merged commit 627c2fc into redhat-developer:master Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants