Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing typo and cleanup unused code #4064

Merged
merged 1 commit into from Oct 2, 2020
Merged

Fixing typo and cleanup unused code #4064

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 1 addition & 7 deletions pkg/odo/cli/component/common_link.go
View file
Open in desktop
Expand Up @@ -84,12 +84,6 @@ func (o *commonLinkOptions) complete(name string, cmd *cobra.Command, args []str
}

if o.csvSupport && o.Context.EnvSpecificInfo != nil {

// oclient, err := occlient.New()
// if err != nil {
// return err
// }

sboSupport, err := o.Client.IsSBRSupported()
if err != nil {
return err
Expand Down Expand Up @@ -152,7 +146,7 @@ func (o *commonLinkOptions) complete(name string, cmd *cobra.Command, args []str
svcExists, err := svc.SvcExists(o.Client, suppliedName, o.Application)
if err != nil {
// we consider this error to be non-terminal since it's entirely possible to use odo without the service catalog
klog.V(4).Infof("Unable to determine if %s is a service. This most likely means the service catalog is not installed. Proceesing to only use components", suppliedName)
klog.V(4).Infof("Unable to determine if %s is a service. This most likely means the service catalog is not installed. Processing to only use components", suppliedName)
svcExists = false
}

Expand Down