Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moves project related code from occlient.go to a new file #4211

Merged
merged 2 commits into from
Nov 18, 2020
Merged

Moves project related code from occlient.go to a new file #4211

merged 2 commits into from
Nov 18, 2020

Conversation

mik-dass
Copy link
Contributor

What type of PR is this?

/kind cleanup
/kind code-refactoring

What does does this PR do / why we need it:

Moves project related code from occlient.go to projects.go

Which issue(s) this PR fixes:

Fixes part of #4093

PR acceptance criteria:

How to test changes / Special notes to the reviewer:

  • Tests should pass

@codecov
Copy link

codecov bot commented Nov 11, 2020 •
edited
Loading

Codecov Report

Merging #4211 (29ac2b7) into master (fce3c77) will increase coverage by 0.02%.
The diff coverage is 27.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4211      +/-   ##
==========================================
+ Coverage   42.57%   42.60%   +0.02%     
==========================================
  Files         156      157       +1     
  Lines       13258    13267       +9     
==========================================
+ Hits         5645     5652       +7     
  Misses       7012     7012              
- Partials      601      603       +2
Impacted Files Coverage Δ
pkg/occlient/occlient.go 49.64% <ø> (+1.65%) ⬆️
pkg/odo/util/completion/completionhandlers.go 35.20% <0.00%> (ø)
pkg/occlient/projects.go 27.45% <27.45%> (ø)
pkg/project/project.go 45.45% <100.00%> (ø)
pkg/storage/storage.go 55.58% <0.00%> (-0.34%) ⬇️
pkg/component/component.go 22.44% <0.00%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fce3c77...29ac2b7. Read the comment docs.

@adisky
Copy link
Contributor

adisky commented Nov 17, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Nov 17, 2020
dharmit
dharmit suggested changes Nov 17, 2020
View reviewed changes
pkg/occlient/projects.go Show resolved Hide resolved
pkg/occlient/projects.go Outdated Show resolved Hide resolved
pkg/occlient/projects.go Outdated Show resolved Hide resolved
pkg/occlient/projects.go Outdated Show resolved Hide resolved
pkg/occlient/projects.go Outdated Show resolved Hide resolved
pkg/occlient/projects_test.go Outdated Show resolved Hide resolved
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Nov 17, 2020
dharmit
dharmit approved these changes Nov 17, 2020
View reviewed changes
Copy link
Member

@dharmit dharmit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mik-dass thanks for answering/fixing the questions/suggestions in PR feedback. 👍

Going to approve & lgtm since it was my review that removed lgtm given by @adisky

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Nov 17, 2020
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dharmit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Nov 17, 2020
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

11 similar comments
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 146c982 into redhat-developer:master Nov 18, 2020
@mik-dass mik-dass deleted the client-project-refactor branch November 18, 2020 12:52
@rm3l rm3l added the area/refactoring Issues or PRs related to code refactoring label Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dharmit dharmit dharmit approved these changes

@mohammedzee1000 mohammedzee1000 Awaiting requested review from mohammedzee1000

Assignees

@dharmit dharmit

@adisky adisky

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. area/refactoring Issues or PRs related to code refactoring lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@mik-dass @adisky @openshift-ci-robot @openshift-bot @dharmit @rm3l @openshift-merge-robot