Move functions to separate files in context package #4231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adisky
changed the title
|
/retest |
adisky
force-pushed
the
refactor-context3
branch
from
09a2741
to
ff7dfbd
Compare
| ) | ||
|
|
||
| // ResolveAppFlag resolves the app from the flag | ||
| func ResolveAppFlag(command *cobra.Command) string { |
There was a problem hiding this comment.
Doesn’t this make more sense to be in flag.go
There was a problem hiding this comment.
i will try to remove this in next PR's
|
/approve This refactor PR pass the tests |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: girishramnani The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind code-refactoring
What does does this PR do / why we need it:
part of context refactoring
Which issue(s) this PR fixes:
Partially : #4081
PR acceptance criteria:
Unit test
Integration test
Documentation
I have read the test guidelines
How to test changes / Special notes to the reviewer:
Tests should pass