Remove UpdatedContext function from context

[dharmit]

What type of PR is this?
/kind cleanup
/kind code-refactoring

What does this PR do / why we need it:
Removing the function since what it does seems to be already present in
the calling blocks of code.

Which issue(s) this PR fixes:

Fixes NA
Part of #4298

PR acceptance criteria:

• Unit test

• Integration test

• Documentation

• I have read the test guidelines

How to test changes / Special notes to the reviewer:
Tests should pass

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dharmit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [dharmit]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[dharmit]

Commands tested locally:

1. odo create nodejs --s2i --now
2. odo create nodejs --s2i --now -o json

Both of the above odo create commands succeeded while testing this change locally. So we just need the CI to be green.

cc @mohammedzee1000 (since you added this code as a part of #1668.)

[girishramnani]

/lgtm

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[dharmit]

All CI failures seem to be attributed to the same failure:

 • Failure [1.960 seconds]
odo component command tests
/go/src/github.com/openshift/odo/tests/integration/cmd_cmp_test.go:13
  Creating component
  /go/src/github.com/openshift/odo/tests/integration/component.go:49
    should describe not pushed component when it is created with json output [It]
    /go/src/github.com/openshift/odo/tests/integration/component.go:258
    Expected
      
        <string>: {
          "metadata": {
            "creationTimestamp": null
          },
          "spec": {
            "ports": [
              "8080/TCP"
            ]
          },
          "status": {
            "state": "Not Pushed"
          }
        }
    to match JSON of
        <string>: {
          "apiVersion": "odo.dev/v1alpha1",
          "kind": "Component",
          "metadata": {
            "creationTimestamp": null,
            "name": "cmp-git",
            "namespace": "tfordpsthq"
          },
          "spec": {
            "app": "testing",
            "ports": [
              "8080/TCP"
            ],
            "source": "./",
            "sourceType": "local",
            "type": "nodejs"
          },
          "status": {
            "state": "Not Pushed"
          }
        }
    /go/src/github.com/openshift/odo/tests/integration/component.go:264 

Will hold this PR and investigate the cause.

/hold

[openshift-ci]

@dharmit: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/v4.6-integration-e2e	00bfa66	link	/test v4.6-integration-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[dharmit]

Closing since the tests helped figure that there's a legit use of the function I'm trying to remove in this PR.

/close

[openshift-ci-robot]

@dharmit: Closed this PR.

In response to this:

Closing since the tests helped figure that there's a legit use of the function I'm trying to remove in this PR.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.