Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow same initialization pattern as other clients #4323

Merged
merged 1 commit into from
Dec 21, 2020
Merged

Follow same initialization pattern as other clients #4323

merged 1 commit into from
Dec 21, 2020

Conversation

dharmit
Copy link
Member

@dharmit dharmit commented Dec 21, 2020

What type of PR is this?
/kind cleanup
/kind code-refactoring

What does this PR do / why we need it:
All the other clients are initiated in similar manner except
client.appsClient. This commit just makes things uniform.

Which issue(s) this PR fixes:

Fixes NA.
Part of #4298

PR acceptance criteria:

How to test changes / Special notes to the reviewer:
Tests should pass

All the other clients are initiated in similar manner except
`client.appsClient`. This commit just makes things uniform.
@dharmit dharmit changed the title Follow same pattern as other clients Follow same initialization pattern as other clients Dec 21, 2020
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dharmit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Dec 21, 2020
@mik-dass
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Dec 21, 2020
@mik-dass
Copy link
Contributor

https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_odo/4323/pull-ci-openshift-odo-master-v4.6-integration-e2e/1340983473195716608#1:build-log.txt%3A415

[odo] I1221 12:25:51.785682   12374 events.go:36] Quitting collect events
[odo]  ✗  Waiting for component to start [4m]
[odo]  ✗  waited 4m0s but couldn't find running pod matching selector: '

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit b8508f8 into redhat-developer:master Dec 21, 2020
@dharmit dharmit deleted the follow-same-pattern-to-create-client branch January 7, 2021 03:42
@rm3l rm3l added the area/refactoring Issues or PRs related to code refactoring label Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. area/refactoring Issues or PRs related to code refactoring lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants