Refactors storage code for localConfigProvider. #4344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mik-dass The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
mik-dass
force-pushed
the
local_storage_refactor
branch
from
6848849
to
301ae1d
Compare
mik-dass
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
mik-dass
force-pushed
the
local_storage_refactor
branch
4 times, most recently
from
7861cab
to
8895d77
Compare
dharmit
suggested changes
Jan 11, 2021
dharmit
suggested changes
Jan 11, 2021
mik-dass
force-pushed
the
local_storage_refactor
branch
from
8895d77
to
371c582
Compare
openshift-ci-robot
added
the
lgtm
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind code-refactoring
What does does this PR do / why we need it:
It adds storage related functions to the localConfigProvider and also refactors the storage create and delete CLI code to use them.
Which issue(s) this PR fixes:
Fixes part of #4298
PR acceptance criteria:
Unit test
Integration test
Documentation
I have read the test guidelines
How to test changes / Special notes to the reviewer: