Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactors storage List() to use Storage Client. #4395

Merged
merged 1 commit into from
Feb 3, 2021
Merged

Refactors storage List() to use Storage Client. #4395

merged 1 commit into from
Feb 3, 2021

Conversation

mik-dass
Copy link
Contributor

What type of PR is this?

/kind code-refactoring

What does does this PR do / why we need it:

Refactors storage List() to use Storage Client. It also adds ListFromCluster() to get storage from the cluster.

Which issue(s) this PR fixes:

Fixes part of #4298

PR acceptance criteria:

How to test changes / Special notes to the reviewer:

  • Tests should pass.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Jan 29, 2021
@mik-dass mik-dass force-pushed the storage_list_refactor branch 3 times, most recently from aff5ff1 to b61d3fd Compare January 29, 2021 14:10
dharmit
dharmit approved these changes Feb 1, 2021
View reviewed changes
Copy link
Member

@dharmit dharmit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Feb 1, 2021
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dharmit, mik-dass

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

9 similar comments
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@mik-dass
Copy link
Contributor Author

mik-dass commented Feb 1, 2021

Unit test flake
/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. Required by Prow. label Feb 1, 2021
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Feb 2, 2021
@dharmit
Copy link
Member

dharmit commented Feb 2, 2021

Was this force push #4395 (comment) done for the rebase purpose? Asking because it's a large PR and I don't know if I need to re-review something. 😄

@mik-dass
Copy link
Contributor Author

mik-dass commented Feb 2, 2021 •
edited
Loading

Was this force push #4395 (comment) done for the rebase purpose? Asking because it's a large PR and I don't know if I need to re-review something. smile

Yes, it was done for rebase purpose.

@mik-dass mik-dass removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. Required by Prow. label Feb 2, 2021
@mik-dass
Copy link
Contributor Author

mik-dass commented Feb 2, 2021

/retest

dharmit
dharmit approved these changes Feb 3, 2021
View reviewed changes
Copy link
Member

@dharmit dharmit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Feb 3, 2021
@openshift-merge-robot openshift-merge-robot merged commit 88fb372 into redhat-developer:master Feb 3, 2021
@mik-dass mik-dass deleted the storage_list_refactor branch February 3, 2021 09:29
kadel pushed a commit to kadel/odo that referenced this pull request Feb 4, 2021
@mik-dass @kadel
Refactors storage List() to use Storage Client. It also adds ListFrom…
9eaee42 
…Cluster() to get storage from the cluster. (redhat-developer#4395)
@rm3l rm3l added the area/refactoring Issues or PRs related to code refactoring label Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dharmit dharmit dharmit approved these changes

@prietyc123 prietyc123 Awaiting requested review from prietyc123

Assignees

@dharmit dharmit

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. area/refactoring Issues or PRs related to code refactoring lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@mik-dass @openshift-ci-robot @openshift-bot @dharmit @rm3l @openshift-merge-robot