Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add and remove service info from devfile #4465

Merged
merged 17 commits into from
Apr 12, 2021
Merged

Add and remove service info from devfile #4465

merged 17 commits into from
Apr 12, 2021

Commits on Apr 12, 2021

  1. Add and remove service info from devfile

    @dharmit
    dharmit committed Apr 12, 2021
    Configuration menu
    Copy the full SHA
    9bd5100 View commit details
    Browse the repository at this point in the history

  2. Changes function name and moves to service package 

    Changed function name from `AddServiceToDevfile` to
`AddKubernetesComponentToDevfile`. Similar name change for delete
function. Also, moves it from `pkg/envinfo` to `pkg/service` package
    @dharmit
    dharmit committed Apr 12, 2021
    Configuration menu
    Copy the full SHA
    e47816a View commit details
    Browse the repository at this point in the history

  3. Address Maysun's PR review comments

    @dharmit
    dharmit committed Apr 12, 2021
    Configuration menu
    Copy the full SHA
    ce17ce7 View commit details
    Browse the repository at this point in the history

  4. Modify storage create and delete to use changes in "devfile/library"

    @dharmit
    dharmit committed Apr 12, 2021
    Configuration menu
    Copy the full SHA
    7b99e9b View commit details
    Browse the repository at this point in the history

  5. Check for length of containers and mount paths

    @dharmit
    dharmit committed Apr 12, 2021
    Configuration menu
    Copy the full SHA
    2f07372 View commit details
    Browse the repository at this point in the history

  6. Don't ignore the errors; use t.Error

    @dharmit
    dharmit committed Apr 12, 2021
    Configuration menu
    Copy the full SHA
    5a044a2 View commit details
    Browse the repository at this point in the history

  7. Fixes based on PR review

    @dharmit
    dharmit committed Apr 12, 2021
    Configuration menu
    Copy the full SHA
    23340c4 View commit details
    Browse the repository at this point in the history

  8. Addressed Mrinal's review comments and fixed panic 

    "odo service create" without any arguments was panicking.
    @dharmit
    dharmit committed Apr 12, 2021
    Configuration menu
    Copy the full SHA
    33b0752 View commit details
    Browse the repository at this point in the history

  9. Fix integration tests 

    Fixing issues to play well with ConsentTelemetry being set to false
before each test runs and with the change in this PR to execute service
create and delete commands from the component's directory.
    @dharmit
    dharmit committed Apr 12, 2021
    Configuration menu
    Copy the full SHA
    2486d59 View commit details
    Browse the repository at this point in the history

  10. Removes wrongly commented code.

    @dharmit
    dharmit committed Apr 12, 2021
    Configuration menu
    Copy the full SHA
    c6f3855 View commit details
    Browse the repository at this point in the history

  11. Integration test for service create and delete

    @dharmit
    dharmit committed Apr 12, 2021
    Configuration menu
    Copy the full SHA
    36d56e1 View commit details
    Browse the repository at this point in the history

  12. Remove unnecessary newlines

    @dharmit
    dharmit committed Apr 12, 2021
    Configuration menu
    Copy the full SHA
    168ed94 View commit details
    Browse the repository at this point in the history

  13. Check devfile existence before anything else

    @dharmit
    dharmit committed Apr 12, 2021
    Configuration menu
    Copy the full SHA
    5166672 View commit details
    Browse the repository at this point in the history

  14. Common function to decide service provider backend

    @dharmit
    dharmit committed Apr 12, 2021
    Configuration menu
    Copy the full SHA
    bbf3617 View commit details
    Browse the repository at this point in the history

  15. Remove a test spec and modify another

    @dharmit
    dharmit committed Apr 12, 2021
    Configuration menu
    Copy the full SHA
    c9c73ad View commit details
    Browse the repository at this point in the history

  16. Adds incorrectly removed test spec back

    @dharmit
    dharmit committed Apr 12, 2021
    Configuration menu
    Copy the full SHA
    8a5b211 View commit details
    Browse the repository at this point in the history

  17. Correct the error message to expect

    @dharmit
    dharmit committed Apr 12, 2021
    Configuration menu
    Copy the full SHA
    130d862 View commit details
    Browse the repository at this point in the history