Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add unit test for url.Delete #528

Merged
merged 1 commit into from Jun 19, 2018
Merged

add unit test for url.Delete #528

merged 1 commit into from Jun 19, 2018

Conversation

syamgk
Copy link
Member

@syamgk syamgk commented Jun 14, 2018

add unit test for url.Delete

@syamgk syamgk added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. Required by Prow. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. Required by Prow. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. labels Jun 14, 2018
ashetty1
ashetty1 reviewed Jun 14, 2018
View reviewed changes
Copy link
Contributor

@ashetty1 ashetty1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

pkg/url/url_test.go Outdated

err := Delete(client, tt.args.name)
if (err != nil) != tt.wantErr {
t.Errorf("Create() error = %#v, wantErr %#v", err, tt.wantErr)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete()

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks good catch, changed

@syamgk
add unit test for url.Delete
a5835a8 
add unit test for url.Delete
@surajnarwade
Copy link
Contributor

LGTM

@kadel kadel merged commit 9372f94 into redhat-developer:master Jun 19, 2018
@surajnarwade
Copy link
Contributor

I think, this PR is breaking the master, @syamgk, can you please look into it ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashetty1 ashetty1 ashetty1 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@syamgk @surajnarwade @ashetty1 @kadel