New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add assertions for types implementing interfaces #5893
Add assertions for types implementing interfaces #5893
Conversation
✅ Deploy Preview for odo-docusaurus-preview canceled.
|
@feloy: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
55059b8
to
9fd2d2c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A big +1 for this.
Verifying interface compliance as much as possible at compile time is something recommended in the Coding Conventions wiki page: https://github.com/redhat-developer/odo/wiki/Dev:-Coding-Conventions#verify-interface-compliance
Connection was reset.
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dharmit The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/override ci/prow/unit |
@feloy: Overrode contexts on behalf of feloy: ci/prow/unit, ci/prow/v4.10-integration-e2e In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
9fd2d2c
to
3187b1c
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Network / devfile registry issues? /override windows-integration-test/Windows-test |
@feloy: Overrode contexts on behalf of feloy: ci/prow/v4.10-integration-e2e, windows-integration-test/Windows-test In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this:
/kind cleanup