Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add assertions for types implementing interfaces #5893

Merged

Conversation

feloy
Copy link
Contributor

@feloy feloy commented Jun 29, 2022

What type of PR is this:

/kind cleanup

@netlify
Copy link

netlify bot commented Jun 29, 2022

Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit 3187b1c
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/62bea34c5e408d00081a3b73

@openshift-ci
Copy link

openshift-ci bot commented Jun 29, 2022

@feloy: The label(s) kind/cleanup cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this:

/kind cleanup

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from cdrage and rm3l June 29, 2022 11:45
@feloy feloy removed the request for review from cdrage June 29, 2022 11:45
@odo-robot
Copy link

odo-robot bot commented Jun 29, 2022

Unit Tests on commit 2345e16 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 29, 2022

Kubernetes Tests on commit 2345e16 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 29, 2022

OpenShift Tests on commit 2345e16 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 29, 2022

Windows Tests (OCP) on commit 2345e16 finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 29, 2022

Validate Tests on commit 2345e16 finished successfully.
View logs: TXT HTML

@feloy feloy force-pushed the assertion-interface-implementation branch from 55059b8 to 9fd2d2c Compare June 29, 2022 16:25
Copy link
Member

@rm3l rm3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A big +1 for this.
Verifying interface compliance as much as possible at compile time is something recommended in the Coding Conventions wiki page: https://github.com/redhat-developer/odo/wiki/Dev:-Coding-Conventions#verify-interface-compliance

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jun 30, 2022
@feloy feloy closed this Jun 30, 2022
@feloy feloy reopened this Jun 30, 2022
@dharmit
Copy link
Member

dharmit commented Jul 1, 2022

Connection was reset.

✗  Downloading devfile "dotnet50" from registry "DefaultDevfileRegistry" [585ms]
   ✗  unable to download devfile: failed to pull stack dotnet50 from registry.stage.devfile.io/devfile-catalog/dotnet50:1.0.1 with allowed media types [application/vnd.devfileio.devfile.layer.v1 image/png image/svg+xml application/vnd.devfileio.vsx.layer.v1.tar application/x-tar]: failed to do request: Head "[https://registry.stage.devfile.io/v2/devfile-catalog/dotnet50/manifests/1.0.1":](https://registry.stage.devfile.io/v2/devfile-catalog/dotnet50/manifests/1.0.1%22:) read tcp 172.30.128.135:59098->3.83.37.194:443: read: connection reset by peer
  the command failed, the devfile has been removed from current directory
  
  ======================
  Unexpected error:
      <*fs.PathError | 0xc0006369f0>: {
          Op: "read",
          Path: "|0",
          Err: <*poll.DeadlineExceededError | 0x2b332a0>{},
      }
      read |0: i/o timeout
  occurred

@dharmit
Copy link
Member

dharmit commented Jul 1, 2022

/approve

@openshift-ci
Copy link

openshift-ci bot commented Jul 1, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dharmit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Jul 1, 2022
@feloy feloy closed this Jul 1, 2022
@feloy feloy reopened this Jul 1, 2022
@feloy
Copy link
Contributor Author

feloy commented Jul 1, 2022

/override ci/prow/unit
/override ci/prow/v4.10-integration-e2e

@openshift-ci
Copy link

openshift-ci bot commented Jul 1, 2022

@feloy: Overrode contexts on behalf of feloy: ci/prow/unit, ci/prow/v4.10-integration-e2e

In response to this:

/override ci/prow/unit
/override ci/prow/v4.10-integration-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@feloy feloy force-pushed the assertion-interface-implementation branch from 9fd2d2c to 3187b1c Compare July 1, 2022 07:33
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jul 1, 2022
@feloy feloy closed this Jul 1, 2022
@feloy feloy reopened this Jul 1, 2022
@sonarcloud
Copy link

sonarcloud bot commented Jul 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jul 1, 2022
@feloy
Copy link
Contributor Author

feloy commented Jul 1, 2022

[13] [odo] Interactive mode enabled, please answer the following questions:
[13] [odo]  -  Downloading devfile "go"  ...
[13] [odo] 
 X  Downloading devfile "go" [1s]
[13] [odo]  X  unable to download devfile: unable to find the registry with name "go"
[13] [odo] the command failed, the devfile has been removed from current directory

Network / devfile registry issues?

/override windows-integration-test/Windows-test
/override ci/prow/v4.10-integration-e2e

@openshift-ci
Copy link

openshift-ci bot commented Jul 1, 2022

@feloy: Overrode contexts on behalf of feloy: ci/prow/v4.10-integration-e2e, windows-integration-test/Windows-test

In response to this:

[13] [odo] Interactive mode enabled, please answer the following questions:
[13] [odo]  -  Downloading devfile "go"  ...
[13] [odo] 
X  Downloading devfile "go" [1s]
[13] [odo]  X  unable to download devfile: unable to find the registry with name "go"
[13] [odo] the command failed, the devfile has been removed from current directory

Network / devfile registry issues?

/override windows-integration-test/Windows-test
/override ci/prow/v4.10-integration-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot merged commit 0621602 into redhat-developer:main Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants