Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove command: odo project #6008

Merged
merged 2 commits into from Aug 10, 2022
Merged

Remove command: odo project #6008

merged 2 commits into from Aug 10, 2022

Conversation

valaparthvi
Copy link
Member

@valaparthvi valaparthvi commented Aug 5, 2022 •
edited

What type of PR is this:
/kind bug

What does this PR do / why we need it:
This PR removes odo project command.

Which issue(s) this PR fixes:

Fixes #

PR acceptance criteria:

  • [] Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:
I've simply delete pkg/odo/cli/project/* directory, and searched & replaced all instances of odo project <action> with odo <action> project.

@openshift-ci openshift-ci bot added the kind/bug Categorizes issue or PR as related to a bug. label Aug 5, 2022
@netlify
Copy link

netlify bot commented Aug 5, 2022 •
edited

✅ Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit d155db6
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/62f2854b4d2ee5000a4f379a

@odo-robot
Copy link

odo-robot bot commented Aug 5, 2022 •
edited

Unit Tests on commit 732779a finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Aug 5, 2022 •
edited

Windows Tests (OCP) on commit 732779a finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Aug 5, 2022 •
edited

Kubernetes Tests on commit 732779a finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Aug 5, 2022 •
edited

Validate Tests on commit 732779a finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Aug 5, 2022 •
edited

OpenShift Tests on commit 732779a finished successfully.
View logs: TXT HTML

@valaparthvi
Remove command: odo project
b99d7b1
@valaparthvi
Fix integration tests
d155db6 
Signed-off-by: Parthvi Vala <pvala@redhat.com>
@sonarcloud
Copy link

sonarcloud bot commented Aug 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.4% 0.4% Duplication

@feloy
Copy link
Contributor

feloy commented Aug 10, 2022

/approve

@openshift-ci
Copy link

openshift-ci bot commented Aug 10, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feloy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Aug 10, 2022
@valaparthvi valaparthvi requested a review from rm3l August 10, 2022 13:40
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Aug 10, 2022
@feloy
Copy link
Contributor

feloy commented Aug 10, 2022

/override ci/prow/v4.10-integration-e2e
Tests pass on IBM cloud

@openshift-ci
Copy link

openshift-ci bot commented Aug 10, 2022

@feloy: Overrode contexts on behalf of feloy: ci/prow/v4.10-integration-e2e

In response to this:

/override ci/prow/v4.10-integration-e2e
Tests pass on IBM cloud

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 0f14bd9 into redhat-developer:main Aug 10, 2022
feloy added a commit to feloy/odo that referenced this pull request Aug 18, 2022
@feloy
Revert "Remove command: odo project (redhat-developer#6008)"
98b49cf 
This reverts commit 0f14bd9.
cdrage pushed a commit to cdrage/odo that referenced this pull request Aug 31, 2022
@valaparthvi @cdrage
Remove command: odo project (redhat-developer#6008)
1b99d62 
* Remove command: odo project

* Fix integration tests

Signed-off-by: Parthvi Vala <pvala@redhat.com>

Signed-off-by: Parthvi Vala <pvala@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rm3l rm3l rm3l approved these changes

@anandrkskd anandrkskd Awaiting requested review from anandrkskd

@cdrage cdrage Awaiting requested review from cdrage

Assignees

@rm3l rm3l

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@valaparthvi @feloy @rm3l @openshift-merge-robot