Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cluster setup #6081

Merged

Conversation

cdrage
Copy link
Member

@cdrage cdrage commented Sep 1, 2022

Remove cluster setup

What type of PR is this:

/kind documentation

What does this PR do / why we need it:

Removes the clsuter setup section as it's no longer needed / we assume
that odo developers do not need to touch the cluster.

Which issue(s) this PR fixes:

Fixes #6080

Signed-off-by: Charlie Drage charlie@charliedrage.com

@netlify
Copy link

netlify bot commented Sep 1, 2022

Deploy Preview for odo-docusaurus-preview ready!

Name Link
🔨 Latest commit c010234
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/63176ce5137b0f0008e2a0d2
😎 Deploy Preview https://deploy-preview-6081--odo-docusaurus-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@odo-robot
Copy link

odo-robot bot commented Sep 1, 2022

Unit Tests on commit f40e6b5 finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Sep 1, 2022

Validate Tests on commit f40e6b5 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Sep 1, 2022

Kubernetes Tests on commit f40e6b5 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Sep 1, 2022

OpenShift Tests on commit f40e6b5 finished successfully.
View logs: TXT HTML

@valaparthvi
Copy link
Member

valaparthvi commented Sep 6, 2022

@cdrage Can you remove references of cluster-setup from add-binding.md and quickstart.md? But perhaps add the information about using SBO in add-binding section?

<!--
Thank you for opening a PR! Here are some things you need to know before submitting:

1. Please read our developer guideline: https://github.com/redhat-developer/odo/wiki/Dev:-odo-Dev-Guidelines
2. Label this PR accordingly with the '/kind' line
3. Ensure you have written and ran the appropriate tests: https://github.com/redhat-developer/odo/wiki/Dev:-Writing-and-running-tests
4. Read how we approve and LGTM each PR: https://github.com/redhat-developer/odo/wiki/Pull-Requests:-Review-guideline

Documentation:

If you are pushing a change to documentation, please read: https://github.com/redhat-developer/odo/wiki/Documentation:-Contributing
-->

**What type of PR is this:**

<!--
Add one of the following kinds:
/kind bug
/kind feature
/kind cleanup
/kind tests

Feel free to use other [labels](https://github.com/redhat-developer/odo/labels) as needed. However one of the above labels must be present or the PR will not be reviewed. This instruction is for reviewers as well.
-->
/kind documentation

**What does this PR do / why we need it:**

Removes the clsuter setup section as it's no longer needed / we assume
that odo developers do not need to touch the cluster.

**Which issue(s) this PR fixes:**
<!--
Specifying the issue will automatically close it when this PR is merged
-->

Fixes redhat-developer#6080

Signed-off-by: Charlie Drage <charlie@charliedrage.com>
@cdrage
Copy link
Member Author

cdrage commented Sep 6, 2022

@cdrage Can you remove references of cluster-setup from add-binding.md and quickstart.md? But perhaps add the information about using SBO in add-binding section?

Confused with regards to quickstart? The only cluster setup we have on there is namespace / project creation which is intentional from our cabal talks.

I've gone ahead and moved the references of SBO and removed the links that were no longer working in add-binding.

@odo-robot
Copy link

odo-robot bot commented Sep 6, 2022

Windows Tests (OCP) on commit f40e6b5 finished successfully.
View logs: TXT HTML

Signed-off-by: Charlie Drage <charlie@charliedrage.com>
@sonarcloud
Copy link

sonarcloud bot commented Sep 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.6% 0.6% Duplication

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Sep 7, 2022
@dharmit
Copy link
Member

dharmit commented Sep 7, 2022

/approve

@openshift-ci
Copy link

openshift-ci bot commented Sep 7, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dharmit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Sep 7, 2022
@valaparthvi
Copy link
Member

/override Unit-Tests/Unit-Tests

This PR represents docs change.

@openshift-ci
Copy link

openshift-ci bot commented Sep 7, 2022

@valaparthvi: Overrode contexts on behalf of valaparthvi: Unit-Tests/Unit-Tests

In response to this:

/override Unit-Tests/Unit-Tests

This PR represents docs change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit d65839e into redhat-developer:main Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove "Cluster Setup" section
4 participants