New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove cluster setup #6081
Remove cluster setup #6081
Conversation
✅ Deploy Preview for odo-docusaurus-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
@cdrage Can you remove references of cluster-setup from add-binding.md and quickstart.md? But perhaps add the information about using SBO in add-binding section? |
<!-- Thank you for opening a PR! Here are some things you need to know before submitting: 1. Please read our developer guideline: https://github.com/redhat-developer/odo/wiki/Dev:-odo-Dev-Guidelines 2. Label this PR accordingly with the '/kind' line 3. Ensure you have written and ran the appropriate tests: https://github.com/redhat-developer/odo/wiki/Dev:-Writing-and-running-tests 4. Read how we approve and LGTM each PR: https://github.com/redhat-developer/odo/wiki/Pull-Requests:-Review-guideline Documentation: If you are pushing a change to documentation, please read: https://github.com/redhat-developer/odo/wiki/Documentation:-Contributing --> **What type of PR is this:** <!-- Add one of the following kinds: /kind bug /kind feature /kind cleanup /kind tests Feel free to use other [labels](https://github.com/redhat-developer/odo/labels) as needed. However one of the above labels must be present or the PR will not be reviewed. This instruction is for reviewers as well. --> /kind documentation **What does this PR do / why we need it:** Removes the clsuter setup section as it's no longer needed / we assume that odo developers do not need to touch the cluster. **Which issue(s) this PR fixes:** <!-- Specifying the issue will automatically close it when this PR is merged --> Fixes redhat-developer#6080 Signed-off-by: Charlie Drage <charlie@charliedrage.com>
Confused with regards to quickstart? The only cluster setup we have on there is namespace / project creation which is intentional from our cabal talks. I've gone ahead and moved the references of SBO and removed the links that were no longer working in add-binding. |
d7cdd25
to
2866b7d
Compare
2866b7d
to
c010234
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dharmit The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/override Unit-Tests/Unit-Tests This PR represents docs change. |
@valaparthvi: Overrode contexts on behalf of valaparthvi: Unit-Tests/Unit-Tests In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Remove cluster setup
What type of PR is this:
/kind documentation
What does this PR do / why we need it:
Removes the clsuter setup section as it's no longer needed / we assume
that odo developers do not need to touch the cluster.
Which issue(s) this PR fixes:
Fixes #6080
Signed-off-by: Charlie Drage charlie@charliedrage.com