Try to reload config when disconnected from the cluster

[feloy]

What type of PR is this:

/kind bug

What does this PR do / why we need it:

1. When disconnected from the cluster and odo dev is interrupted with Ctrl-c, this message is displayed:

Error connecting to the cluster, the resources were not cleaned up.
Please log in again and cleanup the resource with `odo delete component

2. When disconnected from the cluster, odo dev tries to reload the configuration from kubeconfig file.

• If a change of namespace or cluster in the current context is detected, the configuration is not updated. The user can still update the current namespace / cluster
• if the namespace and cluster are the same, the new configuration is loaded, and odo dev continues with it

Keyboard Commands:
[Ctrl+c] - Exit and delete resources from the cluster
     [p] - Manually apply local changes to the application on the cluster
pPushing files...

Error connecting to the cluster. Please log in again

Error updating Kubernetes config: namespace changed ("prj3" -> "prj4"), won't refresh the configuration
Error connecting to the cluster. Please log in again

[...]
 Keyboard Commands:
[Ctrl+c] - Exit and delete resources from the cluster
     [p] - Manually apply local changes to the application on the cluster
pPushing files...

Error connecting to the cluster. Please log in again

Error updating Kubernetes config: cluster changed ("api-crc-testing:6443" -> "kubernetes"), won't refresh the configuration
Error connecting to the cluster. Please log in again

Error updating Kubernetes config: cluster changed ("api-crc-testing:6443" -> "kubernetes"), won't refresh the configuration
Error connecting to the cluster. Please log in again

[...]

Error connecting to the cluster. Please log in again

Updated Kubernetes config
 •  Waiting for Kubernetes resources  ...
 ✓  Syncing files into the container [1ms]

↪ Dev mode
 Status:
 Watching for changes in the current directory /home/phmartin/Documents/tests/go

 Keyboard Commands:
[Ctrl+c] - Exit and delete resources from the cluster
     [p] - Manually apply local changes to the application on the cluster

Which issue(s) this PR fixes:
Fixes #5668

PR acceptance criteria:

• Unit test

• Integration test

• Documentation

How to test changes / Special notes to the reviewer:

[terminal 1]
$ crc start
$ oc login -u developer https://api.crc.testing:6443

[terminal 2]
$ odo dev
[...]
↪ Dev mode
 Status:
 Watching for changes in the current directory /home/phmartin/Documents/tests/go

 Keyboard Commands:
[Ctrl+c] - Exit and delete resources from the cluster
     [p] - Manually apply local changes to the application on the cluster

[terminal 1]
$ oc logout

[terminal 2]
(repeat press [p] until the token is expired and error occurs)
pPushing files...

Error connecting to the cluster. Please log in again

Updated Kubernetes config
Error connecting to the cluster. Please log in again
[...]

[terminal 1]
$ oc login -u developer https://api.crc.testing:6443

[terminal 2]
Error connecting to the cluster. Please log in again

Updated Kubernetes config
 •  Waiting for Kubernetes resources  ...
 ✓  Syncing files into the container [1ms]

↪ Dev mode
 Status:
 Watching for changes in the current directory /home/phmartin/Documents/tests/go

 Keyboard Commands:
[Ctrl+c] - Exit and delete resources from the cluster
     [p] - Manually apply local changes to the application on the cluster

[netlify]

✅ Deploy Preview for odo-docusaurus-preview ready!

Name	Link
🔨 Latest commit	d0147ca
🔍 Latest deploy log	https://app.netlify.com/sites/odo-docusaurus-preview/deploys/632843d454b29d000883b04e
😎 Deploy Preview	https://deploy-preview-6130--odo-docusaurus-preview.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[odo-robot]

Unit Tests on commit a52a8a5 finished successfully.
View logs: TXT HTML

[odo-robot]

Kubernetes Tests on commit a52a8a5 finished successfully.
View logs: TXT HTML

[odo-robot]

OpenShift Tests on commit a52a8a5 finished successfully.
View logs: TXT HTML

[odo-robot]

Windows Tests (OCP) on commit a52a8a5 finished with errors.
View logs: TXT HTML

[odo-robot]

Validate Tests on commit a52a8a5 finished successfully.
View logs: TXT HTML

[rm3l]

Thanks for your work on this. LGTM feature-wise.

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rm3l

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rm3l]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[feloy]

Restart Windows tests

[feloy]

Problem resolving registry.npmjs.org on cluster dedicated to Windows tests.

Retesting

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

No Coverage information
0.0% Duplication

[dharmit]

@feloy I'm seeing a weird behaviour in that, when I do odo logout, odo manages to push the files just fine! I tried this multiple times to be sure before writing it here. It sounds/seems super absurd to me.

However, if I change the namespaces using odo set project, it complains about a changed namespace as well as it complains about not being able to connect to the cluster which I expected the first time around as well.

[feloy]

@feloy I'm seeing a weird behaviour in that, when I do odo logout, odo manages to push the files just fine! I tried this multiple times to be sure before writing it here. It sounds/seems super absurd to me.

Could you please share the exact commands and output

However, if I change the namespaces using odo set project, it complains about a changed namespace as well as it complains about not being able to connect to the cluster which I expected the first time around as well.

[feloy]

@feloy I'm seeing a weird behaviour in that, when I do odo logout, odo manages to push the files just fine! I tried this multiple times to be sure before writing it here. It sounds/seems super absurd to me.

Could you please share the exact commands and output

Sorry, I didn't see the video you shared.

As said in the Steps to reproduce:

(repeat press [p] until the token is expired and error occurs)

When you execute oc logout, the token is removed from your kubeconfig, and so next kubectl commands fail because it does not have access anymore to the token.

On the other side, odo dev has saved the token and will still use it until an error occurs. Errors occur only when the token is de-activated on the cluster side, which can happen long after oc logout.

I experimented very different duration for the token to be deactivated on the cluster, from 1 minute to ~ 10 minutes.

[dharmit]

/lgtm

Looked at 4 failed Windows jobs for this PR. A lot of failures are related to network issue:

npm ERR! network This is a problem related to network connectivity.

Hence, overriding Windows tests here because:

1. All other tests are passing
2. We need this feature in the next release.

/override windows-integration-test/Windows-test

[openshift-ci]

@dharmit: Overrode contexts on behalf of dharmit: windows-integration-test/Windows-test

In response to this:

/lgtm

Looked at 4 failed Windows jobs for this PR. A lot of failures are related to network issue:

npm ERR! network This is a problem related to network connectivity.

Hence, overriding Windows tests here because:

1. All other tests are passing
2. We need this feature in the next release.

/override windows-integration-test/Windows-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.