Delay the display of warnings related to experimental features

[feloy]

What type of PR is this:

/kind bug

What does this PR do / why we need it:

Which issue(s) this PR fixes:

Fixes #6374

PR acceptance criteria:

• Unit test

• Integration test

• Documentation

How to test changes / Special notes to the reviewer:

[netlify]

✅ Deploy Preview for odo-docusaurus-preview canceled.

Name	Link
🔨 Latest commit	f9d807c
🔍 Latest deploy log	https://app.netlify.com/sites/odo-docusaurus-preview/deploys/638db7149b84cc0009055753

[odo-robot]

NoCluster Tests on commit eaf9337 finished successfully.
View logs: TXT HTML

[odo-robot]

Unit Tests on commit eaf9337 finished successfully.
View logs: TXT HTML

[odo-robot]

Validate Tests on commit eaf9337 finished successfully.
View logs: TXT HTML

[odo-robot]

Kubernetes Tests on commit eaf9337 finished successfully.
View logs: TXT HTML

[odo-robot]

Windows Tests (OCP) on commit eaf9337 finished successfully.
View logs: TXT HTML

[odo-robot]

OpenShift Tests on commit eaf9337 finished with errors.
View logs: TXT HTML

[rm3l]

Thanks.

[valaparthvi]

/hold

[valaparthvi]

I think the behavior even after this fix is weird. This might not be related to this PR, but I'd like to talk about it anyway.

➜  ODO_EXPERIMENTAL_MODE=true odo list component
Experimental mode enabled for flag: --run-on. Use at your own risk. More details on https://odo.dev/docs/user-guides/advanced/experimental-mode
 ⚠  No connection to cluster defined
 ✓  Listing components from namespace '' 
 NAME      PROJECT TYPE  RUNNING IN  MANAGED 
 * nodejs  nodejs        None        Unknown 

Here I do not use --run-on flag with my command and yet I see the warning. I think the warning must only be displayed if the feature in question is used, regardless of whether the ODO_EXPERIMENTAL_MODE is set. WDYT?

[rm3l]

I think the behavior even after this fix is weird. This might not be related to this PR, but I'd like to talk about it anyway.

➜  ODO_EXPERIMENTAL_MODE=true odo list component
Experimental mode enabled for flag: --run-on. Use at your own risk. More details on https://odo.dev/docs/user-guides/advanced/experimental-mode
 ⚠  No connection to cluster defined
 ✓  Listing components from namespace '' 
 NAME      PROJECT TYPE  RUNNING IN  MANAGED 
 * nodejs  nodejs        None        Unknown 

Here I do not use --run-on flag with my command and yet I see the warning. I think the warning must only be displayed if the feature in question is used, regardless of whether the ODO_EXPERIMENTAL_MODE is set. WDYT?

Indeed. At the moment, this message might be displayed every time we call feature.IsEnabled to see if a given feature is enabled or not (even if we are not using it afterward).
Maybe we could just display a more global warning at the beginning, stating that the specified command is running in experimental mode when we detect that ODO_EXPERIMENTAL_MODE is true.

[rm3l]

I think the behavior even after this fix is weird. This might not be related to this PR, but I'd like to talk about it anyway.

➜  ODO_EXPERIMENTAL_MODE=true odo list component
Experimental mode enabled for flag: --run-on. Use at your own risk. More details on https://odo.dev/docs/user-guides/advanced/experimental-mode
 ⚠  No connection to cluster defined
 ✓  Listing components from namespace '' 
 NAME      PROJECT TYPE  RUNNING IN  MANAGED 
 * nodejs  nodejs        None        Unknown 

Here I do not use --run-on flag with my command and yet I see the warning. I think the warning must only be displayed if the feature in question is used, regardless of whether the ODO_EXPERIMENTAL_MODE is set. WDYT?

As discussed in standup, this is a valid point but not related to this PR.
I've created a separate issue for this: #6381

So I'm removing the hold to unblock other PRs waiting on this one.

/hold cancel

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[feloy]

/override OpenShift-Integration-tests/OpenShift-Integration-tests
Flaky e2e test

[openshift-ci]

@feloy: Overrode contexts on behalf of feloy: OpenShift-Integration-tests/OpenShift-Integration-tests

In response to this:

/override OpenShift-Integration-tests/OpenShift-Integration-tests
Flaky e2e test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[feloy]

/override ci/prow/v4.11-integration-e2e

[openshift-ci]

@feloy: Overrode contexts on behalf of feloy: ci/prow/v4.11-integration-e2e

In response to this:

/override ci/prow/v4.11-integration-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.