Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copy aritifacts only if ARTIFACT_DIR var is exposed #6402

Merged

Conversation

anandrkskd
Copy link
Contributor

@anandrkskd anandrkskd commented Dec 13, 2022

Signed-off-by: anandrkskd anandrkskd@gmail.com

/kind test

What does this PR do / why we need it:
InterOP tests uses scripts/openshiftci-presubmit-all-tests.sh script to run tests, which is failing due to copy of artifact as it's handled differently on their side.
This PR adds a check if ARTIFACT_DIR var is not provided, it will not copy tests result files

Which issue(s) this PR fixes:

Fixes #NA

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

Signed-off-by: anandrkskd <anandrkskd@gmail.com>
@netlify
Copy link

netlify bot commented Dec 13, 2022

Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit de8deb1
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/639823d0dc146c0008f5d735

@openshift-ci
Copy link

openshift-ci bot commented Dec 13, 2022

@anandrkskd: The label(s) kind/test cannot be applied, because the repository doesn't have them.

In response to this:

Signed-off-by: anandrkskd anandrkskd@gmail.com

/kind test

What does this PR do / why we need it:
InterOP tests uses scripts/openshiftci-presubmit-all-tests.sh script to run tests, which is failing due to copy of artifact as it's handled differently on their side.
This PR adds a check if ARTIFACT_DIR var is not provided, it will not copy tests result files
Which issue(s) this PR fixes:

Fixes #NA

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sonarcloud
Copy link

sonarcloud bot commented Dec 13, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.3% 0.3% Duplication

@odo-robot
Copy link

odo-robot bot commented Dec 13, 2022

OpenShift Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Dec 13, 2022

NoCluster Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Dec 13, 2022

Unit Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Dec 13, 2022

Validate Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Dec 13, 2022

Kubernetes Tests on commit finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Dec 13, 2022

Windows Tests (OCP) on commit finished successfully.
View logs: TXT HTML

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Dec 13, 2022
@rm3l rm3l added this to the v3.4.0 🚀 milestone Dec 13, 2022
@feloy
Copy link
Contributor

feloy commented Dec 13, 2022

/override Kubernetes-Integration-Tests/Kubernetes-Integration-Tests
Non-related flaky test

odo dev command tests
/go/odo_1/tests/integration/cmd_dev_test.go:31
  port-forwarding for the component
  /go/odo_1/tests/integration/cmd_dev_test.go:595
    when devfile has single endpoint
    /go/odo_1/tests/integration/cmd_dev_test.go:596
      when running odo dev
      /go/odo_1/tests/integration/cmd_dev_test.go:605
        when modifying memoryLimit for container in Devfile [BeforeEach]
        /go/odo_1/tests/integration/cmd_dev_test.go:639
          should expose the endpoint on localhost
          /go/odo_1/tests/integration/cmd_dev_test.go:655

/override podman-test/MyStage

@openshift-ci
Copy link

openshift-ci bot commented Dec 13, 2022

@feloy: Overrode contexts on behalf of feloy: Kubernetes-Integration-Tests/Kubernetes-Integration-Tests, podman-test/MyStage

In response to this:

/override Kubernetes-Integration-Tests/Kubernetes-Integration-Tests
Non-related flaky test

odo dev command tests
/go/odo_1/tests/integration/cmd_dev_test.go:31
 port-forwarding for the component
 /go/odo_1/tests/integration/cmd_dev_test.go:595
   when devfile has single endpoint
   /go/odo_1/tests/integration/cmd_dev_test.go:596
     when running odo dev
     /go/odo_1/tests/integration/cmd_dev_test.go:605
       when modifying memoryLimit for container in Devfile [BeforeEach]
       /go/odo_1/tests/integration/cmd_dev_test.go:639
         should expose the endpoint on localhost
         /go/odo_1/tests/integration/cmd_dev_test.go:655

/override podman-test/MyStage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit bb911ea into redhat-developer:main Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants