Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more tests for odo dev on Podman (2) #6506

Conversation

rm3l
Copy link
Member

@rm3l rm3l commented Jan 18, 2023

What type of PR is this:

What does this PR do / why we need it:

Which issue(s) this PR fixes:

ref #6447

First commits cherry-picked from #6482

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Jan 18, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jan 18, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@netlify
Copy link

netlify bot commented Jan 18, 2023

Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit e98da66
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/63c9285303be9f00090c395d

@odo-robot
Copy link

odo-robot bot commented Jan 18, 2023

NoCluster Tests on commit 5f0d83d finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jan 18, 2023

OpenShift Tests on commit 5f0d83d finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jan 18, 2023

Unit Tests on commit 5f0d83d finished successfully.
View logs: TXT HTML

@valaparthvi valaparthvi marked this pull request as ready for review January 18, 2023 09:42
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Jan 18, 2023
@odo-robot
Copy link

odo-robot bot commented Jan 18, 2023

Validate Tests on commit 5f0d83d finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jan 18, 2023

Windows Tests (OCP) on commit 5f0d83d finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jan 18, 2023

Kubernetes Tests on commit 5f0d83d finished successfully.
View logs: TXT HTML

@rm3l
Copy link
Member Author

rm3l commented Jan 18, 2023

For the 2nd test not passing on Podman ([FAIL] odo dev command tests port-forwarding for the component when devfile has single endpoint when running odo dev when modifying memoryLimit for container in Devfile [It] should react on the Devfile modification [podman]), I think we can cherry-pick e8f0815 (#6504) or wait until #6504 is merged in.

@feloy
Copy link
Contributor

feloy commented Jan 18, 2023

For the 2nd test not passing on Podman ([FAIL] odo dev command tests port-forwarding for the component when devfile has single endpoint when running odo dev when modifying memoryLimit for container in Devfile [It] should react on the Devfile modification [podman]), I think we can cherry-pick e8f0815 (#6504) or wait until #6504 is merged in.

Right, I'll test by cherry-picking the commit. Thanks

@feloy feloy force-pushed the 6447-add-more-tests-for-odo-dev-on-podman-2 branch from 561f631 to ab5c6c6 Compare January 19, 2023 09:25
@feloy
Copy link
Contributor

feloy commented Jan 19, 2023

Rebased to resolve conflicts

@sonarcloud
Copy link

sonarcloud bot commented Jan 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@rm3l
Copy link
Member Author

rm3l commented Jan 19, 2023

 ✓  Deleting resources not present in the Devfile: PodMetrics/myapp-inner [889ms]
      Error occurred on Push - watch command was unable to push component: unable to delete remote resources: unable to delete resource: PodMetrics/myapp-inner: the server does not allow this method on the requested resource
      
       •  Deleting resources not present in the Devfile: PodMetrics/myapp-inner  ...

...

Summarizing 1 Failure:
  [FAIL] odo logs command tests when component is created and odo logs is executed when running in Dev mode [BeforeEach] when --follow flag is specified should successfully follow logs of running component
  /go/odo_1/tests/helper/helper_run.go:51

odo logs tests failing on OpenShift - issue reported in #6475

/override OpenShift-Integration-tests/OpenShift-Integration-tests

Tests passing on Prow.

@openshift-ci
Copy link

openshift-ci bot commented Jan 19, 2023

@rm3l: Overrode contexts on behalf of rm3l: OpenShift-Integration-tests/OpenShift-Integration-tests

In response to this:

✓  Deleting resources not present in the Devfile: PodMetrics/myapp-inner [889ms]
     Error occurred on Push - watch command was unable to push component: unable to delete remote resources: unable to delete resource: PodMetrics/myapp-inner: the server does not allow this method on the requested resource
     
      •  Deleting resources not present in the Devfile: PodMetrics/myapp-inner  ...

...

Summarizing 1 Failure:
 [FAIL] odo logs command tests when component is created and odo logs is executed when running in Dev mode [BeforeEach] when --follow flag is specified should successfully follow logs of running component
 /go/odo_1/tests/helper/helper_run.go:51

odo logs tests failing on OpenShift - issue reported in #6475

/override OpenShift-Integration-tests/OpenShift-Integration-tests

Tests passing on Prow.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rm3l
Copy link
Member Author

rm3l commented Jan 19, 2023

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Jan 19, 2023

@rm3l: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rm3l rm3l added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jan 19, 2023
@openshift-merge-robot openshift-merge-robot merged commit a7f6d96 into redhat-developer:main Jan 19, 2023
@rm3l rm3l added this to the v3.6.0 🚀 milestone Jan 19, 2023
@rm3l rm3l deleted the 6447-add-more-tests-for-odo-dev-on-podman-2 branch January 19, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants