Added vendor-update command to makefile #671
Conversation
surajnarwade
force-pushed
the
makefile-vendor
branch
from
d210fd7
to
c829de5
Compare
This PR adds vendor-update command to Make, so that we can simply update vendor using `make vendor-update` command
surajnarwade
force-pushed
the
makefile-vendor
branch
from
c829de5
to
2618a4e
Compare
| # Update vendoring | ||
| .PHONY: vendor-update | ||
| vendor-update: | ||
| glide update --strip-vendor |
There was a problem hiding this comment.
shouldn't we add glide update -v before too?
There was a problem hiding this comment.
According to odo doc, this should be sufficient I guess.
I was thinking of adding glide-vc --only-code --no-tests as well
WDYT ?
There was a problem hiding this comment.
I don't think we're adding that anymore. Using glide-vc and all.
Maybe we should echo after vendor-update saying that the user should git add . and do a separate commit? Similar to how developers.md describes it.
There was a problem hiding this comment.
using glide-vc removes extra clutter which solves #670 as well
There was a problem hiding this comment.
I believe there's a reason why we don't use glide-vc, @kadel would know once he gets back.
There was a problem hiding this comment.
Got it, so as of now, we can merge this in
| # Update vendoring | ||
| .PHONY: vendor-update | ||
| vendor-update: | ||
| glide update --strip-vendor |
This PR adds vendor-update command to Make, so that
we can simply update vendor using
make vendor-updatecommand