Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CLI-reference related to service catalog #677

Merged
merged 2 commits into from
Aug 30, 2018

Conversation

surajnarwade
Copy link
Contributor

Added respective command reference related to service catalog in cli-reference.md
under docs section

@surajnarwade surajnarwade added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. Required by Prow. label Aug 29, 2018
@surajnarwade
Copy link
Contributor Author

Merge only when #413 gets merged

@cdrage
Copy link
Member

cdrage commented Aug 29, 2018

@surajnarwade You do know that we auto generate this from https://github.com/redhat-developer/odo/blob/master/scripts/cli-reference/generate-cli-reference.go right? We may have to close this PR.

@surajnarwade
Copy link
Contributor Author

I was not aware of that :(

Added respective command reference related to service catalog in `cli-reference.md`
under docs section
@surajnarwade
Copy link
Contributor Author

I used make generate-cli-structure to modify docs/cli-reference.md file now, so that new command reference will get added for odo service xxxx

@surajnarwade surajnarwade removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. Required by Prow. label Aug 30, 2018
Copy link
Member

@syamgk syamgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cdrage
Copy link
Member

cdrage commented Aug 30, 2018

LGTM!

@cdrage cdrage merged commit 1e7221f into redhat-developer:master Aug 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants