Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PODMAN_USE_NAMESPACES to disable using namespaces on podman integration tests for podman v4.5 #6774

Merged
merged 3 commits into from
Apr 27, 2023
Merged

PODMAN_USE_NAMESPACES to disable using namespaces on podman integration tests for podman v4.5 #6774

merged 3 commits into from
Apr 27, 2023

Conversation

feloy
Copy link
Contributor

@feloy feloy commented Apr 26, 2023 •
edited by valaparthvi
Loading

What type of PR is this:

This PR introduces a new env var for integration tests: PODMAN_USE_NAMESPACES

This is useful when running podman tests on a local system with podman v4.5.0, as namespace feature has been removed from podman v4.5

(tests on github actions are not impacted because running on podman v3)

When using this option, you need to take care of not running tests in parallel, or some tests could fail.

Ex:

PODMAN_USE_NAMESPACES=false make test-integration-podman

/area testing

What does this PR do / why we need it:

Which issue(s) this PR fixes:

Fixes #6773
6773 was not the original issue, but this PR still fixes it./=

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@openshift-ci openshift-ci bot added the area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering label Apr 26, 2023
@netlify
Copy link

netlify bot commented Apr 26, 2023 •
edited
Loading

✅ Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit 7629a71
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/644a23cbaa922b000797758d

@feloy feloy requested a review from rm3l April 26, 2023 15:00
@openshift-ci openshift-ci bot requested a review from anandrkskd April 26, 2023 15:00
@odo-robot
Copy link

odo-robot bot commented Apr 26, 2023 •
edited
Loading

OpenShift Unauthenticated Tests on commit 1e2f8f9 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Apr 26, 2023 •
edited
Loading

NoCluster Tests on commit 1e2f8f9 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Apr 26, 2023 •
edited
Loading

Unit Tests on commit 1e2f8f9 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Apr 26, 2023 •
edited
Loading

Validate Tests on commit 1e2f8f9 finished successfully.
View logs: TXT HTML

rm3l
rm3l approved these changes Apr 26, 2023
View reviewed changes
Copy link
Member

@rm3l rm3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! I'll check the workaround suggested by the Podman folks to isolate the tests, to see if that helps.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Apr 26, 2023
@rm3l rm3l added this to the v3.10.0 🚀 milestone Apr 26, 2023
@odo-robot
Copy link

odo-robot bot commented Apr 26, 2023 •
edited
Loading

Kubernetes Tests on commit 1e2f8f9 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Apr 26, 2023 •
edited
Loading

Windows Tests (OCP) on commit 1e2f8f9 finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Apr 26, 2023 •
edited
Loading

OpenShift Tests on commit 1468667 finished successfully.
View logs: TXT HTML

valaparthvi
valaparthvi reviewed Apr 27, 2023
View reviewed changes
tests/helper/helper_podman.go Outdated
@@ -14,6 +14,9 @@ import (
)

func GenerateAndSetContainersConf(dir string) {
if os.Getenv("PODMAN_USE_NAMESPACES") == "false" {
Copy link
Member

@valaparthvi valaparthvi Apr 27, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this can be a workaround for #6773 as well.

valaparthvi
valaparthvi reviewed Apr 27, 2023
View reviewed changes
tests/helper/helper_podman.go Outdated
@@ -14,6 +14,9 @@ import (
)

func GenerateAndSetContainersConf(dir string) {
if os.Getenv("PODMAN_USE_NAMESPACES") == "false" {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if os.Getenv("PODMAN_USE_NAMESPACES") == "false" {
useNamespace, _ := strconv.ParseBool(os.Getenv("PODMAN_USE_NAMESPACES"))
if !useNamespace {

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Apr 27, 2023
@feloy @valaparthvi
Update tests/helper/helper_podman.go
7629a71 
Co-authored-by: Parthvi Vala <pvala@redhat.com>
@sonarcloud
Copy link

sonarcloud bot commented Apr 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@odo-robot
Copy link

odo-robot bot commented Apr 27, 2023 •
edited
Loading

Kubernetes Docs Tests on commit 5913097 finished successfully.
View logs: TXT HTML

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Apr 27, 2023
@feloy
Copy link
Contributor Author

feloy commented Apr 27, 2023

/override windows-integration-test/Windows-test
/override OpenShift-Integration-tests/OpenShift-Integration-tests
Unrelated

@openshift-ci
Copy link

openshift-ci bot commented Apr 27, 2023

@feloy: Overrode contexts on behalf of feloy: OpenShift-Integration-tests/OpenShift-Integration-tests, windows-integration-test/Windows-test

In response to this:

/override windows-integration-test/Windows-test
/override OpenShift-Integration-tests/OpenShift-Integration-tests
Unrelated

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit ef9206a into redhat-developer:main Apr 27, 2023
3 checks passed
@valaparthvi valaparthvi mentioned this pull request Apr 27, 2023
Closed
rm3l added a commit to rm3l/odo that referenced this pull request Apr 28, 2023
@rm3l
Revert "PODMAN_USE_NAMESPACES to disable using namespaces on podman i…
cc8e632 
…ntegration tests for podman v4.5 (redhat-developer#6774)"

We'll completely remove the usage of namespaces in the tests, as this
wad removed from Podman v4.5.0, because namespaces on Podman were
reportedly not really working [1].

This reverts commit ef9206a.

[1]
containers/podman@c4fe0af
@rm3l rm3l mentioned this pull request Apr 28, 2023
Closed
3 tasks
@rm3l rm3l removed this from the v3.10.0 🚀 milestone May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rm3l rm3l rm3l approved these changes

@valaparthvi valaparthvi valaparthvi approved these changes

@anandrkskd anandrkskd Awaiting requested review from anandrkskd

Assignees

@rm3l rm3l

@valaparthvi valaparthvi

Labels
area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to run podman integration tests on MacOS
4 participants
@feloy @rm3l @valaparthvi @openshift-merge-robot