Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move parent devfiles in specific directories #6818

Merged
merged 1 commit into from May 16, 2023
Merged

Move parent devfiles in specific directories #6818

merged 1 commit into from May 16, 2023

Conversation

feloy
Copy link
Contributor

@feloy feloy commented May 15, 2023

What type of PR is this:

/kind bug
/area testing

What does this PR do / why we need it:

Which issue(s) this PR fixes:

Fixes #6817

The parent devfile is still copied into the current devfile. We need to wait for an option to not copy parent files.

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@netlify
Copy link

netlify bot commented May 15, 2023 •
edited

✅ Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit 0b8878e
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/64623dcebac6ae000882965b

@openshift-ci openshift-ci bot added kind/bug Categorizes issue or PR as related to a bug. area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering labels May 15, 2023
@feloy feloy requested a review from rm3l May 15, 2023 14:12
@openshift-ci openshift-ci bot requested a review from kadel May 15, 2023 14:12
@feloy feloy self-assigned this May 15, 2023
@feloy feloy requested review from rm3l and removed request for rm3l and kadel May 15, 2023 14:13
@feloy feloy removed their assignment May 15, 2023
@sonarcloud
Copy link

sonarcloud bot commented May 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@odo-robot
Copy link

odo-robot bot commented May 15, 2023

NoCluster Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented May 15, 2023

OpenShift Unauthenticated Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented May 15, 2023

Unit Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented May 15, 2023

Validate Tests on commit finished successfully.
View logs: TXT HTML

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label May 15, 2023
@odo-robot
Copy link

odo-robot bot commented May 15, 2023

Kubernetes Tests on commit finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented May 15, 2023

Windows Tests (OCP) on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented May 15, 2023

OpenShift Tests on commit finished with errors.
View logs: TXT HTML

@feloy
Copy link
Contributor Author

feloy commented May 16, 2023

/override kubernetes-infra-stage-test

@openshift-ci
Copy link

openshift-ci bot commented May 16, 2023

@feloy: Overrode contexts on behalf of feloy: kubernetes-infra-stage-test

In response to this:

/override kubernetes-infra-stage-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@feloy
Copy link
Contributor Author

feloy commented May 16, 2023

/override odo-podman-test

[FAILED] [20.419 seconds]
2023-05-15T14:32:46.4050044Z odo dev command tests port-forwarding for the component when devfile has multiple endpoints when running odo dev [BeforeEach] should expose all endpoints on localhost regardless of exposure(podman=true, manual=true, customPortForwarding=true, customAddress=false) [podman]

[...]

unable to access podman. Do you have podman client installed and configured correctly? cause: timeout (10s) while waiting for Podman version: context deadline exceeded: signal: killed: (read |0: file already closed). Please check the output of the following command: [podman version --format json]

@openshift-ci
Copy link

openshift-ci bot commented May 16, 2023

@feloy: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • odo-podman-test

Only the following failed contexts/checkruns were expected:

  • Kubernetes-Integration-Tests/Kubernetes-Integration-Tests
  • ODO-PODMAN-TEST
  • OpenShift-Integration-tests/OpenShift-Integration-tests
  • Unit-Tests/Unit-Tests
  • ci/prow/odo-ocp4.13-lp-interop-images
  • ci/prow/v4.10-images
  • ci/prow/v4.11-images
  • ci/prow/v4.12-images
  • ci/prow/v4.13-images
  • netlify/odo-docusaurus-preview/deploy-preview
  • pull-ci-redhat-developer-odo-main-odo-ocp4.13-lp-interop-images
  • pull-ci-redhat-developer-odo-main-v4.10-images
  • pull-ci-redhat-developer-odo-main-v4.11-images
  • pull-ci-redhat-developer-odo-main-v4.12-images
  • pull-ci-redhat-developer-odo-main-v4.13-images
  • tide
  • validator/Validate

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override odo-podman-test

[FAILED] [20.419 seconds]
2023-05-15T14:32:46.4050044Z odo dev command tests port-forwarding for the component when devfile has multiple endpoints when running odo dev [BeforeEach] should expose all endpoints on localhost regardless of exposure(podman=true, manual=true, customPortForwarding=true, customAddress=false) [podman]

[...]

unable to access podman. Do you have podman client installed and configured correctly? cause: timeout (10s) while waiting for Podman version: context deadline exceeded: signal: killed: (read |0: file already closed). Please check the output of the following command: [podman version --format json]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@feloy
Copy link
Contributor Author

feloy commented May 16, 2023

/override odo-podman-test / ODO-PODMAN-TEST

@openshift-ci
Copy link

openshift-ci bot commented May 16, 2023

@feloy: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • /
  • odo-podman-test

Only the following failed contexts/checkruns were expected:

  • Kubernetes-Integration-Tests/Kubernetes-Integration-Tests
  • ODO-PODMAN-TEST
  • OpenShift-Integration-tests/OpenShift-Integration-tests
  • Unit-Tests/Unit-Tests
  • ci/prow/odo-ocp4.13-lp-interop-images
  • ci/prow/v4.10-images
  • ci/prow/v4.11-images
  • ci/prow/v4.12-images
  • ci/prow/v4.13-images
  • netlify/odo-docusaurus-preview/deploy-preview
  • pull-ci-redhat-developer-odo-main-odo-ocp4.13-lp-interop-images
  • pull-ci-redhat-developer-odo-main-v4.10-images
  • pull-ci-redhat-developer-odo-main-v4.11-images
  • pull-ci-redhat-developer-odo-main-v4.12-images
  • pull-ci-redhat-developer-odo-main-v4.13-images
  • tide
  • validator/Validate

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override odo-podman-test / ODO-PODMAN-TEST

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@feloy
Copy link
Contributor Author

feloy commented May 16, 2023

/override ODO-PODMAN-TEST

@openshift-ci
Copy link

openshift-ci bot commented May 16, 2023

@feloy: Overrode contexts on behalf of feloy: ODO-PODMAN-TEST

In response to this:

/override ODO-PODMAN-TEST

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@feloy
Copy link
Contributor Author

feloy commented May 16, 2023

/override Kubernetes-Integration-Tests/Kubernetes-Integration-Tests
/override OpenShift-Integration-tests/OpenShift-Integration-tests

[FAILED] [170.059 seconds]
odo remove binding command tests when the component with binding is bootstrapped (bindingName=my-nodejs-app-cluster-sample-ocp) when odo dev is running when binding is removed [It] should have led odo dev to delete ServiceBinding from the cluster
/go/odo_1/tests/integration/cmd_remove_binding_test.go:71

@openshift-ci
Copy link

openshift-ci bot commented May 16, 2023

@feloy: Overrode contexts on behalf of feloy: Kubernetes-Integration-Tests/Kubernetes-Integration-Tests, OpenShift-Integration-tests/OpenShift-Integration-tests

In response to this:

/override Kubernetes-Integration-Tests/Kubernetes-Integration-Tests
/override OpenShift-Integration-tests/OpenShift-Integration-tests

[FAILED] [170.059 seconds]
odo remove binding command tests when the component with binding is bootstrapped (bindingName=my-nodejs-app-cluster-sample-ocp) when odo dev is running when binding is removed [It] should have led odo dev to delete ServiceBinding from the cluster
/go/odo_1/tests/integration/cmd_remove_binding_test.go:71

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 67709ff into redhat-developer:main May 16, 2023
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rm3l rm3l rm3l approved these changes

Assignees

@rm3l rm3l

Labels
area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move parent devfiles into specific directories
3 participants
@feloy @rm3l @openshift-merge-robot