Do not necessarily error out if odo dev is stopped via Ctrl+C
#6917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for odo-docusaurus-preview canceled.
|
openshift-ci
bot
added
kind/bug
rm3l
requested review from
feloy and
valaparthvi
and removed request for
kadel and
anandrkskd
|
Looking into the tests that are not passing... |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
rm3l
force-pushed
the
6514-ctrl-c-odo-dev-reported-as-an-error-in-telemetry
branch
2 times, most recently
from
21ec4e7
to
ceb4872
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
feloy
approved these changes
Jun 22, 2023
openshift-ci
bot
added
the
lgtm
See ExitInMain[1] and ExitInMain_ExitOnce[2] coding convention guidelines. [1] https://github.com/redhat-developer/odo/wiki/Dev:-Coding-Conventions#exit-in-main [2] https://github.com/redhat-developer/odo/wiki/Dev:-Coding-Conventions#exit-once
This makes sure the exit code of the command is mapped onto any error returned by Cleanup
rm3l
force-pushed
the
6514-ctrl-c-odo-dev-reported-as-an-error-in-telemetry
branch
from
ceb4872
to
9b891a7
Compare
openshift-ci
bot
removed
the
lgtm
|
Kudos, SonarCloud Quality Gate passed!
|
|
Had to rebase onto |
feloy
approved these changes
Jun 22, 2023
openshift-ci
bot
added
the
lgtm
openshift-merge-robot
merged commit 147542d
into
redhat-developer:main
19 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this:
/kind bug
/area dev
/area refactoring
What does this PR do / why we need it:
This PR makes sure hitting
Ctrl-Cis not reported as an error. Well, the exit code is mapped onto any error returned while cleaning up the Dev resources.But in telemetry, no error should be reported.
To do so, it first starts with refactoring error handling, making sure errors are propagated correctly up to the CLI layer, so that non-nil errors would propagate as non-zero exit code and nil errors will be propagated as zero exit code.
See [1] and [2] for the rationale.
[1] https://github.com/redhat-developer/odo/wiki/Dev:-Coding-Conventions#exit-in-main
[2] https://github.com/redhat-developer/odo/wiki/Dev:-Coding-Conventions#exit-once
Which issue(s) this PR fixes:
Fixes #6514
PR acceptance criteria:
Unit test
Integration test
Documentation
How to test changes / Special notes to the reviewer:
The exit code of
odo devis now mapped to the error returned when cleaning up the Dev resources. However, no error is reported in telemetry regardless of the status of the cleanup logic.