Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update description for odo app list #696

Merged
merged 1 commit into from
Sep 8, 2018

Conversation

cdrage
Copy link
Member

@cdrage cdrage commented Sep 5, 2018

Modifies the help description to keep in-line with odo list

Closes: #644

Short: "Lists all the applications",
Long: "Lists all the applications",
Example: ` # List all applications
Short: "List all applications in the current application",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be in current project. BTW, my PR #684 will also fix this

@surajnarwade
Copy link
Contributor

@cdrage, Since we are planning to provide global flags for project, application and component, it will be possible to list app, component of any project or application

Reference: #683

@cdrage
Copy link
Member Author

cdrage commented Sep 6, 2018

@surajnarwade Yup. This is just to fix: #644 I have updated the PR however!

Modifies the help description to keep in-line with `odo list`

Closes: redhat-developer#644
@cdrage
Copy link
Member Author

cdrage commented Sep 6, 2018

Updated the PR. If we can merge this it'll fix: #644 although I do know that #683 will be changing this in the future!

Copy link
Contributor

@piyush-garg piyush-garg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cdrage
Copy link
Member Author

cdrage commented Sep 6, 2018

This PR keeps failing tests for some reason. Super flakey. Do you know what's up @ashetty1 ?

Copy link
Contributor

@surajnarwade surajnarwade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😄

@piyush-garg
Copy link
Contributor

@cdrage You can merge this PR

@anmolbabu anmolbabu merged commit 110d11d into redhat-developer:master Sep 8, 2018
@cdrage cdrage deleted the fix-app-list branch January 14, 2022 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants