Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update go.mod with new location of the Alizer library #6962

Merged
merged 3 commits into from Jul 17, 2023
Merged

Update go.mod with new location of the Alizer library #6962

merged 3 commits into from Jul 17, 2023

Conversation

rm3l
Copy link
Member

@rm3l rm3l commented Jul 10, 2023

What type of PR is this:
/area dependency
/area refactoring

What does this PR do / why we need it:

Which issue(s) this PR fixes:
Fixes #6955

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. area/dependency Issues or PRs related to dependency changes. This label is also used on all Dependabot PRs labels Jul 10, 2023
@netlify
Copy link

netlify bot commented Jul 10, 2023 •
edited by github-actions bot

🔨 Deploy Preview deleted from internal cluster!

Name Link
🔨 Latest commit 8fbafa6
😎 Deploy Preview https://odo-dev-pr-6962.odo-test-kubernete-449701-49529fc6e6a4a9fe7ebba9a3db5b55c4-0000.eu-de.containers.appdomain.cloud/

@openshift-ci
Copy link

openshift-ci bot commented Jul 10, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the area/refactoring Issues or PRs related to code refactoring label Jul 10, 2023
@odo-robot
Copy link

odo-robot bot commented Jul 10, 2023 •
edited

OpenShift Unauthenticated Tests on commit b7080df finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jul 10, 2023 •
edited

NoCluster Tests on commit b7080df finished successfully.
View logs: TXT HTML

@rm3l rm3l added this to the v3.13.0 🚀 milestone Jul 10, 2023
@odo-robot
Copy link

odo-robot bot commented Jul 10, 2023 •
edited

Unit Tests on commit b7080df finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jul 10, 2023 •
edited

Validate Tests on commit b7080df finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jul 10, 2023 •
edited

Kubernetes Tests on commit b7080df finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jul 10, 2023 •
edited

OpenShift Tests on commit b7080df finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jul 10, 2023 •
edited

Windows Tests (OCP) on commit b7080df finished with errors.
View logs: TXT HTML

@rm3l rm3l changed the title [WIP] Update go.mod with new location of the Alizer library Update go.mod with new location of the Alizer library Jul 10, 2023
@rm3l rm3l marked this pull request as ready for review July 10, 2023 09:32
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Jul 10, 2023
@openshift-ci openshift-ci bot requested review from anandrkskd and feloy July 10, 2023 09:33
@odo-robot
Copy link

odo-robot bot commented Jul 10, 2023 •
edited

Kubernetes Docs Tests on commit bc16851 finished successfully.
View logs: TXT HTML

rm3l added 3 commits July 10, 2023 17:13
@rm3l
Update 'go.mod' with new location of the Alizer library
b446f99
@rm3l
Downgrade and pin conflicting versions of 'github.com/docker/{cli,dis…
ab8e172 
…tributions}'

Pinning it to the version we had before.
Otherwise, there were issues when running 'go mod tidy':

```
$ go mod tidy
go: downloading github.com/operator-framework/api v0.17.6
go: finding module for package github.com/docker/docker/pkg/term
github.com/redhat-developer/odo/pkg/auth imports
        github.com/openshift/oc/pkg/cli/login imports
                github.com/openshift/oc/pkg/helpers/term imports
                        github.com/docker/docker/pkg/term: module
                        github.com/docker/docker@latest found
                        (v24.0.4+incompatible), but does not contain
                        package github.com/docker/docker/pkg/term

```
@rm3l
Fix expected output in quickstart guides doc automation tests
8fbafa6
@rm3l rm3l force-pushed the 6955-update-go.mod-with-new-location-of-the-alizer-library branch from 7a36ed1 to 8fbafa6 Compare July 10, 2023 15:26
@rm3l rm3l temporarily deployed to internal July 10, 2023 15:26 — with GitHub Actions Inactive
@sonarcloud
Copy link

sonarcloud bot commented Jul 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@rm3l rm3l removed this from the v3.13.0 🚀 milestone Jul 13, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jul 17, 2023
@rm3l
Copy link
Member Author

rm3l commented Jul 17, 2023 

...
  [odo] I0710 10:42:11.597235    6276 starterserver.go:73] API Server started at localhost:20000/api/v1
  [odo] I0710 10:42:11.597235    6276 kubedev.go:86] Creating new adapter
  [odo] I0710 10:42:11.597235    6276 kubedev.go:94] Creating inner-loop resources for the component
  [odo] I0710 10:42:11.597235    6276 watch.go:101] starting WatchAndPush, path: C:\Users\Administrator.ANSIBLE-TEST-VS\AppData\Local\Temp\2800463584, component: ddgyrh, ignores [.git .odo .odo\odo-file-index.json]
  [odo] I0710 10:42:11.598528    6276 starterserver.go:93] Stopping the API server; encountered error: listen tcp :20000: bind: Only one usage of each socket address (protocol/network address/port) is normally permitted.
  [odo] I0710 10:42:11.598774    6276 file_watcher.go:130] adding watch on path C:\Users\Administrator.ANSIBLE-TEST-VS\AppData\Local\Temp\2800463584
  [odo] I0710 10:42:11.599541    6276 file_watcher.go:130] adding watch on path C:\Users\Administrator.ANSIBLE-TEST-VS\AppData\Local\Temp\2800463584\.odo
  [odo] I0710 10:42:11.599730    6276 file_watcher.go:130] adding watch on path C:\Users\Administrator.ANSIBLE-TEST-VS\AppData\Local\Temp\2800463584\test
  [odo] I0710 10:42:11.600502    6276 implem.go:114] The path for preference file is C:\Users\Administrator.ANSIBLE-TEST-VS\AppData\Local\Temp\618511318\preference.yaml
  [odo] I0710 10:42:11.600905    6276 segment.go:264] Checking telemetry enable status
  [odo] I0710 10:42:11.600905    6276 segment.go:282] Sending telemetry disabled by env variable
  [odo] Cleaning resources, please wait
  [odo]  X  error watching deployment: context canceled
  [FAILED] in [BeforeEach] - C:/Users/Administrator.ANSIBLE-TEST-VS/4360/tests/helper/helper_run.go:50 @ 07/10/23 10:42:21.443
  Deleting project: cmd-dev-api-server-test151zkw
...
Summarizing 1 Failure:
  [FAIL] odo dev command with api server tests when the component is bootstrapped when odo dev is run with --api-server flag [BeforeEach] when /component/command endpoint is POSTed should trigger a push
  C:/Users/Administrator.ANSIBLE-TEST-VS/4360/tests/helper/helper_run.go:50

Ran 382 of 940 Specs in 1278.907 seconds
FAIL! -- 381 Passed | 1 Failed | 0 Pending | 558 Skipped

Port conflict issue on Windows - reported in #6939

/override windows-integration-test/Windows-test

@openshift-ci
Copy link

openshift-ci bot commented Jul 17, 2023

@rm3l: Overrode contexts on behalf of rm3l: windows-integration-test/Windows-test

In response to this:

...
 [odo] I0710 10:42:11.597235    6276 starterserver.go:73] API Server started at localhost:20000/api/v1
 [odo] I0710 10:42:11.597235    6276 kubedev.go:86] Creating new adapter
 [odo] I0710 10:42:11.597235    6276 kubedev.go:94] Creating inner-loop resources for the component
 [odo] I0710 10:42:11.597235    6276 watch.go:101] starting WatchAndPush, path: C:\Users\Administrator.ANSIBLE-TEST-VS\AppData\Local\Temp\2800463584, component: ddgyrh, ignores [.git .odo .odo\odo-file-index.json]
 [odo] I0710 10:42:11.598528    6276 starterserver.go:93] Stopping the API server; encountered error: listen tcp :20000: bind: Only one usage of each socket address (protocol/network address/port) is normally permitted.
 [odo] I0710 10:42:11.598774    6276 file_watcher.go:130] adding watch on path C:\Users\Administrator.ANSIBLE-TEST-VS\AppData\Local\Temp\2800463584
 [odo] I0710 10:42:11.599541    6276 file_watcher.go:130] adding watch on path C:\Users\Administrator.ANSIBLE-TEST-VS\AppData\Local\Temp\2800463584\.odo
 [odo] I0710 10:42:11.599730    6276 file_watcher.go:130] adding watch on path C:\Users\Administrator.ANSIBLE-TEST-VS\AppData\Local\Temp\2800463584\test
 [odo] I0710 10:42:11.600502    6276 implem.go:114] The path for preference file is C:\Users\Administrator.ANSIBLE-TEST-VS\AppData\Local\Temp\618511318\preference.yaml
 [odo] I0710 10:42:11.600905    6276 segment.go:264] Checking telemetry enable status
 [odo] I0710 10:42:11.600905    6276 segment.go:282] Sending telemetry disabled by env variable
 [odo] Cleaning resources, please wait
 [odo]  X  error watching deployment: context canceled
 [FAILED] in [BeforeEach] - C:/Users/Administrator.ANSIBLE-TEST-VS/4360/tests/helper/helper_run.go:50 @ 07/10/23 10:42:21.443
 Deleting project: cmd-dev-api-server-test151zkw
...
Summarizing 1 Failure:
 [FAIL] odo dev command with api server tests when the component is bootstrapped when odo dev is run with --api-server flag [BeforeEach] when /component/command endpoint is POSTed should trigger a push
 C:/Users/Administrator.ANSIBLE-TEST-VS/4360/tests/helper/helper_run.go:50

Ran 382 of 940 Specs in 1278.907 seconds
FAIL! -- 381 Passed | 1 Failed | 0 Pending | 558 Skipped

Port conflict issue on Windows - reported in #6939

/override windows-integration-test/Windows-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit abdb1c5 into redhat-developer:main Jul 17, 2023
24 checks passed
@openshift-merge-robot openshift-merge-robot temporarily deployed to internal July 17, 2023 10:57 — with GitHub Actions Inactive
@rm3l rm3l deleted the 6955-update-go.mod-with-new-location-of-the-alizer-library branch July 17, 2023 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feloy feloy feloy approved these changes

@anandrkskd anandrkskd Awaiting requested review from anandrkskd

Assignees

@feloy feloy

Labels
area/dependency Issues or PRs related to dependency changes. This label is also used on all Dependabot PRs area/refactoring Issues or PRs related to code refactoring lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update go.mod with new location of the Alizer library
3 participants
@rm3l @feloy @openshift-merge-robot