Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove API Server from experimental mode, set UI Server as experimental #6985

Merged
merged 4 commits into from Jul 21, 2023
Merged

Remove API Server from experimental mode, set UI Server as experimental #6985

merged 4 commits into from Jul 21, 2023

Conversation

feloy
Copy link
Contributor

@feloy feloy commented Jul 19, 2023 •
edited by rm3l

What type of PR is this:

/kind feature

What does this PR do / why we need it:

Which issue(s) this PR fixes:

Fixes #6984

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@openshift-ci openshift-ci bot added the kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation label Jul 19, 2023
@netlify
Copy link

netlify bot commented Jul 19, 2023 •
edited

✅ Deploy Preview for odo-docusaurus-preview ready!

Name Link
🔨 Latest commit 17edd51
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/64ba46267bb91200089dc6bc
😎 Deploy Preview https://deploy-preview-6985--odo-docusaurus-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@openshift-ci openshift-ci bot requested review from kadel and valaparthvi July 19, 2023 14:42
@odo-robot
Copy link

odo-robot bot commented Jul 19, 2023 •
edited

OpenShift Unauthenticated Tests on commit fc36e5c finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jul 19, 2023 •
edited

NoCluster Tests on commit fc36e5c finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jul 19, 2023 •
edited

Unit Tests on commit fc36e5c finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jul 19, 2023 •
edited

Validate Tests on commit fc36e5c finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jul 19, 2023 •
edited

Kubernetes Tests on commit fc36e5c finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jul 19, 2023 •
edited

OpenShift Tests on commit fc36e5c finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jul 19, 2023 •
edited

Windows Tests (OCP) on commit fc36e5c finished successfully.
View logs: TXT HTML

@feloy feloy closed this Jul 19, 2023
@feloy feloy reopened this Jul 19, 2023
@odo-robot
Copy link

odo-robot bot commented Jul 19, 2023 •
edited

Kubernetes Docs Tests on commit 2516489 finished successfully.
View logs: TXT HTML

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jul 20, 2023
@rm3l
Copy link
Member

rm3l commented Jul 20, 2023 •
edited

/hold

Ran 400 of 956 Specs in 2148.357 seconds
FAIL! -- 178 Passed | 222 Failed | 0 Pending | 556 Skipped

Wow - we've got a lot of test failures on Windows. I think we need to set --api-server to false if options.StartAPIServer is false. I'm about to push changes for this..

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. Required by Prow. label Jul 20, 2023
@rm3l rm3l self-requested a review July 20, 2023 07:56
@rm3l rm3l removed lgtm Indicates that a PR is ready to be merged. Required by Prow. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. Required by Prow. labels Jul 20, 2023
@rm3l rm3l closed this Jul 20, 2023
@rm3l rm3l reopened this Jul 20, 2023
@rm3l rm3l closed this Jul 20, 2023
@rm3l rm3l reopened this Jul 20, 2023
@rm3l rm3l closed this Jul 20, 2023
@rm3l rm3l reopened this Jul 20, 2023
@rm3l
Copy link
Member

rm3l commented Jul 21, 2023 

Ran 407 of 958 Specs in 1320.924 seconds
SUCCESS! -- 407 Passed | 0 Failed | 0 Pending | 551 Skipped


Ginkgo ran 1 suite in 23m4.259613581s
...

  [FAILED] Expected
      <*url.Error | 0xc000528570>: 
      Post "http://127.0.0.1:36647/api/newuser": EOF
      {
          Op: "Post",
          URL: "http://127.0.0.1:36647/api/newuser",
          Err: <*errors.errorString | 0xc0001100f0>{s: "EOF"},
      }
  to be nil
  In [It] at: /go/odo_1/tests/e2escenarios/e2e_test.go:427 @ 07/20/23 22:37:04.395
...

Summarizing 1 Failure:
  [FAIL] E2E Test starting with non-empty Directory add Binding [It] should verify developer workflow of using binding as env in innerloop
  /go/odo_1/tests/e2escenarios/e2e_test.go:427

Ran 4 of 4 Specs in 236.471 seconds
FAIL! -- 3 Passed | 1 Failed | 0 Pending | 0 Skipped

Flaky E2E test (#6582)

/override OpenShift-Integration-tests/OpenShift-Integration-tests

@openshift-ci
Copy link

openshift-ci bot commented Jul 21, 2023

@rm3l: Overrode contexts on behalf of rm3l: OpenShift-Integration-tests/OpenShift-Integration-tests

In response to this:

Ran 407 of 958 Specs in 1320.924 seconds
SUCCESS! -- 407 Passed | 0 Failed | 0 Pending | 551 Skipped


Ginkgo ran 1 suite in 23m4.259613581s
...

 [FAILED] Expected
     <*url.Error | 0xc000528570>: 
     Post "http://127.0.0.1:36647/api/newuser": EOF
     {
         Op: "Post",
         URL: "http://127.0.0.1:36647/api/newuser",
         Err: <*errors.errorString | 0xc0001100f0>{s: "EOF"},
     }
 to be nil
 In [It] at: /go/odo_1/tests/e2escenarios/e2e_test.go:427 @ 07/20/23 22:37:04.395
...

Summarizing 1 Failure:
 [FAIL] E2E Test starting with non-empty Directory add Binding [It] should verify developer workflow of using binding as env in innerloop
 /go/odo_1/tests/e2escenarios/e2e_test.go:427

Ran 4 of 4 Specs in 236.471 seconds
FAIL! -- 3 Passed | 1 Failed | 0 Pending | 0 Skipped

Flaky E2E test (#6582)

/override OpenShift-Integration-tests/OpenShift-Integration-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rm3l
Copy link
Member

rm3l commented Jul 21, 2023 

  [odo] I0720 17:17:00.094628    2312 starterserver.go:107] Stopping the API server; encountered error: listen tcp :20000: bind: Only one usage of each socket address (protocol/network address/port) is normally permitted.

There are still too many failures on Windows, related to port conflict (#6939).
#6995 should fix that issue - let's rebase after that PR is merged.

@rm3l rm3l force-pushed the feature-6984/api-server-out-experimetal-mode branch from 1dab6fe to 7805867 Compare July 21, 2023 08:41
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. Required by Prow. label Jul 21, 2023
@rm3l rm3l force-pushed the feature-6984/api-server-out-experimetal-mode branch from 7805867 to 17edd51 Compare July 21, 2023 08:47
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. Required by Prow. label Jul 21, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jul 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@feloy
Copy link
Contributor Author

feloy commented Jul 21, 2023

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Jul 21, 2023

@feloy: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rm3l
rm3l approved these changes Jul 21, 2023
View reviewed changes
Copy link
Member

@rm3l rm3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feloy: you cannot LGTM your own PR.

On your behalf ;)
(The other changes look good to me as well)

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jul 21, 2023
@openshift-merge-robot openshift-merge-robot merged commit 9605c92 into redhat-developer:main Jul 21, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rm3l rm3l rm3l approved these changes

@kadel kadel Awaiting requested review from kadel

@valaparthvi valaparthvi Awaiting requested review from valaparthvi

Assignees

@rm3l rm3l

Labels
kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move odo dev API out of the experimental mode
3 participants
@feloy @rm3l @openshift-merge-robot