Fix latestReleaseTag() unit test #706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So.... we're exceeding GitHub's API limit: notify_test.go:18: error getting latest release TagName via API, error: GET https://api.github.com/repos/redhat-developer/odo/releases/latest: 403 API rate limit exceeded for 35.184.96.71. (But here's the good news: Authenticated requests get a higher rate limit. Check out the documentation for more details.) [rate reset in 19m23s]Because we're using the API for the test being written... We need to re-work this test. |
anmolbabu
reviewed
Sep 8, 2018
pkg/notify/notify_test.go
Outdated
| @@ -31,8 +31,8 @@ func Test_getLatestReleaseTag(t *testing.T) { | |||
|
|
|||
| for _, test := range tests { | |||
| t.Run(test.name, func(t *testing.T) { | |||
| releaseTag, _ := getLatestReleaseTag() | |||
| if test.success == true { | |||
| releaseTag, err := getLatestReleaseTag() | |||
There was a problem hiding this comment.
Can we mock this func instead using something like monkeypatching golang library and avoid genuine api call altogether? More info @ https://github.com/bouk/monkey
Why an actual get call in UT ? I feel if you can mock the expected output tht would be more than sufficient in my opinion
- remove the API call for compairing version - test getLatestReleaseTag for a valid Version
|
@syamgk thanks a lot , this LGTM 🎉 |
|
This LGTM! |
mik-dass
added a commit
to mik-dass/odo
that referenced
this pull request
Oct 17, 2018
* Fix latestReleaseTag() unit test * rephrase test - remove the API call for compairing version - test getLatestReleaseTag for a valid Version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #704