Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display icon in metadata #7078

Merged
merged 2 commits into from Sep 8, 2023
Merged

Display icon in metadata #7078

merged 2 commits into from Sep 8, 2023

Conversation

feloy
Copy link
Contributor

@feloy feloy commented Sep 8, 2023

What type of PR is this:

/kind feature

What does this PR do / why we need it:

Which issue(s) this PR fixes:

Fixes #7072

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@openshift-ci openshift-ci bot added the kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation label Sep 8, 2023
@feloy feloy requested a review from rm3l September 8, 2023 08:10
@netlify
Copy link

netlify bot commented Sep 8, 2023 •
edited

✅ Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit 54a7cc4
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/64fb080ea200130008235b23

@openshift-ci openshift-ci bot requested a review from kadel September 8, 2023 08:10
@odo-robot
Copy link

odo-robot bot commented Sep 8, 2023 •
edited

NoCluster Tests on commit c8e14ba finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Sep 8, 2023 •
edited

OpenShift Unauthenticated Tests on commit c8e14ba finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Sep 8, 2023 •
edited

Unit Tests on commit c8e14ba finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Sep 8, 2023 •
edited

Validate Tests on commit c8e14ba finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Sep 8, 2023 •
edited

Kubernetes Tests on commit c8e14ba finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Sep 8, 2023 •
edited

Windows Tests (OCP) on commit c8e14ba finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Sep 8, 2023 •
edited

OpenShift Tests on commit c8e14ba finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Sep 8, 2023 •
edited

Kubernetes Docs Tests on commit 1d96115 finished successfully.
View logs: TXT HTML

rm3l
rm3l approved these changes Sep 8, 2023
View reviewed changes
Copy link
Member

@rm3l rm3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just noticed that the Icon can also be a relative path in the project, and we won't preview such relative paths. But I think it is fine for now.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Sep 8, 2023
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Sep 8, 2023
@sonarcloud
Copy link

sonarcloud bot commented Sep 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Sep 8, 2023
@openshift-merge-robot openshift-merge-robot merged commit bfffaa8 into redhat-developer:main Sep 8, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rm3l rm3l rm3l approved these changes

@kadel kadel Awaiting requested review from kadel

Assignees

@rm3l rm3l

Labels
kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[UI] Display Devfile Icon (Metadata tab)
3 participants
@feloy @rm3l @openshift-merge-robot