Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix API Server panic when volume component has no ephemeral field set #7080

Conversation

rm3l
Copy link
Member

@rm3l rm3l commented Sep 8, 2023

What type of PR is this:
/kind bug

What does this PR do / why we need it:

Which issue(s) this PR fixes:
Fixes #7079

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:
See the retro steps in #7079

@netlify
Copy link

netlify bot commented Sep 8, 2023

Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit 261ca26
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/64fb2473a200130008293332

@openshift-ci openshift-ci bot added the kind/bug Categorizes issue or PR as related to a bug. label Sep 8, 2023
@sonarcloud
Copy link

sonarcloud bot commented Sep 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@openshift-ci openshift-ci bot requested review from feloy and kadel September 8, 2023 13:42
@odo-robot
Copy link

odo-robot bot commented Sep 8, 2023

OpenShift Unauthenticated Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Sep 8, 2023

NoCluster Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Sep 8, 2023

Unit Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Sep 8, 2023

Validate Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Sep 8, 2023

Kubernetes Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Sep 8, 2023

Windows Tests (OCP) on commit finished successfully.
View logs: TXT HTML

Copy link
Contributor

@feloy feloy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Sep 8, 2023
@odo-robot
Copy link

odo-robot bot commented Sep 8, 2023

OpenShift Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Sep 8, 2023

Kubernetes Docs Tests on commit bfffaa8 finished successfully.
View logs: TXT HTML

@openshift-merge-robot openshift-merge-robot merged commit 0deb3de into redhat-developer:main Sep 8, 2023
20 checks passed
@rm3l rm3l deleted the 7079-api-server-panics-when-trying-to-serve-java-wildfly-bootable-jar-devfile branch September 9, 2023 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API Server panics when Devfile Volume component has no ephemeral field set
3 participants