Fix watch error message for git components #713
Conversation
|
@mik-dass You need to add descriptive messages to your PR's as well as Git commit messages. Describe the issue as well as why the fix is needed 👍 After you've updated that ( |
A new error message is introduced for cases where 'watch' is initiated on a git component. Signed-off-by: mdas <mrinald7@gmail.com>
|
@cdrage Done. I also added a only after local components |
|
LGTM! 👍 |
| checkError(err, "Unable to get source for %s component.", componentName) | ||
|
|
||
| if sourceType != "binary" && sourcePath != "local" { |
There was a problem hiding this comment.
❗️ ❗️ ❗️
I think you wanted:
sourceType != "binary" && sourceType != "local"
not:
sourceType != "binary" && sourcePath != "local"
There was a problem hiding this comment.
That happens, no worries.
What is disappointing is that no one bothered to run and test this manually, not one of 3 people
that reviewed and approved this and apparently not even you who wrote it :-(
There was a problem hiding this comment.
Sorry again. I tested locally but only some of the negative cases as it was a small fix. Will be careful in the future.
A new error message is introduced for cases where 'watch' is initiated on a git component. Signed-off-by: mdas <mrinald7@gmail.com>
fixes #665
A new error message is introduced for cases where 'watch' is initiated on a git component.