Updated vendor with service catalog and client-go #716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
surajnarwade
force-pushed
the
tmpvendor
branch
from
6386be6
to
3707938
Compare
anmolbabu
approved these changes
Sep 11, 2018
surajnarwade
force-pushed
the
tmpvendor
branch
from
3707938
to
650be6a
Compare
syamgk
approved these changes
Sep 11, 2018
|
Only merge after testing it on windows |
mik-dass
approved these changes
Sep 11, 2018
There was a problem hiding this comment.
@surajnarwade Tested on windows and git clone and go build was successfully. Rest also LGTM.
|
@cdrage please review and merge |
|
This LGTM. |
mik-dass
pushed a commit
to mik-dass/odo
that referenced
this pull request
Oct 17, 2018
* Updated client-go, service-catalog * updated vendor * Removed go-github and k8s.io/api to resolve conflicts * updated vendor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated vendor with:
service-catalog: v0.1.31
openshift/client-go: 431ec9a26e5021f35fa41ee9a89842db9bfdb370