Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Momentarily remove project delete UT #719

Merged
merged 1 commit into from
Sep 11, 2018

Conversation

anmolbabu
Copy link
Contributor

Momentarily remove project delete UT until a better way to
stub ModifyConfig is found

fixes #718
Signed-off-by: anmolbabu anmolbudugutta@gmail.com

Momentarily remove project delete UT until a better way to
stub ModifyConfig is found

fixes redhat-developer#718
Signed-off-by: anmolbabu <anmolbudugutta@gmail.com>
Copy link
Contributor

@surajnarwade surajnarwade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Member

@syamgk syamgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@syamgk
Copy link
Member

syamgk commented Sep 11, 2018

https://github.com/bouk/monkey/blob/master/LICENSE.md
their license looks seriously weird

@surajnarwade surajnarwade merged commit 4d939c7 into redhat-developer:master Sep 11, 2018
@anmolbabu anmolbabu deleted the issue#718 branch September 11, 2018 08:14
mik-dass pushed a commit to mik-dass/odo that referenced this pull request Oct 17, 2018
Momentarily remove project delete UT until a better way to
stub ModifyConfig is found

fixes redhat-developer#718
Signed-off-by: anmolbabu <anmolbudugutta@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bouk/monkey(used for project delete UT) license says "Don't use it."
3 participants