Prevent odo fail if ~/.kube is not present
#739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. |
piyush-garg
previously approved these changes
Sep 14, 2018
|
This will resolve #738 |
cdrage
previously approved these changes
Sep 14, 2018
surajnarwade
dismissed stale reviews from cdrage and piyush-garg
via
827e41c
surajnarwade
force-pushed
the
check_error
branch
from
782858b
to
827e41c
Compare
surajnarwade
changed the title
~/.kube is not present
surajnarwade
changed the title
~/.kube is not present~/.kube is not present
|
No tests covering the original problem :-( |
kadel
reviewed
Sep 17, 2018
|
|
||
| // Check whether directory present or not | ||
| _, err = os.Stat(filepath.Dir(configFile)) | ||
| if os.IsNotExist(err) { |
There was a problem hiding this comment.
What if err is something else than IsNotExist?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.