Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate completion options in Gradle projects #137

Closed
xorye opened this issue Nov 4, 2019 · 5 comments · Fixed by #139
Closed

Duplicate completion options in Gradle projects #137

xorye opened this issue Nov 4, 2019 · 5 comments · Fixed by #139
Assignees
Labels
bug Something isn't working gradle properties Features supported in application.properties
Milestone

Comments

@xorye
Copy link

xorye commented Nov 4, 2019

There are duplicate completion items for quarkus.application.name and quarkus.application.version.

The duplication items show up consistently.

image

To reproduce this bug:

@fbricon fbricon added bug Something isn't working gradle properties Features supported in application.properties labels Nov 4, 2019
@angelozerr
Copy link
Contributor

@xorye if you see detail of duplicated completion item, is belong to the same extension name (quarkus-core)?

If you go to the definition for duplicated property is it the same class ?

@xorye
Copy link
Author

xorye commented Nov 4, 2019

Yes, they have the same extension name.
But once I have one of them in the application.properties file, the duplicate completion item goes away.
Here's a gif:
Duplicate property Gradle gif

If you go to the definition for duplicated property is it the same class ?

I'm not sure how to test this at the moment. Is there a way to go to definition without Ctrl+click on the property once the property is in the actual file?

@angelozerr
Copy link
Contributor

@xorye don't loose your time with this issue. I will try to reproduce it (today or tomorrow) . Hope I could reproduce it to understand the problem.

@angelozerr
Copy link
Contributor

Problem comes from that Eclipse Java classpath contains the quarkus-core-deployment.jar

image

When collect of Quarkus properties have processed, we build a new classpath which adds the quarkus-core-deployment.jar too, in other words the classpath which is used to process the search have 2 quarkus-core-deployment.jar which explains the duplicate Quarkus properties.

@fbricon
Copy link
Collaborator

fbricon commented Nov 5, 2019

The project uses gradle 5.5 which doesn't separate main and test classpaths. Everything, including test dependencies are available in the main classpath. You can change the gradle version to 5.6.4 in gradle/wrapper/gradle-wrapper.properties and update the project configuration.

angelozerr pushed a commit to angelozerr/quarkus-ls that referenced this issue Nov 5, 2019
Fixes redhat-developer#137

Signed-off-by: azerr <azerr@redhat.com>
angelozerr pushed a commit to angelozerr/quarkus-ls that referenced this issue Nov 6, 2019
Fixes redhat-developer#137

Signed-off-by: azerr <azerr@redhat.com>
angelozerr pushed a commit to angelozerr/quarkus-ls that referenced this issue Nov 6, 2019
Fixes redhat-developer#137

Signed-off-by: azerr <azerr@redhat.com>
@angelozerr angelozerr self-assigned this Nov 6, 2019
fbricon pushed a commit that referenced this issue Nov 7, 2019
Fixes #137

Signed-off-by: azerr <azerr@redhat.com>
@angelozerr angelozerr added this to the v0.0.4 milestone Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working gradle properties Features supported in application.properties
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants